From: Ulf Hansson <ulf.hansson@linaro.org>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Lee Jones" <lee.jones@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: core: Apply trim broken quirk to R1J57L
Date: Wed, 20 Jan 2021 14:40:41 +0100 [thread overview]
Message-ID: <CAPDyKFq+qyuHGbduGp30AeLefN1ie9ZL2Bvm9PrPZUwmdfQeYg@mail.gmail.com> (raw)
In-Reply-To: <20210118042717.2549123-1-xiaolei.wang@windriver.com>
On Mon, 18 Jan 2021 at 05:27, Xiaolei Wang <xiaolei.wang@windriver.com> wrote:
>
> R1J57L mmc chip hw capibility indicates that it supports trim function,
> but this function does not work properly, the SDIO bus does not respond,
> and the IO has been waiting so set quirks to skip trim
Are you sure this is an eMMC problem and not a mmc host driver issue?
Can you elaborate more what happens?
Kind regards
Uffe
>
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> ---
> drivers/mmc/core/quirks.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> index d68e6e513a4f..63e02391c133 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -89,6 +89,8 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
> MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
> MMC_FIXUP("VZL00M", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
> MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
> + MMC_FIXUP("R1J57L", CID_MANFID_MICRON, CID_OEMID_ANY, add_quirk_mmc,
> + MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
>
> /*
> * On Some Kingston eMMCs, performing trim can result in
> @@ -98,6 +100,8 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
> MMC_QUIRK_TRIM_BROKEN),
> MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
> MMC_QUIRK_TRIM_BROKEN),
> + MMC_FIXUP("R1J57L", CID_MANFID_MICRON, CID_OEMID_ANY, add_quirk_mmc,
> + MMC_QUIRK_TRIM_BROKEN),
>
> END_FIXUP
> };
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-01-20 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 4:27 [PATCH] mmc: core: Apply trim broken quirk to R1J57L Xiaolei Wang
2021-01-20 13:40 ` Ulf Hansson [this message]
2021-01-21 9:54 ` Wang, Xiaolei
2021-01-21 13:25 ` Ulf Hansson
2021-01-25 10:46 ` Fabio Estevam
2021-01-25 11:34 ` Bough Chen
2021-01-27 7:36 ` Bough Chen
2021-01-27 8:29 ` Wang, Xiaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFq+qyuHGbduGp30AeLefN1ie9ZL2Bvm9PrPZUwmdfQeYg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pali@kernel.org \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).