From: Stephen Langstaff <stephenlangstaff1@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org, OlteanV@gmail.com
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems
Date: Tue, 14 May 2024 10:28:55 +0100 [thread overview]
Message-ID: <CAHx5RXDaweFTF_Qt0GdBH4nBeMqwL4VVto7xzHBvFgFL5n=Ebg@mail.gmail.com> (raw)
In-Reply-To: <732d8bb2-1d4f-4958-b130-0bd15a407271@gmail.com>
On Mon, May 13, 2024 at 8:05 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> Attached is a configuration that I use on a x86-64 VM for testing that
> is started with:
That's kind of what I expect to be happening on my target, but it's not.
I notice that your configuration does not define CONFIG_FIXED_PHY as
either a module or built-in - could that explain both the fact that my
dsa_loop_bdinfo.c does not get compiled when using the default
Makefiles, and that if I force compilation to a module it does not
appear to create the expected lanX@eth0 interfaces?
I have added some printk debug lines to the dsa_loop_init and
dsa_loop_drv_probe functions, and only see the one from the init
function, which makes me suspect that something is stopping the probe
from happening - I assume this should happen when the dsa_loop_bdinfo
module is inserted?
root@machine:~/dsa_test# ls
dsa_loop.ko dsa_loop_bdinfo.ko
root@machine:~/dsa_test# modprobe dsa_core
root@machine:~/dsa_test#
root@machine:~/dsa_test# insmod dsa_loop_bdinfo.ko
[ 51.742367] dsa_loop_bdinfo_init
root@machine:~/dsa_test# insmod dsa_loop.ko
[ 58.485104] dsa_loop_init
root@machine:~/dsa_test# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
mode DEFAULT group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP
mode DEFAULT group default qlen 1000
link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
3: eth1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state
DOWN mode DEFAULT group default qlen 1000
link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
4: can0: <NOARP,ECHO> mtu 16 qdisc noop state DOWN mode DEFAULT group
default qlen 10
link/can
next prev parent reply other threads:[~2024-05-14 9:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 15:33 drivers/net/dsa/dsa_loop_bdinfo.c build problems Stephen Langstaff
2024-05-13 15:34 ` Florian Fainelli
2024-05-13 15:36 ` Stephen Langstaff
2024-05-13 15:40 ` Florian Fainelli
2024-05-13 15:45 ` Stephen Langstaff
2024-05-13 15:50 ` Florian Fainelli
2024-05-13 16:21 ` Stephen Langstaff
2024-05-13 16:54 ` Andrew Lunn
2024-05-13 17:40 ` Stephen Langstaff
2024-05-13 17:54 ` Andrew Lunn
[not found] ` <CAHx5RXCF0=Soz_k88RGvJFGrajaxn=mVnqpb99GAQ=b7XOcWiw@mail.gmail.com>
2024-05-13 19:05 ` Florian Fainelli
2024-05-14 9:28 ` Stephen Langstaff [this message]
2024-05-14 12:32 ` Andrew Lunn
2024-05-14 16:08 ` Stephen Langstaff
2024-05-14 16:17 ` Andrew Lunn
2024-05-15 4:05 ` Florian Fainelli
2024-05-15 19:20 ` Florian Fainelli
2024-05-16 2:17 ` Masahiro Yamada
2024-05-16 3:35 ` Florian Fainelli
2024-05-16 6:39 ` Masahiro Yamada
2024-05-15 9:23 ` Stephen Langstaff
2024-05-15 19:26 ` Florian Fainelli
2024-05-16 9:27 ` Stephen Langstaff
-- strict thread matches above, loose matches on Subject: below --
2024-05-13 14:43 Stephen Langstaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHx5RXDaweFTF_Qt0GdBH4nBeMqwL4VVto7xzHBvFgFL5n=Ebg@mail.gmail.com' \
--to=stephenlangstaff1@gmail.com \
--cc=OlteanV@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).