* [PATCH] reset: reset-meson: add support for the Meson-S4 SoC Reset Controller
@ 2021-12-27 9:01 Zelong Dong
2021-12-27 18:10 ` Martin Blumenstingl
0 siblings, 1 reply; 2+ messages in thread
From: Zelong Dong @ 2021-12-27 9:01 UTC (permalink / raw
To: p.zabel, khilman, narmstrong, martin.blumenstingl
Cc: linux-amlogic, linux-kernel, linux-arm-kernel, jbrunet,
Zelong Dong
Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
---
drivers/reset/reset-meson.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
index c9bc325ad65a..26dc54778615 100644
--- a/drivers/reset/reset-meson.c
+++ b/drivers/reset/reset-meson.c
@@ -98,11 +98,17 @@ static const struct meson_reset_param meson_a1_param = {
.level_offset = 0x40,
};
+static const struct meson_reset_param meson_s4_param = {
+ .reg_count = 6,
+ .level_offset = 0x40,
+};
+
static const struct of_device_id meson_reset_dt_ids[] = {
{ .compatible = "amlogic,meson8b-reset", .data = &meson8b_param},
{ .compatible = "amlogic,meson-gxbb-reset", .data = &meson8b_param},
{ .compatible = "amlogic,meson-axg-reset", .data = &meson8b_param},
{ .compatible = "amlogic,meson-a1-reset", .data = &meson_a1_param},
+ { .compatible = "amlogic,meson-s4-reset", .data = &meson_s4_param},
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: reset-meson: add support for the Meson-S4 SoC Reset Controller
2021-12-27 9:01 [PATCH] reset: reset-meson: add support for the Meson-S4 SoC Reset Controller Zelong Dong
@ 2021-12-27 18:10 ` Martin Blumenstingl
0 siblings, 0 replies; 2+ messages in thread
From: Martin Blumenstingl @ 2021-12-27 18:10 UTC (permalink / raw
To: Zelong Dong
Cc: p.zabel, khilman, Neil Armstrong, linux-amlogic, linux-kernel,
linux-arm-kernel, jbrunet
Hello,
thank you for this patch!
On Mon, Dec 27, 2021 at 10:01 AM Zelong Dong <zelong.dong@amlogic.com> wrote:
>
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
Most maintainers don't take patches without a proper description.
./scripts/checkpatch.pl this.patch states:
WARNING: Missing commit description - Add an appropriate one
I suggest something like:
"Compared to the A1 SoCs the number of RESET registers is different
and the offset for the level registers is the same. Add a new
compatible string and struct meson_reset_param to add support for the
reset controller on the S4 SoC."
[...]
> + { .compatible = "amlogic,meson-s4-reset", .data = &meson_s4_param},
checkpatch reports here:
WARNING: DT compatible string "amlogic,meson-s4-reset" appears
un-documented -- check ./Documentation/devicetree/bindings/
My suggestion is to take your previous dt-bindings patch for the reset
controller and to extend it with one entry in
Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml just
like it was done for the A1 SoC: [0]
Then take both patches (dt-binding and driver) and send them as one
series, so it's clear to the reset-maintainers and reviewers that
these patches belong together.
Best regards,
Martin
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d9730b9eb05a349c278a9f6f058ebefa9063def
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-27 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-27 9:01 [PATCH] reset: reset-meson: add support for the Meson-S4 SoC Reset Controller Zelong Dong
2021-12-27 18:10 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).