* error: implicit declaration of function 'msleep' (was: Re: [media] radio-aimslab.c: Fix gcc 4.5+ bug)
@ 2011-01-10 19:48 Geert Uytterhoeven
0 siblings, 0 replies; only message in thread
From: Geert Uytterhoeven @ 2011-01-10 19:48 UTC (permalink / raw
To: Mauro Carvalho Chehab, Andrew Morton; +Cc: Linux Kernel Mailing List, stable
On Fri, Jan 7, 2011 at 04:02, Linux Kernel Mailing List
<linux-kernel@vger.kernel.org> wrote:
> Gitweb: http://git.kernel.org/linus/e3c92215198cb6aa00ad38db2780faa6b72e0a3f
> Commit: e3c92215198cb6aa00ad38db2780faa6b72e0a3f
> Parent: a7862aa90ffd1113bc2898ae6be2e4861b1f76cc
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> AuthorDate: Thu Jan 6 08:16:04 2011 -0200
> Committer: Mauro Carvalho Chehab <mchehab@redhat.com>
> CommitDate: Thu Jan 6 08:26:02 2011 -0200
>
> [media] radio-aimslab.c: Fix gcc 4.5+ bug
>
> gcc 4.5+ doesn't properly evaluate some inlined expressions.
> A previous patch were proposed by Andrew Morton using noinline.
> However, the entire inlined function is bogus, so let's just
> remove it and be happy.
>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: stable@kernel.org
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> drivers/media/radio/radio-aimslab.c | 23 ++++++-----------------
> 1 files changed, 6 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/media/radio/radio-aimslab.c b/drivers/media/radio/radio-aimslab.c
> index 05e832f..6cc5d13 100644
> --- a/drivers/media/radio/radio-aimslab.c
> +++ b/drivers/media/radio/radio-aimslab.c
> @@ -31,7 +31,6 @@
> #include <linux/module.h> /* Modules */
> #include <linux/init.h> /* Initdata */
> #include <linux/ioport.h> /* request_region */
> -#include <linux/delay.h> /* udelay */
Woops...
> static void rt_decvol(struct rtrack *rt)
> {
> outb(0x58, rt->io); /* volume down + sigstr + on */
> - sleep_delay(100000);
> + msleep(100);
... still needed due to msleep(), cfr.
http://kisskb.ellerman.id.au/kisskb/buildresult/3776074/:
| drivers/media/radio/radio-aimslab.c:76: error: implicit declaration
of function 'msleep'
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-10 19:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 19:48 error: implicit declaration of function 'msleep' (was: Re: [media] radio-aimslab.c: Fix gcc 4.5+ bug) Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).