LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS
@ 2024-03-13 12:53 Luca Weiss
  2024-03-13 12:53 ` [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine Luca Weiss
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Luca Weiss @ 2024-03-13 12:53 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Herbert Xu, David S. Miller,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	cros-qcom-dts-watchers
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel, Luca Weiss

Add the required bits to support Inline Crypto Engine on SC7280 SoC with
UFS.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (2):
      dt-bindings: crypto: ice: Document sc7280 inline crypto engine
      arm64: dts: qcom: sc7280: Add inline crypto engine

 .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml    | 1 +
 arch/arm64/boot/dts/qcom/sc7280.dtsi                             | 9 +++++++++
 2 files changed, 10 insertions(+)
---
base-commit: 5f19977109ce685937fee9feea9b807599dfc925
change-id: 20231208-sc7280-ice-a550626bfc09

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine
  2024-03-13 12:53 [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Luca Weiss
@ 2024-03-13 12:53 ` Luca Weiss
  2024-03-13 16:47   ` Krzysztof Kozlowski
  2024-03-28 10:54   ` Herbert Xu
  2024-03-13 12:53 ` [PATCH 2/2] arm64: dts: qcom: sc7280: Add " Luca Weiss
  2024-04-04 21:23 ` (subset) [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Bjorn Andersson
  2 siblings, 2 replies; 7+ messages in thread
From: Luca Weiss @ 2024-03-13 12:53 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Herbert Xu, David S. Miller,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	cros-qcom-dts-watchers
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel, Luca Weiss

Document the compatible used for the inline crypto engine found on
SC7280.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index 09e43157cc71..a43527fb2ceb 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -14,6 +14,7 @@ properties:
     items:
       - enum:
           - qcom,sa8775p-inline-crypto-engine
+          - qcom,sc7280-inline-crypto-engine
           - qcom,sm8450-inline-crypto-engine
           - qcom,sm8550-inline-crypto-engine
           - qcom,sm8650-inline-crypto-engine

-- 
2.44.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sc7280: Add inline crypto engine
  2024-03-13 12:53 [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Luca Weiss
  2024-03-13 12:53 ` [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine Luca Weiss
@ 2024-03-13 12:53 ` Luca Weiss
  2024-03-13 13:06   ` Konrad Dybcio
  2024-04-04 21:23 ` (subset) [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Bjorn Andersson
  2 siblings, 1 reply; 7+ messages in thread
From: Luca Weiss @ 2024-03-13 12:53 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Herbert Xu, David S. Miller,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	cros-qcom-dts-watchers
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel, Luca Weiss

Add the ICE found on sc7280 and link it to the UFS node.

For reference:

  [    0.261424] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 83b5b76ba179..3ea5f9cf040e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2314,6 +2314,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 				<0 0>,
 				<0 0>,
 				<0 0>;
+			qcom,ice = <&ice>;
+
 			status = "disabled";
 		};
 
@@ -2336,6 +2338,13 @@ ufs_mem_phy: phy@1d87000 {
 			status = "disabled";
 		};
 
+		ice: crypto@1d88000 {
+			compatible = "qcom,sc7280-inline-crypto-engine",
+				     "qcom,inline-crypto-engine";
+			reg = <0 0x01d88000 0 0x8000>;
+			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
+		};
+
 		cryptobam: dma-controller@1dc4000 {
 			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
 			reg = <0x0 0x01dc4000 0x0 0x28000>;

-- 
2.44.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add inline crypto engine
  2024-03-13 12:53 ` [PATCH 2/2] arm64: dts: qcom: sc7280: Add " Luca Weiss
@ 2024-03-13 13:06   ` Konrad Dybcio
  0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2024-03-13 13:06 UTC (permalink / raw
  To: Luca Weiss, Bjorn Andersson, Herbert Xu, David S. Miller,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	cros-qcom-dts-watchers
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel



On 3/13/24 13:53, Luca Weiss wrote:
> Add the ICE found on sc7280 and link it to the UFS node.
> 
> For reference:
> 
>    [    0.261424] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine
  2024-03-13 12:53 ` [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine Luca Weiss
@ 2024-03-13 16:47   ` Krzysztof Kozlowski
  2024-03-28 10:54   ` Herbert Xu
  1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-13 16:47 UTC (permalink / raw
  To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
	David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	cros-qcom-dts-watchers
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel

On 13/03/2024 13:53, Luca Weiss wrote:
> Document the compatible used for the inline crypto engine found on
> SC7280.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine
  2024-03-13 12:53 ` [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine Luca Weiss
  2024-03-13 16:47   ` Krzysztof Kozlowski
@ 2024-03-28 10:54   ` Herbert Xu
  1 sibling, 0 replies; 7+ messages in thread
From: Herbert Xu @ 2024-03-28 10:54 UTC (permalink / raw
  To: Luca Weiss
  Cc: Bjorn Andersson, Konrad Dybcio, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
	~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel

On Wed, Mar 13, 2024 at 01:53:14PM +0100, Luca Weiss wrote:
> Document the compatible used for the inline crypto engine found on
> SC7280.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS
  2024-03-13 12:53 [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Luca Weiss
  2024-03-13 12:53 ` [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine Luca Weiss
  2024-03-13 12:53 ` [PATCH 2/2] arm64: dts: qcom: sc7280: Add " Luca Weiss
@ 2024-04-04 21:23 ` Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2024-04-04 21:23 UTC (permalink / raw
  To: Konrad Dybcio, Herbert Xu, David S. Miller, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
	Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	linux-crypto, devicetree, linux-kernel


On Wed, 13 Mar 2024 13:53:13 +0100, Luca Weiss wrote:
> Add the required bits to support Inline Crypto Engine on SC7280 SoC with
> UFS.
> 
> 

Applied, thanks!

[2/2] arm64: dts: qcom: sc7280: Add inline crypto engine
      commit: dfd5ee7b34bb7611d4d2f4f3cb37152baeaae96d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-04-04 21:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 12:53 [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Luca Weiss
2024-03-13 12:53 ` [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine Luca Weiss
2024-03-13 16:47   ` Krzysztof Kozlowski
2024-03-28 10:54   ` Herbert Xu
2024-03-13 12:53 ` [PATCH 2/2] arm64: dts: qcom: sc7280: Add " Luca Weiss
2024-03-13 13:06   ` Konrad Dybcio
2024-04-04 21:23 ` (subset) [PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).