* [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit.
@ 2008-10-28 12:06 Will Newton
2008-11-02 13:46 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Will Newton @ 2008-10-28 12:06 UTC (permalink / raw
To: linux-kernel; +Cc: netdev, Jeff Garzik
[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]
>From 0e3ec7f78e115533e4aca9ac067acbc33eb0a21f Mon Sep 17 00:00:00 2001
From: Will Newton <will.newton@gmail.com>
Date: Tue, 28 Oct 2008 10:52:36 +0000
Subject: [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit.
dev_kfree_skb should not be called with irqs disabled, use dev_kfree_skb_irq
instead. The warning caused looks like this:
======================================================
[ INFO: hard-safe -> hard-unsafe lock order detected ]
2.6.28-rc1 #273
------------------------------------------------------
swapper/0 [HC0[0]:SC1[2]:HE0:SE0] is trying to acquire:
(clock-AF_INET){-..+}, at: [<4015c17c>] _sock_def_write_space+0x28/0xd8
and this task is already holding:
(&lp->lock){++..}, at: [<4013f230>] _smc911x_hard_start_xmit+0x30/0x4b8
which would create a new lock dependency:
(&lp->lock){++..} -> (clock-AF_INET){-..+}
Signed-off-by: Will Newton <will.newton@gmail.com>
---
drivers/net/smc911x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index f59c777..5051554 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -499,7 +499,7 @@ static void smc911x_hardware_send_pkt(struct
net_device *dev)
#else
SMC_PUSH_DATA(lp, buf, len);
dev->trans_start = jiffies;
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
#endif
if (!lp->tx_throttle) {
netif_wake_queue(dev);
--
1.5.5.2
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-drivers-net-smc911x.c-Fix-lockdep-warning-on-xmit.patch --]
[-- Type: text/x-diff; name=0001-drivers-net-smc911x.c-Fix-lockdep-warning-on-xmit.patch, Size: 1404 bytes --]
From 0e3ec7f78e115533e4aca9ac067acbc33eb0a21f Mon Sep 17 00:00:00 2001
From: Will Newton <will.newton@gmail.com>
Date: Tue, 28 Oct 2008 10:52:36 +0000
Subject: [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit.
dev_kfree_skb should not be called with irqs disabled, use dev_kfree_skb_irq
instead. The warning caused looks like this:
======================================================
[ INFO: hard-safe -> hard-unsafe lock order detected ]
2.6.28-rc1 #273
------------------------------------------------------
swapper/0 [HC0[0]:SC1[2]:HE0:SE0] is trying to acquire:
(clock-AF_INET){-..+}, at: [<4015c17c>] _sock_def_write_space+0x28/0xd8
and this task is already holding:
(&lp->lock){++..}, at: [<4013f230>] _smc911x_hard_start_xmit+0x30/0x4b8
which would create a new lock dependency:
(&lp->lock){++..} -> (clock-AF_INET){-..+}
Signed-off-by: Will Newton <will.newton@gmail.com>
---
drivers/net/smc911x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index f59c777..5051554 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -499,7 +499,7 @@ static void smc911x_hardware_send_pkt(struct net_device *dev)
#else
SMC_PUSH_DATA(lp, buf, len);
dev->trans_start = jiffies;
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
#endif
if (!lp->tx_throttle) {
netif_wake_queue(dev);
--
1.5.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit.
2008-10-28 12:06 [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit Will Newton
@ 2008-11-02 13:46 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-11-02 13:46 UTC (permalink / raw
To: Will Newton; +Cc: linux-kernel, netdev
Will Newton wrote:
>>From 0e3ec7f78e115533e4aca9ac067acbc33eb0a21f Mon Sep 17 00:00:00 2001
> From: Will Newton <will.newton@gmail.com>
> Date: Tue, 28 Oct 2008 10:52:36 +0000
> Subject: [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit.
>
> dev_kfree_skb should not be called with irqs disabled, use dev_kfree_skb_irq
> instead. The warning caused looks like this:
>
> ======================================================
> [ INFO: hard-safe -> hard-unsafe lock order detected ]
> 2.6.28-rc1 #273
> ------------------------------------------------------
> swapper/0 [HC0[0]:SC1[2]:HE0:SE0] is trying to acquire:
> (clock-AF_INET){-..+}, at: [<4015c17c>] _sock_def_write_space+0x28/0xd8
>
> and this task is already holding:
> (&lp->lock){++..}, at: [<4013f230>] _smc911x_hard_start_xmit+0x30/0x4b8
> which would create a new lock dependency:
> (&lp->lock){++..} -> (clock-AF_INET){-..+}
>
> Signed-off-by: Will Newton <will.newton@gmail.com>
> ---
> drivers/net/smc911x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index f59c777..5051554 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -499,7 +499,7 @@ static void smc911x_hardware_send_pkt(struct
> net_device *dev)
> #else
> SMC_PUSH_DATA(lp, buf, len);
> dev->trans_start = jiffies;
> - dev_kfree_skb(skb);
> + dev_kfree_skb_irq(skb);
> #endif
> if (!lp->tx_throttle) {
> netif_wake_queue(dev);
applied manually, your patch was corrupted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-02 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-28 12:06 [PATCH] drivers/net/smc911x.c: Fix lockdep warning on xmit Will Newton
2008-11-02 13:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).