* [RFC PATCH 0/5] Enhancements for mv64xxx I2C driver
@ 2024-03-20 1:40 Sam Edwards
0 siblings, 0 replies; only message in thread
From: Sam Edwards @ 2024-03-20 1:40 UTC (permalink / raw
To: Gregory CLEMENT, Andi Shyti; +Cc: linux-i2c, linux-kernel
Salutations, Linux I2C team!
I am working with an Allwinner T113-s3 based board; the internal I2C bus of
which has a Realtek RTL8370MB-CG Ethernet switch coexisting with other I2C
devices. The RTL8370MB-CG deviates from "conventional" I2C read operations
in that it expects the hardware register after the addr+read byte before it
turns around the bus to send the value. For this reason, the `realtek-smi`
driver currently implements the protocol via bit-banging. However, I am
in the
process of developing a separate patch series to promote this driver to a
"full" I2C driver, leveraging I2C_M_NOSTART to support this odd read
operation.
In anticipation of that, I am preparing this series comprising five
patches to
improve the functionality and reliability of the I2C adapter enough to
support
this kind of device. I have heavily tested these changes on the
Allwinner-style
mv64xxx core, but not the Marvell-style, and have not been able to test
10-bit
addressing. I would greatly appreciate if anyone here could test this
series,
especially on non-Allwinner boards and/or boards with 10-bit devices.
I'm a bit skeptical of using I2C_M_NOSTART for this purpose. The driver does
not (and cannot) support "just any" use of I2C_M_NOSTART, so it may be
inappropriate to claim the I2C_FUNC_NOSTART capability. On the other hand, I
searched high and low and couldn't find any use of I2C_M_NOSTART that
*wouldn't* be supported by this change, so this could very well be
exactly what
clients understand I2C_FUNC_NOSTART to mean. Given that the alternative
would
be inventing a new flag ("I2C_M_READEXTRA"?) and figuring out how to supply
input bytes and output bytes in the same i2c_msg, I opted for the NOSTART
route instead.
I look forward to any feedback, bug reports, test results, questions,
concerns,
commentary, or discussion that you can offer!
Best regards,
Sam
Sam Edwards (5):
i2c: mv64xxx: Clear bus errors before transfer
i2c: mv64xxx: Clean up the private data struct
i2c: mv64xxx: Refactor FSM
i2c: mv64xxx: Allow continuing after read
i2c: mv64xxx: Implement I2C_FUNC_NOSTART
drivers/i2c/busses/i2c-mv64xxx.c | 430 ++++++++++++++++++++++---------
1 file changed, 302 insertions(+), 128 deletions(-)
--
2.43.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-20 1:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-20 1:40 [RFC PATCH 0/5] Enhancements for mv64xxx I2C driver Sam Edwards
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).