* [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test
@ 2023-05-30 8:43 Guillaume Ranquet
2023-05-30 9:24 ` AngeloGioacchino Del Regno
2023-07-11 7:36 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Guillaume Ranquet @ 2023-05-30 8:43 UTC (permalink / raw
To: Chun-Kuang Hu, Philipp Zabel, Chunfeng Yun, Vinod Koul,
Kishon Vijay Abraham I, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, Guillaume Ranquet
The pll prediv calculus searchs for the smallest prediv that gets
the ns_hdmipll_ck in the range of 5 GHz to 12 GHz.
A typo in the upper bound test was testing for 5Ghz to 1Ghz
Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
---
drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
index 8aa7251de4a9..bbfe11d6a69d 100644
--- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
+++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
@@ -253,7 +253,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
for (i = 0; i < ARRAY_SIZE(txpredivs); i++) {
ns_hdmipll_ck = 5 * tmds_clk * txposdiv * txpredivs[i];
if (ns_hdmipll_ck >= 5 * GIGA &&
- ns_hdmipll_ck <= 1 * GIGA)
+ ns_hdmipll_ck <= 12 * GIGA)
break;
}
if (i == (ARRAY_SIZE(txpredivs) - 1) &&
---
base-commit: 9f925874281f7e8855855d6210d6e29d844e4307
change-id: 20230529-hdmi_phy_fix-9dab6eb42ef7
Best regards,
--
Guillaume Ranquet <granquet@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test
2023-05-30 8:43 [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test Guillaume Ranquet
@ 2023-05-30 9:24 ` AngeloGioacchino Del Regno
2023-07-11 7:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-05-30 9:24 UTC (permalink / raw
To: Guillaume Ranquet, Chun-Kuang Hu, Philipp Zabel, Chunfeng Yun,
Vinod Koul, Kishon Vijay Abraham I, Matthias Brugger
Cc: dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel
Il 30/05/23 10:43, Guillaume Ranquet ha scritto:
> The pll prediv calculus searchs for the smallest prediv that gets
> the ns_hdmipll_ck in the range of 5 GHz to 12 GHz.
>
> A typo in the upper bound test was testing for 5Ghz to 1Ghz
>
> Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test
2023-05-30 8:43 [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test Guillaume Ranquet
2023-05-30 9:24 ` AngeloGioacchino Del Regno
@ 2023-07-11 7:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-07-11 7:36 UTC (permalink / raw
To: Chun-Kuang Hu, Philipp Zabel, Chunfeng Yun,
Kishon Vijay Abraham I, Matthias Brugger,
AngeloGioacchino Del Regno, Guillaume Ranquet
Cc: dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel
On Tue, 30 May 2023 10:43:07 +0200, Guillaume Ranquet wrote:
> The pll prediv calculus searchs for the smallest prediv that gets
> the ns_hdmipll_ck in the range of 5 GHz to 12 GHz.
>
> A typo in the upper bound test was testing for 5Ghz to 1Ghz
>
>
Applied, thanks!
[1/1] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test
commit: 059c78ebf1e94a825e27cc3ef8a9d77cef06827e
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-11 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30 8:43 [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test Guillaume Ranquet
2023-05-30 9:24 ` AngeloGioacchino Del Regno
2023-07-11 7:36 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).