LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sdx75: add unit address to soc node
@ 2024-03-25 10:29 Krzysztof Kozlowski
  2024-03-25 19:23 ` Konrad Dybcio
  2024-04-21 22:29 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-25 10:29 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Soc node has ranges, thus it must have an unit address. This fixes W=1
dtc warning:

  sdx75.dtsi:399.11-736.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index 7dbdf8ca6de6..f58da999a72d 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -411,7 +411,7 @@ smem: qcom,smem {
 		hwlocks = <&tcsr_mutex 3>;
 	};
 
-	soc: soc {
+	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <2>;
 		#size-cells = <2>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sdx75: add unit address to soc node
  2024-03-25 10:29 [PATCH] arm64: dts: qcom: sdx75: add unit address to soc node Krzysztof Kozlowski
@ 2024-03-25 19:23 ` Konrad Dybcio
  2024-04-21 22:29 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-03-25 19:23 UTC (permalink / raw
  To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On 25.03.2024 11:29 AM, Krzysztof Kozlowski wrote:
> Soc node has ranges, thus it must have an unit address. This fixes W=1
> dtc warning:
> 
>   sdx75.dtsi:399.11-736.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sdx75: add unit address to soc node
  2024-03-25 10:29 [PATCH] arm64: dts: qcom: sdx75: add unit address to soc node Krzysztof Kozlowski
  2024-03-25 19:23 ` Konrad Dybcio
@ 2024-04-21 22:29 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-04-21 22:29 UTC (permalink / raw
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski


On Mon, 25 Mar 2024 11:29:24 +0100, Krzysztof Kozlowski wrote:
> Soc node has ranges, thus it must have an unit address. This fixes W=1
> dtc warning:
> 
>   sdx75.dtsi:399.11-736.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sdx75: add unit address to soc node
      commit: 6754fecd3bdf82cbd6eedefeb0cdb7e86aac2208

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-21 22:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 10:29 [PATCH] arm64: dts: qcom: sdx75: add unit address to soc node Krzysztof Kozlowski
2024-03-25 19:23 ` Konrad Dybcio
2024-04-21 22:29 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).