LKML Archive mirror
 help / color / mirror / Atom feed
* Question about futex_atomic_cmpxchg_inatomic
@ 2010-05-14 23:46 H Hartley Sweeten
  2010-05-21 13:14 ` Michael Schnell
  0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2010-05-14 23:46 UTC (permalink / raw
  To: Linux Kernel Mailing List

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 721 bytes --]

Hello all,

futex_atomic_cmpxchg_inatomic is currently defined in all arch's as
something along the line of (this one is from arch/arm):

static inline int
futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval)
{
	...
}

The only user of this function is in kernel/futex.c and all of the calls
pass u32 type parameters and expect an u32 type return.

Should the all arch implementations be changed to use the u32 type, i.e?

static inline u32
futex_atomic_cmpxchg_inatomic(u32 __user *uaddr, u32 oldval, u32 newval)
{
	...
}

Regards,
Hartley
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Question about futex_atomic_cmpxchg_inatomic
  2010-05-14 23:46 Question about futex_atomic_cmpxchg_inatomic H Hartley Sweeten
@ 2010-05-21 13:14 ` Michael Schnell
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Schnell @ 2010-05-21 13:14 UTC (permalink / raw
  To: linux-kernel

On 05/15/2010 01:46 AM, H Hartley Sweeten wrote:
> Should the all arch implementations be changed to use the u32 type, 
>   

I suppose the Futex variable should be a 64 bit entity with a 64 bit
architecture.

-Michael

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-21 13:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-14 23:46 Question about futex_atomic_cmpxchg_inatomic H Hartley Sweeten
2010-05-21 13:14 ` Michael Schnell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).