* [PATCH] extcon: fsa9480: Drop no-op remove function
@ 2022-05-26 13:07 ` Uwe Kleine-König
2022-05-27 9:09 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2022-05-26 13:07 UTC (permalink / raw
To: MyungJoo Ham, Chanwoo Choi; +Cc: linux-kernel, kernel
A remove callback that just returns 0 is equivalent to no callback at all
as can be seen in i2c_device_remove(). So simplify accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/extcon/extcon-fsa9480.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
index 08bdedbcdb0d..7cff66c29907 100644
--- a/drivers/extcon/extcon-fsa9480.c
+++ b/drivers/extcon/extcon-fsa9480.c
@@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
return 0;
}
-static int fsa9480_remove(struct i2c_client *client)
-{
- return 0;
-}
-
#ifdef CONFIG_PM_SLEEP
static int fsa9480_suspend(struct device *dev)
{
@@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
.of_match_table = fsa9480_of_match,
},
.probe = fsa9480_probe,
- .remove = fsa9480_remove,
.id_table = fsa9480_id,
};
base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: fsa9480: Drop no-op remove function
2022-05-26 13:07 ` [PATCH] extcon: fsa9480: Drop no-op remove function Uwe Kleine-König
@ 2022-05-27 9:09 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2022-05-27 9:09 UTC (permalink / raw
To: Uwe Kleine-König, MyungJoo Ham; +Cc: linux-kernel, kernel
On 5/26/22 10:07 PM, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/extcon/extcon-fsa9480.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
> index 08bdedbcdb0d..7cff66c29907 100644
> --- a/drivers/extcon/extcon-fsa9480.c
> +++ b/drivers/extcon/extcon-fsa9480.c
> @@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
> return 0;
> }
>
> -static int fsa9480_remove(struct i2c_client *client)
> -{
> - return 0;
> -}
> -
> #ifdef CONFIG_PM_SLEEP
> static int fsa9480_suspend(struct device *dev)
> {
> @@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
> .of_match_table = fsa9480_of_match,
> },
> .probe = fsa9480_probe,
> - .remove = fsa9480_remove,
> .id_table = fsa9480_id,
> };
>
>
> base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
>
Applied it for v5.20-rc1. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-27 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220526130812epcas1p272b572297501a35f98fa1c6656381cfa@epcas1p2.samsung.com>
2022-05-26 13:07 ` [PATCH] extcon: fsa9480: Drop no-op remove function Uwe Kleine-König
2022-05-27 9:09 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).