From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: gregkh@linuxfoundation.org, Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
martin@kaiser.cx, straube.linux@gmail.com,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH 4/6] staging: r8188eu: remove empty function rtl8188eu_free_xmit_priv
Date: Thu, 19 Aug 2021 04:00:25 +0200 [thread overview]
Message-ID: <3783001.X7UpCbk0Mo@localhost.localdomain> (raw)
In-Reply-To: <20210818234253.208271-5-phil@philpotter.co.uk>
On Thursday, August 19, 2021 1:42:51 AM CEST Phillip Potter wrote:
> Remove empty function rtl8188eu_free_xmit_priv from hal/rtl8188eu_xmit.c
> and its declaration from include/rtl8188e_xmit.h, as well as the one
> place where it is stored in the free_xmit_priv function pointer of the
> HalFunc struct inside padapter. This is safe, as the wrapper function
> checks for NULL before calling this function via the function pointer.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 4 ----
> drivers/staging/r8188eu/hal/usb_halinit.c | 1 -
> drivers/staging/r8188eu/include/rtl8188e_xmit.h | 1 -
> 3 files changed, 6 deletions(-)
>
It looks good, so...
Acked-by: Fabio M. De Francesco
Thanks,
Fabio
next prev parent reply other threads:[~2021-08-19 2:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 23:42 [PATCH 0/6] staging: r8188eu: HAL related cleanups Phillip Potter
2021-08-18 23:42 ` [PATCH 1/6] staging: r8188eu: remove _dbg_dump_tx_info function Phillip Potter
2021-08-19 1:34 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 2/6] staging: r8188eu: remove unused function dump_txrpt_ccx_88e Phillip Potter
2021-08-19 1:38 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 3/6] staging: r8188eu: remove txrpt_ccx_sw_88e and txrpt_ccx_qtime_88e macros Phillip Potter
2021-08-19 1:56 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 4/6] staging: r8188eu: remove empty function rtl8188eu_free_xmit_priv Phillip Potter
2021-08-19 2:00 ` Fabio M. De Francesco [this message]
2021-08-18 23:42 ` [PATCH 5/6] staging: r8188eu: remove function rtw_hal_free_xmit_priv Phillip Potter
2021-08-19 2:08 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 6/6] staging: r8188eu: remove free_xmit_priv field from struct hal_ops Phillip Potter
2021-08-19 3:14 ` Fabio M. De Francesco
2021-08-20 21:56 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3783001.X7UpCbk0Mo@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).