From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E0AC47082 for ; Mon, 31 May 2021 17:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A73961263 for ; Mon, 31 May 2021 17:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbhEaRwY (ORCPT ); Mon, 31 May 2021 13:52:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230351AbhEaRvt (ORCPT ); Mon, 31 May 2021 13:51:49 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B662CC06134D for ; Mon, 31 May 2021 10:48:36 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id l18-20020a1c79120000b0290181c444b2d0so399911wme.5 for ; Mon, 31 May 2021 10:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9w+YOLhPg3i3Tr1EsuxBv3pkuCJqmFu4aSsxCc9Nllg=; b=NX6RyzqHzZhU/yIIz7B9KT5+g+rgrWNPPRSQdULQOAxLuBVwLJXpVT7bzRRTZKsBFQ twzZ87IbRqaI1WHftl64DjZvuTj4XS/GlpH1f4xbKoYozxD0y49k11DnVy+/lk2dHsYw T55Drhmxdsam7SDId2NOy/FaGXShBw1pk1mqCTsmmXOstxGULD61fdcigrI7hUVbJSFr 4V042gFckuIhw6/WXdE7GbgV+bkojxo0MKlkifNPwINeWBzo72aAgfSFQnyyg6tUNCOY Lk6mYOfufAxBYze4FpLzrDWx8MgYDJJq7GV1iq6QehaZ4k5jhe22lG9EybUfCTcT3ljJ KXOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9w+YOLhPg3i3Tr1EsuxBv3pkuCJqmFu4aSsxCc9Nllg=; b=Nzt8fC67j7REmbZtmtKIxCVFhMo2J14xn5htfbiH6ZU/jv0oxqnnWVuqDY3S0r5jMm XLXXKaCTr0DOF8ylsrl3jfLl6oSrMDeEHj8edjGYPp5ZrA3rh2tXnrnmXwGNChTzdGXE HD6jPc1nzaqw510iw7iGjrHIrdc8aVXnL6DiXVunH3qDnudslZ3C5+p46bIAA8CSUyFV 6hyVMHEPRx0OSSb1LWQgvCJgtWX6cLTLIAt3A2ohnZj9aYEeoii/jQ0IWiyCHN6kQBT4 EDNEjSY6l7H2roYNz7Lau1xzQZXKSwJet+9SRrGrAnhcQvvK4k6ptaeT9SQsCpoM674P ZMFw== X-Gm-Message-State: AOAM533HZ2PBIlhYtUNRFfTzAB3DyXyKQXyMvmYWaS1f0+SzN0TxRdy+ Pkq3zLwod/kOfk7Scsh/UMUVO+WDXa54RQ== X-Google-Smtp-Source: ABdhPJyTOSC1nGUD6dnIYOxZpbs2gIZbcBHca9HSf0byj5/DSMTfCcobUatRnm8e8k1vz2XWrX2Z+w== X-Received: by 2002:a7b:c849:: with SMTP id c9mr252246wml.84.1622483315353; Mon, 31 May 2021 10:48:35 -0700 (PDT) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net. [86.58.17.133]) by smtp.gmail.com with ESMTPSA id v18sm463950wrb.10.2021.05.31.10.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 10:48:34 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Roman Stratiienko Cc: mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, megous@megous.com, linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Roman Stratiienko Subject: Re: Re: [PATCH v4 1/2] drm/sun4i: Add mode_set callback to the engine Date: Mon, 31 May 2021 19:48:33 +0200 Message-ID: <3374256.1yKYrUSprD@kista> In-Reply-To: <2404786.ubhusWIBXB@kista> References: <20210528203036.17999-1-r.stratiienko@gmail.com> <20210528203036.17999-2-r.stratiienko@gmail.com> <2404786.ubhusWIBXB@kista> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne ponedeljek, 31. maj 2021 ob 19:24:40 CEST je Jernej =C5=A0krabec napisa= l(a): > Hi! >=20 > Dne petek, 28. maj 2021 ob 22:30:35 CEST je Roman Stratiienko napisal(a): > > Create callback to allow updating engine's registers on mode change. > >=20 > > Signed-off-by: Roman Stratiienko > > Reviewed-by: Jernej Skrabec BTW, update my R-B tag with gmail address and fix issues pointed out by Pl= aes=20 and me in order to use it. > > --- > > drivers/gpu/drm/sun4i/sun4i_crtc.c | 3 +++ > > drivers/gpu/drm/sun4i/sunxi_engine.h | 12 ++++++++++++ > > 2 files changed, 15 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/ > sun4i_crtc.c > > index 45d9eb552d86..8f01a6b2bbef 100644 > > --- a/drivers/gpu/drm/sun4i/sun4i_crtc.c > > +++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c > > @@ -146,6 +146,9 @@ static void sun4i_crtc_mode_set_nofb(struct drm_crt= c=20 > *crtc) > > struct sun4i_crtc *scrtc =3D drm_crtc_to_sun4i_crtc(crtc); > > =20 > > sun4i_tcon_mode_set(scrtc->tcon, encoder, mode); > > + > > + if (scrtc->engine->ops->mode_set) > > + scrtc->engine->ops->mode_set(scrtc->engine, mode); > > } > > =20 > > static const struct drm_crtc_helper_funcs sun4i_crtc_helper_funcs =3D { > > diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun= 4i/ > sunxi_engine.h > > index 548710a936d5..7faa844646ff 100644 > > --- a/drivers/gpu/drm/sun4i/sunxi_engine.h > > +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h > > @@ -9,6 +9,7 @@ > > struct drm_plane; > > struct drm_device; > > struct drm_crtc_state; > > +struct drm_display_mode; > > =20 > > struct sunxi_engine; > > =20 > > @@ -108,6 +109,17 @@ struct sunxi_engine_ops { > > * This function is optional. > > */ > > void (*vblank_quirk)(struct sunxi_engine *engine); > > + > > + /** > > + * @mode_set: > > + * > > + * This callback is used to update engine registers that > > + * responsible for display frame size and other mode attributes. > > + * > > + * This function is optional. > > + */ > > + void (*mode_set)(struct sunxi_engine *engine, > > + struct drm_display_mode *mode); >=20 > Mark mode as const. >=20 > Best regards, > Jernej >=20 > > }; > > =20 > > /** > >=20 >=20 >=20 >=20