From: Swapnil Sapkal <swapnil.sapkal@amd.com>
To: <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
<peterz@infradead.org>
Cc: <torvalds@linux-foundation.org>, <juri.lelli@redhat.com>,
<dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
<mgorman@suse.de>, <bristot@redhat.com>, <vschneid@redhat.com>,
<vincent.guittot@linaro.org>, <gautham.shenoy@amd.com>,
<sshegde@linux.ibm.com>, <kprateek.nayak@amd.com>,
Swapnil Sapkal <swapnil.sapkal@amd.com>
Subject: [RESEND][PATCH v3 0/1] Fix lb_imbalance reporting in /proc/schedstat
Date: Tue, 14 May 2024 04:44:44 +0000 [thread overview]
Message-ID: <20240514044445.1409976-1-swapnil.sapkal@amd.com> (raw)
This patch adds new fields to /proc/schdstat. First version of
the patch is sent here [1]. This patch goes on top of the
commit d72cf62438d6 ("sched/balancing: Fix a couple of outdated function names in comments")
from tip/sched/core. This change is intended to be a part of v16 of
/proc/schedstat.
v2 --> v3 change:
- Incorporated review comment by Shrikanth Hegde
- Added reviewed by.
v1 --> v2 change:
- Added links to previous schedstat documentation
- Incorporated review comments by Shrikanth Hegde
Motivation:
In /proc/schedstat, lb_imbalance reports the sum of imbalances
discovered in sched domains with each call to sched_balance_rq(), which is
not very useful because lb_imbalance does not mention whether the imbalance
is due to load, utilization, nr_tasks or misfit_tasks. Remove this field
from /proc/schedstat.
Currently there is no field in /proc/schedstat to report different types
of imbalances. Introduce new fields in /proc/schedstat to report the
total imbalances in load, utilization, nr_tasks or misfit_tasks.
[1] https://lore.kernel.org/lkml/66f1e42c-9035-4f9b-8c77-976ab50638bd@amd.com/
Swapnil Sapkal (1):
sched: Report the different kinds of imbalances in /proc/schedstat
Documentation/scheduler/sched-stats.rst | 121 ++++++++++++++----------
include/linux/sched/topology.h | 5 +-
kernel/sched/fair.c | 21 +++-
kernel/sched/stats.c | 7 +-
4 files changed, 99 insertions(+), 55 deletions(-)
--
2.34.1
next reply other threads:[~2024-05-14 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 4:44 Swapnil Sapkal [this message]
2024-05-14 4:44 ` [RESEND][PATCH v3 1/1] sched: Report the different kinds of imbalances in /proc/schedstat Swapnil Sapkal
2024-05-14 11:14 ` Chen Yu
2024-05-14 14:23 ` Shrikanth Hegde
2024-05-14 15:14 ` Chen Yu
2024-05-15 5:12 ` Swapnil Sapkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514044445.1409976-1-swapnil.sapkal@amd.com \
--to=swapnil.sapkal@amd.com \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).