* [PATCH] regmap-i2c: Subtract reg size from max_write
@ 2024-04-30 20:15 Jim Wylder
2024-05-23 16:58 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jim Wylder @ 2024-04-30 20:15 UTC (permalink / raw
To: Mark Brown, Greg Kroah-Hartman, Rafael J. Wysocki
Cc: Jim Wylder, kernel-team, linux-kernel
Currently, when an adapter defines a max_write_len quirk,
the data will be chunked into data sizes equal to the
max_write_len quirk value. But the payload will be increased by
the size of the register address before transmission. The
resulting value always ends up larger than the limit set
by the quirk.
Avoid this error by setting regmap's max_write to the quirk's
max_write_len minus the number of bytes for the register. This
allows the chunking to work correctly for this limited case
without impacting other use-cases.
Signed-off-by: Jim Wylder <jwylder@google.com>
---
drivers/base/regmap/regmap-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/regmap/regmap-i2c.c b/drivers/base/regmap/regmap-i2c.c
index 3ec611dc0c09..3b1e78e845bf 100644
--- a/drivers/base/regmap/regmap-i2c.c
+++ b/drivers/base/regmap/regmap-i2c.c
@@ -350,7 +350,7 @@ static const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c,
if (quirks->max_write_len &&
(bus->max_raw_write == 0 || bus->max_raw_write > quirks->max_write_len))
- max_write = quirks->max_write_len;
+ max_write = quirks->max_write_len - config->reg_bits / BITS_PER_BYTE;
if (max_read || max_write) {
ret_bus = kmemdup(bus, sizeof(*bus), GFP_KERNEL);
--
2.45.0.rc0.197.gbae5840b3b-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regmap-i2c: Subtract reg size from max_write
2024-04-30 20:15 [PATCH] regmap-i2c: Subtract reg size from max_write Jim Wylder
@ 2024-05-23 16:58 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2024-05-23 16:58 UTC (permalink / raw
To: Jim Wylder
Cc: Greg Kroah-Hartman, Rafael J. Wysocki, kernel-team, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
On Tue, Apr 30, 2024 at 03:15:33PM -0500, Jim Wylder wrote:
> - max_write = quirks->max_write_len;
> + max_write = quirks->max_write_len - config->reg_bits / BITS_PER_BYTE;
This also needs to take account of any pad bits.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-23 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 20:15 [PATCH] regmap-i2c: Subtract reg size from max_write Jim Wylder
2024-05-23 16:58 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).