* [PATCH 2/2] arm64: dts: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 13:01 [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A Chukun Pan
@ 2024-04-18 13:01 ` Chukun Pan
2024-04-18 15:21 ` Dragan Simic
2024-04-18 15:21 ` [PATCH 1/2] dt-bindings: arm: " Dragan Simic
2024-04-18 15:36 ` Conor Dooley
2 siblings, 1 reply; 10+ messages in thread
From: Chukun Pan @ 2024-04-18 13:01 UTC (permalink / raw
To: Heiko Stuebner
Cc: Krzysztof Kozlowski, Conor Dooley, Rob Herring, linux-arm-kernel,
linux-rockchip, linux-kernel, devicetree, Chukun Pan,
FUKAUMI Naoki
According to https://radxa.com/products/rock3/3a,
the name of this board should be "Radxa ROCK 3A".
Also update compatible to match the model name.
Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index c62230308457..e859c075bd46 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -8,8 +8,8 @@
#include "rk3568.dtsi"
/ {
- model = "Radxa ROCK3 Model A";
- compatible = "radxa,rock3a", "rockchip,rk3568";
+ model = "Radxa ROCK 3A";
+ compatible = "radxa,rock-3a", "rockchip,rk3568";
aliases {
ethernet0 = &gmac1;
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] arm64: dts: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 13:01 ` [PATCH 2/2] arm64: dts: " Chukun Pan
@ 2024-04-18 15:21 ` Dragan Simic
0 siblings, 0 replies; 10+ messages in thread
From: Dragan Simic @ 2024-04-18 15:21 UTC (permalink / raw
To: Chukun Pan
Cc: Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley, Rob Herring,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
FUKAUMI Naoki
On 2024-04-18 15:01, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
>
> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Looking good to me.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index c62230308457..e859c075bd46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -8,8 +8,8 @@
> #include "rk3568.dtsi"
>
> / {
> - model = "Radxa ROCK3 Model A";
> - compatible = "radxa,rock3a", "rockchip,rk3568";
> + model = "Radxa ROCK 3A";
> + compatible = "radxa,rock-3a", "rockchip,rk3568";
>
> aliases {
> ethernet0 = &gmac1;
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 13:01 [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A Chukun Pan
2024-04-18 13:01 ` [PATCH 2/2] arm64: dts: " Chukun Pan
@ 2024-04-18 15:21 ` Dragan Simic
2024-04-18 15:37 ` Conor Dooley
2024-04-18 16:34 ` Dragan Simic
2024-04-18 15:36 ` Conor Dooley
2 siblings, 2 replies; 10+ messages in thread
From: Dragan Simic @ 2024-04-18 15:21 UTC (permalink / raw
To: Chukun Pan
Cc: Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley, Rob Herring,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
FUKAUMI Naoki
On 2024-04-18 15:01, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
>
> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Looking good to me. I'll send the remaining naming cleanup patches
a bit later.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 99bd5e2c76a0..88e9e0011953 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -772,9 +772,9 @@ properties:
> - const: radxa,rock2-square
> - const: rockchip,rk3288
>
> - - description: Radxa ROCK3 Model A
> + - description: Radxa ROCK 3A
> items:
> - - const: radxa,rock3a
> + - const: radxa,rock-3a
> - const: rockchip,rk3568
>
> - description: Radxa ROCK 5 Model A
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 15:21 ` [PATCH 1/2] dt-bindings: arm: " Dragan Simic
@ 2024-04-18 15:37 ` Conor Dooley
2024-04-18 15:46 ` Dragan Simic
2024-04-18 16:34 ` Dragan Simic
1 sibling, 1 reply; 10+ messages in thread
From: Conor Dooley @ 2024-04-18 15:37 UTC (permalink / raw
To: Dragan Simic
Cc: Chukun Pan, Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley,
Rob Herring, linux-arm-kernel, linux-rockchip, linux-kernel,
devicetree, FUKAUMI Naoki
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
> On 2024-04-18 15:01, Chukun Pan wrote:
> > According to https://radxa.com/products/rock3/3a,
> > the name of this board should be "Radxa ROCK 3A".
> > Also update compatible to match the model name.
> >
> > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>
> Looking good to me. I'll send the remaining naming cleanup patches
> a bit later.
What remaining patches?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 15:37 ` Conor Dooley
@ 2024-04-18 15:46 ` Dragan Simic
2024-04-18 15:57 ` Conor Dooley
0 siblings, 1 reply; 10+ messages in thread
From: Dragan Simic @ 2024-04-18 15:46 UTC (permalink / raw
To: Conor Dooley
Cc: Chukun Pan, Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley,
Rob Herring, linux-arm-kernel, linux-rockchip, linux-kernel,
devicetree, FUKAUMI Naoki
Hello Conor,
On 2024-04-18 17:37, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> On 2024-04-18 15:01, Chukun Pan wrote:
>> > According to https://radxa.com/products/rock3/3a,
>> > the name of this board should be "Radxa ROCK 3A".
>> > Also update compatible to match the model name.
>> >
>> > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>>
>> Looking good to me. I'll send the remaining naming cleanup patches
>> a bit later.
>
> What remaining patches?
The same naming cleanups need to be performed for the Radxa
ROCK 5 boards. [1] I had some more cleanups for the ROCK 4
boards in mind, but I'll drop them after your NAK. [2]
Though, I'm not really sure why the NAK? Those names aren't
used anywhere, neither in the Linux kernel, nor in U-Boot.
[1]
https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/
[2]
https://lore.kernel.org/linux-rockchip/20240418-liberty-pry-d270065a544f@spud/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 15:46 ` Dragan Simic
@ 2024-04-18 15:57 ` Conor Dooley
2024-04-18 15:58 ` Dragan Simic
0 siblings, 1 reply; 10+ messages in thread
From: Conor Dooley @ 2024-04-18 15:57 UTC (permalink / raw
To: Dragan Simic
Cc: Chukun Pan, Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley,
Rob Herring, linux-arm-kernel, linux-rockchip, linux-kernel,
devicetree, FUKAUMI Naoki
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
> Hello Conor,
>
> On 2024-04-18 17:37, Conor Dooley wrote:
> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
> > > On 2024-04-18 15:01, Chukun Pan wrote:
> > > > According to https://radxa.com/products/rock3/3a,
> > > > the name of this board should be "Radxa ROCK 3A".
> > > > Also update compatible to match the model name.
> > > >
> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > >
> > > Looking good to me. I'll send the remaining naming cleanup patches
> > > a bit later.
> >
> > What remaining patches?
>
> The same naming cleanups need to be performed for the Radxa
> ROCK 5 boards. [1] I had some more cleanups for the ROCK 4
> boards in mind, but I'll drop them after your NAK. [2]
>
> Though, I'm not really sure why the NAK? Those names aren't
> used anywhere, neither in the Linux kernel, nor in U-Boot.
There may well be other users outside of those two projects that are
actually looking at it - I don't think that adding a hyphen is worth
disrupting anyone for, it seems perfectly clear without it what board
this is.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 15:57 ` Conor Dooley
@ 2024-04-18 15:58 ` Dragan Simic
0 siblings, 0 replies; 10+ messages in thread
From: Dragan Simic @ 2024-04-18 15:58 UTC (permalink / raw
To: Conor Dooley
Cc: Chukun Pan, Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley,
Rob Herring, linux-arm-kernel, linux-rockchip, linux-kernel,
devicetree, FUKAUMI Naoki
On 2024-04-18 17:57, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
>> On 2024-04-18 17:37, Conor Dooley wrote:
>> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> > > On 2024-04-18 15:01, Chukun Pan wrote:
>> > > > According to https://radxa.com/products/rock3/3a,
>> > > > the name of this board should be "Radxa ROCK 3A".
>> > > > Also update compatible to match the model name.
>> > > >
>> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> > >
>> > > Looking good to me. I'll send the remaining naming cleanup patches
>> > > a bit later.
>> >
>> > What remaining patches?
>>
>> The same naming cleanups need to be performed for the Radxa
>> ROCK 5 boards. [1] I had some more cleanups for the ROCK 4
>> boards in mind, but I'll drop them after your NAK. [2]
>>
>> Though, I'm not really sure why the NAK? Those names aren't
>> used anywhere, neither in the Linux kernel, nor in U-Boot.
>
> There may well be other users outside of those two projects that are
> actually looking at it - I don't think that adding a hyphen is worth
> disrupting anyone for, it seems perfectly clear without it what board
> this is.
I see, it's perhaps better to stay on the safe side.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 15:21 ` [PATCH 1/2] dt-bindings: arm: " Dragan Simic
2024-04-18 15:37 ` Conor Dooley
@ 2024-04-18 16:34 ` Dragan Simic
1 sibling, 0 replies; 10+ messages in thread
From: Dragan Simic @ 2024-04-18 16:34 UTC (permalink / raw
To: Chukun Pan
Cc: Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley, Rob Herring,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
FUKAUMI Naoki
Hello Chukun,
On 2024-04-18 17:21, Dragan Simic wrote:
> On 2024-04-18 15:01, Chukun Pan wrote:
>> According to https://radxa.com/products/rock3/3a,
>> the name of this board should be "Radxa ROCK 3A".
>> Also update compatible to match the model name.
>>
>> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>
> Looking good to me. I'll send the remaining naming cleanup patches
> a bit later.
Please note that I didn't touch the ROCK 3 board(s)
in my patches. [1][2]
[1]
https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
[2]
https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
>> ---
>> Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 99bd5e2c76a0..88e9e0011953 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -772,9 +772,9 @@ properties:
>> - const: radxa,rock2-square
>> - const: rockchip,rk3288
>>
>> - - description: Radxa ROCK3 Model A
>> + - description: Radxa ROCK 3A
>> items:
>> - - const: radxa,rock3a
>> + - const: radxa,rock-3a
>> - const: rockchip,rk3568
>>
>> - description: Radxa ROCK 5 Model A
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
2024-04-18 13:01 [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A Chukun Pan
2024-04-18 13:01 ` [PATCH 2/2] arm64: dts: " Chukun Pan
2024-04-18 15:21 ` [PATCH 1/2] dt-bindings: arm: " Dragan Simic
@ 2024-04-18 15:36 ` Conor Dooley
2 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2024-04-18 15:36 UTC (permalink / raw
To: Chukun Pan
Cc: Heiko Stuebner, Krzysztof Kozlowski, Conor Dooley, Rob Herring,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
FUKAUMI Naoki
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On Thu, Apr 18, 2024 at 09:01:19PM +0800, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
>
> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 99bd5e2c76a0..88e9e0011953 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -772,9 +772,9 @@ properties:
> - const: radxa,rock2-square
> - const: rockchip,rk3288
>
> - - description: Radxa ROCK3 Model A
> + - description: Radxa ROCK 3A
This is fine, but...
> items:
> - - const: radxa,rock3a
> + - const: radxa,rock-3a
...this was added 2 years ago, I think it's too late to change it, NAK.
Cheers,
Conor.
> - const: rockchip,rk3568
>
> - description: Radxa ROCK 5 Model A
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread