LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform
@ 2024-03-11 12:02 Komal Bajaj
  0 siblings, 0 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-11 12:02 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng
  Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-usb,
	Komal Bajaj

This series adds support of USB3 PHY support for Qualcomm's QDU/QRU1000 Platform.

Komal Bajaj (4):
  dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
  dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
  dt-bindings: usb: dwc3: Add QDU1000 compatible
  phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000

 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  2 +
 .../bindings/phy/qcom,usb-snps-femto-v2.yaml  |  1 +
 .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 ++
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 52 +++++++++++++++++++
 4 files changed, 58 insertions(+)

--
2.42.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform
@ 2024-03-19  9:07 Komal Bajaj
  2024-03-19  9:07 ` [PATCH 1/4] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000 Komal Bajaj
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-19  9:07 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng
  Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-usb,
	Komal Bajaj

This series adds support of USB3 PHY support for Qualcomm's QDU/QRU1000 Platform.

---------
Changes in v2:
* Dropped extra lines
* Sorted the tables alphabetically
* Link to v1: https://lore.kernel.org/linux-arm-msm/20240311120215.16845-1-quic_kbajaj@quicinc.com/

Komal Bajaj (4):
  dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
  dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
  dt-bindings: usb: dwc3: Add QDU1000 compatible
  phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000

 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  2 +
 .../bindings/phy/qcom,usb-snps-femto-v2.yaml  |  1 +
 .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 ++
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 49 +++++++++++++++++++
 4 files changed, 55 insertions(+)

--
2.42.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 1/4] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
  2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
@ 2024-03-19  9:07 ` Komal Bajaj
  2024-03-19  9:07 ` [PATCH 2/4] dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY Komal Bajaj
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-19  9:07 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng
  Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-usb,
	Komal Bajaj, Rob Herring

Document the compatible string for USB phy found in Qualcomm
QDU/QRU1000 SoC.

Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml          | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
index 0f200e3f97a9..48afcf6ed9df 100644
--- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
@@ -25,6 +25,7 @@ properties:
           - const: qcom,usb-snps-hs-5nm-phy
       - items:
           - enum:
+              - qcom,qdu1000-usb-hs-phy
               - qcom,sc7280-usb-hs-phy
               - qcom,sdx55-usb-hs-phy
               - qcom,sdx65-usb-hs-phy
--
2.42.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/4] dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
  2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
  2024-03-19  9:07 ` [PATCH 1/4] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000 Komal Bajaj
@ 2024-03-19  9:07 ` Komal Bajaj
  2024-03-19  9:07 ` [PATCH 3/4] dt-bindings: usb: dwc3: Add QDU1000 compatible Komal Bajaj
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-19  9:07 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng
  Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-usb,
	Komal Bajaj, Rob Herring

Add dt-bindings for USB3 PHY found on Qualcomm QDU/QRU1000 SoC.

Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index 15d82c67f157..acaa5716fabe 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -22,6 +22,7 @@ properties:
       - qcom,msm8996-qmp-usb3-phy
       - qcom,msm8998-qmp-usb3-phy
       - qcom,qcm2290-qmp-usb3-phy
+      - qcom,qdu1000-qmp-usb3-uni-phy
       - qcom,sa8775p-qmp-usb3-uni-phy
       - qcom,sc8280xp-qmp-usb3-uni-phy
       - qcom,sdm845-qmp-usb3-uni-phy
@@ -131,6 +132,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,qdu1000-qmp-usb3-uni-phy
               - qcom,sa8775p-qmp-usb3-uni-phy
               - qcom,sc8280xp-qmp-usb3-uni-phy
               - qcom,sm8150-qmp-usb3-uni-phy
--
2.42.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/4] dt-bindings: usb: dwc3: Add QDU1000 compatible
  2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
  2024-03-19  9:07 ` [PATCH 1/4] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000 Komal Bajaj
  2024-03-19  9:07 ` [PATCH 2/4] dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY Komal Bajaj
@ 2024-03-19  9:07 ` Komal Bajaj
  2024-03-19  9:07 ` [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000 Komal Bajaj
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-19  9:07 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng
  Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-usb,
	Komal Bajaj, Rob Herring

Document the QDU1000 dwc3 compatible.

Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 63d150b216c5..2437777c166d 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,msm8998-dwc3
           - qcom,qcm2290-dwc3
           - qcom,qcs404-dwc3
+          - qcom,qdu1000-dwc3
           - qcom,sa8775p-dwc3
           - qcom,sc7180-dwc3
           - qcom,sc7280-dwc3
@@ -245,6 +246,7 @@ allOf:
           contains:
             enum:
               - qcom,ipq8074-dwc3
+              - qcom,qdu1000-dwc3
     then:
       properties:
         clocks:
@@ -440,6 +442,7 @@ allOf:
               - qcom,ipq4019-dwc3
               - qcom,ipq8064-dwc3
               - qcom,msm8994-dwc3
+              - qcom,qdu1000-dwc3
               - qcom,sa8775p-dwc3
               - qcom,sc7180-dwc3
               - qcom,sc7280-dwc3
--
2.42.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000
  2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
                   ` (2 preceding siblings ...)
  2024-03-19  9:07 ` [PATCH 3/4] dt-bindings: usb: dwc3: Add QDU1000 compatible Komal Bajaj
@ 2024-03-19  9:07 ` Komal Bajaj
  2024-03-19  9:36   ` Dmitry Baryshkov
  2024-03-19  9:35 ` [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Dmitry Baryshkov
  2024-03-26  8:30 ` Greg Kroah-Hartman
  5 siblings, 1 reply; 11+ messages in thread
From: Komal Bajaj @ 2024-03-19  9:07 UTC (permalink / raw
  To: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng
  Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, linux-usb,
	Komal Bajaj, Amrit Anand

Add QDU1000/QRU1000 specific register layout and table configs.

Co-developed-by: Amrit Anand <quic_amrianan@quicinc.com>
Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com>
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 49 +++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index 5c003988c35d..95428c053954 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -1182,6 +1182,29 @@ static const struct qmp_phy_init_tbl qcm2290_usb3_pcs_tbl[] = {
 	QMP_PHY_INIT_CFG(QPHY_V3_PCS_RX_SIGDET_LVL, 0x88),
 };

+static const struct qmp_phy_init_tbl qdu1000_usb3_uniphy_pcs_tbl[] = {
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG1, 0xc4),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG2, 0x89),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG3, 0x20),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG6, 0x13),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_RCVR_DTCT_DLY_P1U2_L, 0xe7),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_RCVR_DTCT_DLY_P1U2_H, 0x03),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_RX_SIGDET_LVL, 0xaa),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_PCS_TX_RX_CONFIG, 0x0c),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_CDR_RESET_TIME, 0x0a),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_ALIGN_DETECT_CONFIG1, 0x88),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_ALIGN_DETECT_CONFIG2, 0x13),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_EQ_CONFIG1, 0x4b),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_EQ_CONFIG5, 0x10),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_REFGEN_REQ_CONFIG1, 0x21),
+};
+
+static const struct qmp_phy_init_tbl qdu1000_usb3_uniphy_pcs_usb_tbl[] = {
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_USB3_RXEQTRAINING_DFE_TIME_S2, 0x07),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_USB3_LFPS_DET_HIGH_COUNT_VAL, 0xf8),
+	QMP_PHY_INIT_CFG(QPHY_V4_PCS_USB3_POWER_STATE_CONFIG1, 0x6f),
+};
+
 static const struct qmp_phy_init_tbl sc8280xp_usb3_uniphy_serdes_tbl[] = {
 	QMP_PHY_INIT_CFG(QSERDES_V5_COM_SYSCLK_EN_SEL, 0x1a),
 	QMP_PHY_INIT_CFG(QSERDES_V5_COM_BIN_VCOCAL_HSCLK_SEL, 0x11),
@@ -1693,6 +1716,29 @@ static const struct qmp_phy_cfg msm8996_usb3phy_cfg = {
 	.regs			= qmp_v2_usb3phy_regs_layout,
 };

+static const struct qmp_phy_cfg qdu1000_usb3_uniphy_cfg = {
+	.lanes			= 1,
+
+	.offsets		= &qmp_usb_offsets_v5,
+
+	.serdes_tbl		= sm8150_usb3_uniphy_serdes_tbl,
+	.serdes_tbl_num		= ARRAY_SIZE(sm8150_usb3_uniphy_serdes_tbl),
+	.tx_tbl			= sm8350_usb3_uniphy_tx_tbl,
+	.tx_tbl_num		= ARRAY_SIZE(sm8350_usb3_uniphy_tx_tbl),
+	.rx_tbl			= sm8350_usb3_uniphy_rx_tbl,
+	.rx_tbl_num		= ARRAY_SIZE(sm8350_usb3_uniphy_rx_tbl),
+	.pcs_tbl		= qdu1000_usb3_uniphy_pcs_tbl,
+	.pcs_tbl_num		= ARRAY_SIZE(qdu1000_usb3_uniphy_pcs_tbl),
+	.pcs_usb_tbl		= qdu1000_usb3_uniphy_pcs_usb_tbl,
+	.pcs_usb_tbl_num	= ARRAY_SIZE(qdu1000_usb3_uniphy_pcs_usb_tbl),
+	.vreg_list		= qmp_phy_vreg_l,
+	.num_vregs		= ARRAY_SIZE(qmp_phy_vreg_l),
+	.regs			= qmp_v4_usb3phy_regs_layout,
+	.pcs_usb_offset		= 0x1000,
+
+	.has_pwrdn_delay	= true,
+};
+
 static const struct qmp_phy_cfg sa8775p_usb3_uniphy_cfg = {
 	.lanes			= 1,

@@ -2605,6 +2651,9 @@ static const struct of_device_id qmp_usb_of_match_table[] = {
 	}, {
 		.compatible = "qcom,qcm2290-qmp-usb3-phy",
 		.data = &qcm2290_usb3phy_cfg,
+	}, {
+		.compatible = "qcom,qdu1000-qmp-usb3-uni-phy",
+		.data = &qdu1000_usb3_uniphy_cfg,
 	}, {
 		.compatible = "qcom,sa8775p-qmp-usb3-uni-phy",
 		.data = &sa8775p_usb3_uniphy_cfg,
--
2.42.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform
  2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
                   ` (3 preceding siblings ...)
  2024-03-19  9:07 ` [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000 Komal Bajaj
@ 2024-03-19  9:35 ` Dmitry Baryshkov
  2024-03-29 11:02   ` Komal Bajaj
  2024-03-26  8:30 ` Greg Kroah-Hartman
  5 siblings, 1 reply; 11+ messages in thread
From: Dmitry Baryshkov @ 2024-03-19  9:35 UTC (permalink / raw
  To: Komal Bajaj
  Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng, linux-arm-msm,
	linux-phy, devicetree, linux-kernel, linux-usb

On Tue, 19 Mar 2024 at 11:08, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>
> This series adds support of USB3 PHY support for Qualcomm's QDU/QRU1000 Platform.
>
> ---------
> Changes in v2:
> * Dropped extra lines
> * Sorted the tables alphabetically
> * Link to v1: https://lore.kernel.org/linux-arm-msm/20240311120215.16845-1-quic_kbajaj@quicinc.com/

So, this is v2, but you didn't mark patches as v2. Please use b4 for
sending patches. It can handle patch revisions automatically.

>
> Komal Bajaj (4):
>   dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
>   dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
>   dt-bindings: usb: dwc3: Add QDU1000 compatible
>   phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000
>
>  .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  2 +
>  .../bindings/phy/qcom,usb-snps-femto-v2.yaml  |  1 +
>  .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 ++
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 49 +++++++++++++++++++
>  4 files changed, 55 insertions(+)



-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000
  2024-03-19  9:07 ` [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000 Komal Bajaj
@ 2024-03-19  9:36   ` Dmitry Baryshkov
  0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2024-03-19  9:36 UTC (permalink / raw
  To: Komal Bajaj
  Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng, linux-arm-msm,
	linux-phy, devicetree, linux-kernel, linux-usb, Amrit Anand

On Tue, 19 Mar 2024 at 11:09, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>
> Add QDU1000/QRU1000 specific register layout and table configs.
>
> Co-developed-by: Amrit Anand <quic_amrianan@quicinc.com>
> Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 49 +++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform
  2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
                   ` (4 preceding siblings ...)
  2024-03-19  9:35 ` [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Dmitry Baryshkov
@ 2024-03-26  8:30 ` Greg Kroah-Hartman
  2024-03-29 11:28   ` Komal Bajaj
  5 siblings, 1 reply; 11+ messages in thread
From: Greg Kroah-Hartman @ 2024-03-26  8:30 UTC (permalink / raw
  To: Komal Bajaj
  Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Wesley Cheng, linux-arm-msm, linux-phy, devicetree,
	linux-kernel, linux-usb

On Tue, Mar 19, 2024 at 02:37:24PM +0530, Komal Bajaj wrote:
> This series adds support of USB3 PHY support for Qualcomm's QDU/QRU1000 Platform.
> 
> ---------
> Changes in v2:
> * Dropped extra lines
> * Sorted the tables alphabetically
> * Link to v1: https://lore.kernel.org/linux-arm-msm/20240311120215.16845-1-quic_kbajaj@quicinc.com/
> 
> Komal Bajaj (4):
>   dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
>   dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
>   dt-bindings: usb: dwc3: Add QDU1000 compatible
>   phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000
> 
>  .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  2 +
>  .../bindings/phy/qcom,usb-snps-femto-v2.yaml  |  1 +
>  .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 ++
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 49 +++++++++++++++++++
>  4 files changed, 55 insertions(+)
> 
> --
> 2.42.0
> 
> 

The subject line here does not say v2, so I'm confused as to which one
is which :(

Please fix up and send a v3.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform
  2024-03-19  9:35 ` [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Dmitry Baryshkov
@ 2024-03-29 11:02   ` Komal Bajaj
  0 siblings, 0 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-29 11:02 UTC (permalink / raw
  To: Dmitry Baryshkov
  Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Greg Kroah-Hartman, Wesley Cheng, linux-arm-msm,
	linux-phy, devicetree, linux-kernel, linux-usb



On 3/19/2024 3:05 PM, Dmitry Baryshkov wrote:
> On Tue, 19 Mar 2024 at 11:08, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>>
>> This series adds support of USB3 PHY support for Qualcomm's QDU/QRU1000 Platform.
>>
>> ---------
>> Changes in v2:
>> * Dropped extra lines
>> * Sorted the tables alphabetically
>> * Link to v1: https://lore.kernel.org/linux-arm-msm/20240311120215.16845-1-quic_kbajaj@quicinc.com/
> 
> So, this is v2, but you didn't mark patches as v2. Please use b4 for
> sending patches. It can handle patch revisions automatically.

Apologies for this, forgot to mark patches as v2.
I will be careful next time.

> 
>>
>> Komal Bajaj (4):
>>    dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
>>    dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
>>    dt-bindings: usb: dwc3: Add QDU1000 compatible
>>    phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000
>>
>>   .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  2 +
>>   .../bindings/phy/qcom,usb-snps-femto-v2.yaml  |  1 +
>>   .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 ++
>>   drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 49 +++++++++++++++++++
>>   4 files changed, 55 insertions(+)
> 
> 
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform
  2024-03-26  8:30 ` Greg Kroah-Hartman
@ 2024-03-29 11:28   ` Komal Bajaj
  0 siblings, 0 replies; 11+ messages in thread
From: Komal Bajaj @ 2024-03-29 11:28 UTC (permalink / raw
  To: Greg Kroah-Hartman
  Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
	Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Wesley Cheng, linux-arm-msm, linux-phy, devicetree,
	linux-kernel, linux-usb



On 3/26/2024 2:00 PM, Greg Kroah-Hartman wrote:
> On Tue, Mar 19, 2024 at 02:37:24PM +0530, Komal Bajaj wrote:
>> This series adds support of USB3 PHY support for Qualcomm's QDU/QRU1000 Platform.
>>
>> ---------
>> Changes in v2:
>> * Dropped extra lines
>> * Sorted the tables alphabetically
>> * Link to v1: https://lore.kernel.org/linux-arm-msm/20240311120215.16845-1-quic_kbajaj@quicinc.com/
>>
>> Komal Bajaj (4):
>>    dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000
>>    dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY
>>    dt-bindings: usb: dwc3: Add QDU1000 compatible
>>    phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000
>>
>>   .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   |  2 +
>>   .../bindings/phy/qcom,usb-snps-femto-v2.yaml  |  1 +
>>   .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 ++
>>   drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 49 +++++++++++++++++++
>>   4 files changed, 55 insertions(+)
>>
>> --
>> 2.42.0
>>
>>
> 
> The subject line here does not say v2, so I'm confused as to which one
> is which :(
> 
> Please fix up and send a v3.

Apologies, forgot to mark patches as v2.
Will soon send v3 series with proper marking.

Thanks
Komal

> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-03-29 11:28 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19  9:07 [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Komal Bajaj
2024-03-19  9:07 ` [PATCH 1/4] dt-bindings: phy: qcom,usb-snps-femto-v2: Add bindings for QDU1000 Komal Bajaj
2024-03-19  9:07 ` [PATCH 2/4] dt-bindings: phy: qcom,qmp-usb: Add QDU1000 USB3 PHY Komal Bajaj
2024-03-19  9:07 ` [PATCH 3/4] dt-bindings: usb: dwc3: Add QDU1000 compatible Komal Bajaj
2024-03-19  9:07 ` [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000 Komal Bajaj
2024-03-19  9:36   ` Dmitry Baryshkov
2024-03-19  9:35 ` [PATCH 0/4] Add USB Support on Qualcomm's QDU/QRU1000 Platform Dmitry Baryshkov
2024-03-29 11:02   ` Komal Bajaj
2024-03-26  8:30 ` Greg Kroah-Hartman
2024-03-29 11:28   ` Komal Bajaj
  -- strict thread matches above, loose matches on Subject: below --
2024-03-11 12:02 Komal Bajaj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).