* [PATCH linux-next] scsi: target: core: use strscpy() is more robust and safer
@ 2022-10-20 5:46 cuijinpeng666
2022-10-20 9:48 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: cuijinpeng666 @ 2022-10-20 5:46 UTC (permalink / raw
To: martin.petersen, linux-scsi
Cc: target-devel, linux-kernel, Jinpeng Cui, Zeal Robot
From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
The implementation of strscpy() is more robust and safer.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
drivers/target/target_core_device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index b7f16ee8aa0e..0eec5a3217b9 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -809,10 +809,10 @@ struct se_device *target_alloc_device(struct se_hba *hba, const char *name)
xcopy_lun->lun_tpg = &xcopy_pt_tpg;
/* Preload the default INQUIRY const values */
- strlcpy(dev->t10_wwn.vendor, "LIO-ORG", sizeof(dev->t10_wwn.vendor));
- strlcpy(dev->t10_wwn.model, dev->transport->inquiry_prod,
+ strscpy(dev->t10_wwn.vendor, "LIO-ORG", sizeof(dev->t10_wwn.vendor));
+ strscpy(dev->t10_wwn.model, dev->transport->inquiry_prod,
sizeof(dev->t10_wwn.model));
- strlcpy(dev->t10_wwn.revision, dev->transport->inquiry_rev,
+ strscpy(dev->t10_wwn.revision, dev->transport->inquiry_rev,
sizeof(dev->t10_wwn.revision));
return dev;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] scsi: target: core: use strscpy() is more robust and safer
2022-10-20 5:46 [PATCH linux-next] scsi: target: core: use strscpy() is more robust and safer cuijinpeng666
@ 2022-10-20 9:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-10-20 9:48 UTC (permalink / raw
To: cuijinpeng666
Cc: martin.petersen, linux-scsi, target-devel, linux-kernel,
Jinpeng Cui, Zeal Robot
On Thu, Oct 20, 2022 at 05:46:50AM +0000, cuijinpeng666@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Please ignore based on this response:
https://lore.kernel.org/r/Y1EVnZS9BalesrC1@kroah.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 5:46 [PATCH linux-next] scsi: target: core: use strscpy() is more robust and safer cuijinpeng666
2022-10-20 9:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).