* [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning
@ 2021-06-07 1:30 Andrew Jeffery
2021-06-07 4:11 ` Joel Stanley
2021-06-08 13:15 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jeffery @ 2021-06-07 1:30 UTC (permalink / raw
To: linux-mmc
Cc: adrian.hunter, ulf.hansson, joel, linux-aspeed, linux-arm-kernel,
linux-kernel, steven_lee
The card timing and the bus frequency are not changed atomically with
respect to calls to the set_clock() callback in the driver. The result
is the driver sees a transient state where there's a mismatch between
the two and thus the inputs to the phase correction calculation
formula are garbage.
Switch from dev_warn() to dev_dbg() to avoid noise in the normal case,
though the change does make bad configurations less likely to be
noticed.
Reported-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
drivers/mmc/host/sdhci-of-aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
index d001c51074a0..e4665a438ec5 100644
--- a/drivers/mmc/host/sdhci-of-aspeed.c
+++ b/drivers/mmc/host/sdhci-of-aspeed.c
@@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz,
tap = div_u64(phase_period_ps, prop_delay_ps);
if (tap > ASPEED_SDHCI_NR_TAPS) {
- dev_warn(dev,
+ dev_dbg(dev,
"Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n",
tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS);
tap = ASPEED_SDHCI_NR_TAPS;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning
2021-06-07 1:30 [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning Andrew Jeffery
@ 2021-06-07 4:11 ` Joel Stanley
2021-06-08 13:15 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2021-06-07 4:11 UTC (permalink / raw
To: Andrew Jeffery
Cc: linux-mmc, Adrian Hunter, Ulf Hansson, linux-aspeed, Linux ARM,
Linux Kernel Mailing List, Steven Lee
On Mon, 7 Jun 2021 at 01:30, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The card timing and the bus frequency are not changed atomically with
> respect to calls to the set_clock() callback in the driver. The result
> is the driver sees a transient state where there's a mismatch between
> the two and thus the inputs to the phase correction calculation
> formula are garbage.
>
> Switch from dev_warn() to dev_dbg() to avoid noise in the normal case,
> though the change does make bad configurations less likely to be
> noticed.
>
> Reported-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/mmc/host/sdhci-of-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
> index d001c51074a0..e4665a438ec5 100644
> --- a/drivers/mmc/host/sdhci-of-aspeed.c
> +++ b/drivers/mmc/host/sdhci-of-aspeed.c
> @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz,
>
> tap = div_u64(phase_period_ps, prop_delay_ps);
> if (tap > ASPEED_SDHCI_NR_TAPS) {
> - dev_warn(dev,
> + dev_dbg(dev,
> "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n",
> tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS);
> tap = ASPEED_SDHCI_NR_TAPS;
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning
2021-06-07 1:30 [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning Andrew Jeffery
2021-06-07 4:11 ` Joel Stanley
@ 2021-06-08 13:15 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2021-06-08 13:15 UTC (permalink / raw
To: Andrew Jeffery
Cc: linux-mmc, Adrian Hunter, Joel Stanley, linux-aspeed, Linux ARM,
Linux Kernel Mailing List, Steven Lee
On Mon, 7 Jun 2021 at 03:30, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The card timing and the bus frequency are not changed atomically with
> respect to calls to the set_clock() callback in the driver. The result
> is the driver sees a transient state where there's a mismatch between
> the two and thus the inputs to the phase correction calculation
> formula are garbage.
>
> Switch from dev_warn() to dev_dbg() to avoid noise in the normal case,
> though the change does make bad configurations less likely to be
> noticed.
>
> Reported-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
> index d001c51074a0..e4665a438ec5 100644
> --- a/drivers/mmc/host/sdhci-of-aspeed.c
> +++ b/drivers/mmc/host/sdhci-of-aspeed.c
> @@ -150,7 +150,7 @@ static int aspeed_sdhci_phase_to_tap(struct device *dev, unsigned long rate_hz,
>
> tap = div_u64(phase_period_ps, prop_delay_ps);
> if (tap > ASPEED_SDHCI_NR_TAPS) {
> - dev_warn(dev,
> + dev_dbg(dev,
> "Requested out of range phase tap %d for %d degrees of phase compensation at %luHz, clamping to tap %d\n",
> tap, phase_deg, rate_hz, ASPEED_SDHCI_NR_TAPS);
> tap = ASPEED_SDHCI_NR_TAPS;
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-08 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-07 1:30 [PATCH] mmc: sdhci-of-aspeed: Turn down a phase correction warning Andrew Jeffery
2021-06-07 4:11 ` Joel Stanley
2021-06-08 13:15 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).