From: Wilken Gottwalt <wilken.gottwalt@posteo.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: corsair-psu: fix suspend behavior
Date: Fri, 4 Jun 2021 05:17:11 +0000 [thread overview]
Message-ID: <20210604071711.78271072@monster.powergraphx.local> (raw)
In-Reply-To: <20210603160533.GA3952041@roeck-us.net>
On Thu, 3 Jun 2021 09:05:33 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> On Thu, Jun 03, 2021 at 11:51:02AM +0000, Wilken Gottwalt wrote:
> > During standby some PSUs turn off the microcontroller. A re-init is
> > required during resume or the microcontroller stays unresponsive.
> >
> > Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver")
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
>
> Applied.
Thank you. Though I have an odd question. I would like to change the licensing to
a dual license (GPL/MPL) to support the LibreHardwareMonitor project. They want
to use my code but use a MPL license. What would be the best way to do this?
greetings,
Will
> Thanks,
> Guenter
>
> > ---
> > Changes in v2:
> > - corrected fixes commit
> > ---
> > drivers/hwmon/corsair-psu.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> > index 02298b86b57b..731d5117f9f1 100644
> > --- a/drivers/hwmon/corsair-psu.c
> > +++ b/drivers/hwmon/corsair-psu.c
> > @@ -771,6 +771,16 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report
> > *repo return 0;
> > }
> >
> > +#ifdef CONFIG_PM
> > +static int corsairpsu_resume(struct hid_device *hdev)
> > +{
> > + struct corsairpsu_data *priv = hid_get_drvdata(hdev);
> > +
> > + /* some PSUs turn off the microcontroller during standby, so a reinit is required */
> > + return corsairpsu_init(priv);
> > +}
> > +#endif
> > +
> > static const struct hid_device_id corsairpsu_idtable[] = {
> > { HID_USB_DEVICE(0x1b1c, 0x1c03) }, /* Corsair HX550i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */
> > @@ -793,6 +803,10 @@ static struct hid_driver corsairpsu_driver = {
> > .probe = corsairpsu_probe,
> > .remove = corsairpsu_remove,
> > .raw_event = corsairpsu_raw_event,
> > +#ifdef CONFIG_PM
> > + .resume = corsairpsu_resume,
> > + .reset_resume = corsairpsu_resume,
> > +#endif
> > };
> > module_hid_driver(corsairpsu_driver);
> >
next prev parent reply other threads:[~2021-06-04 5:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 11:51 [PATCH v2] hwmon: corsair-psu: fix suspend behavior Wilken Gottwalt
2021-06-03 16:05 ` Guenter Roeck
2021-06-04 5:17 ` Wilken Gottwalt [this message]
2021-06-04 11:05 ` Guenter Roeck
2021-06-13 14:06 ` Wilken Gottwalt
2021-06-13 17:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604071711.78271072@monster.powergraphx.local \
--to=wilken.gottwalt@posteo.net \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).