* [PATCH] scsi: libsas: Use fallthrough pseudo-keyword
@ 2021-05-09 15:00 Wei Ming Chen
0 siblings, 0 replies; 3+ messages in thread
From: Wei Ming Chen @ 2021-05-09 15:00 UTC (permalink / raw
To: linux-kernel; +Cc: jejb, martin.petersen, Wei Ming Chen
Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
---
drivers/scsi/libsas/sas_discover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
index 9f5068f3bcfb..dd205414e505 100644
--- a/drivers/scsi/libsas/sas_discover.c
+++ b/drivers/scsi/libsas/sas_discover.c
@@ -461,7 +461,7 @@ static void sas_discover_domain(struct work_struct *work)
break;
#else
pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
- /* Fall through */
+ fallthrough;
#endif
/* Fall through - only for the #else condition above. */
default:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] scsi: libsas: Use fallthrough pseudo-keyword
@ 2021-05-31 15:37 Wei Ming Chen
2021-06-01 8:16 ` John Garry
0 siblings, 1 reply; 3+ messages in thread
From: Wei Ming Chen @ 2021-05-31 15:37 UTC (permalink / raw
To: linux-kernel; +Cc: linux-scsi, jejb, martin.petersen, Wei Ming Chen
Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
---
drivers/scsi/libsas/sas_discover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
index 9f5068f3bcfb..dd205414e505 100644
--- a/drivers/scsi/libsas/sas_discover.c
+++ b/drivers/scsi/libsas/sas_discover.c
@@ -461,7 +461,7 @@ static void sas_discover_domain(struct work_struct *work)
break;
#else
pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
- /* Fall through */
+ fallthrough;
#endif
/* Fall through - only for the #else condition above. */
default:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libsas: Use fallthrough pseudo-keyword
2021-05-31 15:37 [PATCH] scsi: libsas: Use fallthrough pseudo-keyword Wei Ming Chen
@ 2021-06-01 8:16 ` John Garry
0 siblings, 0 replies; 3+ messages in thread
From: John Garry @ 2021-06-01 8:16 UTC (permalink / raw
To: Wei Ming Chen, linux-kernel
Cc: linux-scsi, jejb, martin.petersen, Gustavo A. R. Silva
+ Gustavo
On 31/05/2021 16:37, Wei Ming Chen wrote:
> Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
> drivers/scsi/libsas/sas_discover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> index 9f5068f3bcfb..dd205414e505 100644
> --- a/drivers/scsi/libsas/sas_discover.c
> +++ b/drivers/scsi/libsas/sas_discover.c
> @@ -461,7 +461,7 @@ static void sas_discover_domain(struct work_struct *work)
> break;
> #else
> pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
> - /* Fall through */
> + fallthrough;
I don't know why we need the 2nd fall through (and the compiler can't
see the first one) - added by Gustavo in da1fb2909 - but I think that
this one can now simply be removed.
> #endif
> /* Fall through - only for the #else condition above. */
Thanks,
John
> default:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-01 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-31 15:37 [PATCH] scsi: libsas: Use fallthrough pseudo-keyword Wei Ming Chen
2021-06-01 8:16 ` John Garry
-- strict thread matches above, loose matches on Subject: below --
2021-05-09 15:00 Wei Ming Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).