LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: core-api: fix broken references for div64.c and gcd.c
@ 2019-04-18  9:50 Mauro Carvalho Chehab
  2019-04-18 21:59 ` Randy Dunlap
  2019-04-19 18:55 ` Jonathan Corbet
  0 siblings, 2 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2019-04-18  9:50 UTC (permalink / raw
  To: Linux Doc Mailing List, Andrew Morton, Stephen Rothwell
  Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab, linux-kernel,
	Jonathan Corbet, Andy Shevchenko, Thierry Reding, Lee Jones,
	Daniel Thompson, Ray Jui, Mike Rapoport, Randy Dunlap,
	Marcos Paulo de Souza

Those files were moved to lib/math.

Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
 Documentation/core-api/kernel-api.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
index 71f5d2fe39b7..a29c99d13331 100644
--- a/Documentation/core-api/kernel-api.rst
+++ b/Documentation/core-api/kernel-api.rst
@@ -147,10 +147,10 @@ Division Functions
 .. kernel-doc:: include/linux/math64.h
    :internal:
 
-.. kernel-doc:: lib/div64.c
+.. kernel-doc:: lib/math/div64.c
    :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
 
-.. kernel-doc:: lib/gcd.c
+.. kernel-doc:: lib/math/gcd.c
    :export:
 
 UUID/GUID
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c
  2019-04-18  9:50 [PATCH] docs: core-api: fix broken references for div64.c and gcd.c Mauro Carvalho Chehab
@ 2019-04-18 21:59 ` Randy Dunlap
  2019-04-18 22:51   ` Mauro Carvalho Chehab
  2019-04-19 18:55 ` Jonathan Corbet
  1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2019-04-18 21:59 UTC (permalink / raw
  To: Mauro Carvalho Chehab, Linux Doc Mailing List, Andrew Morton,
	Stephen Rothwell
  Cc: Mauro Carvalho Chehab, linux-kernel, Jonathan Corbet,
	Andy Shevchenko, Thierry Reding, Lee Jones, Daniel Thompson,
	Ray Jui, Mike Rapoport, Marcos Paulo de Souza

On 4/18/19 2:50 AM, Mauro Carvalho Chehab wrote:
> Those files were moved to lib/math.
> 
> Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")

Is that commid ID in mainline?  I get:
fatal: ambiguous argument '9635bad21596': unknown revision or path not in the working tree.

> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  Documentation/core-api/kernel-api.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index 71f5d2fe39b7..a29c99d13331 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -147,10 +147,10 @@ Division Functions
>  .. kernel-doc:: include/linux/math64.h
>     :internal:
>  
> -.. kernel-doc:: lib/div64.c
> +.. kernel-doc:: lib/math/div64.c
>     :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
>  
> -.. kernel-doc:: lib/gcd.c
> +.. kernel-doc:: lib/math/gcd.c
>     :export:
>  
>  UUID/GUID
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c
  2019-04-18 21:59 ` Randy Dunlap
@ 2019-04-18 22:51   ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2019-04-18 22:51 UTC (permalink / raw
  To: Randy Dunlap
  Cc: Linux Doc Mailing List, Andrew Morton, Stephen Rothwell,
	Mauro Carvalho Chehab, linux-kernel, Jonathan Corbet,
	Andy Shevchenko, Thierry Reding, Lee Jones, Daniel Thompson,
	Ray Jui, Mike Rapoport, Marcos Paulo de Souza

Em Thu, 18 Apr 2019 14:59:41 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:

> On 4/18/19 2:50 AM, Mauro Carvalho Chehab wrote:
> > Those files were moved to lib/math.
> > 
> > Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")  
> 
> Is that commid ID in mainline?  I get:
> fatal: ambiguous argument '9635bad21596': unknown revision or path not in the working tree.

No, it is on Linux-next.

> 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>  
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Thanks.
> 
> > ---
> >  Documentation/core-api/kernel-api.rst | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> > index 71f5d2fe39b7..a29c99d13331 100644
> > --- a/Documentation/core-api/kernel-api.rst
> > +++ b/Documentation/core-api/kernel-api.rst
> > @@ -147,10 +147,10 @@ Division Functions
> >  .. kernel-doc:: include/linux/math64.h
> >     :internal:
> >  
> > -.. kernel-doc:: lib/div64.c
> > +.. kernel-doc:: lib/math/div64.c
> >     :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
> >  
> > -.. kernel-doc:: lib/gcd.c
> > +.. kernel-doc:: lib/math/gcd.c
> >     :export:
> >  
> >  UUID/GUID
> >   
> 
> 



Thanks,
Mauro

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c
  2019-04-18  9:50 [PATCH] docs: core-api: fix broken references for div64.c and gcd.c Mauro Carvalho Chehab
  2019-04-18 21:59 ` Randy Dunlap
@ 2019-04-19 18:55 ` Jonathan Corbet
  2019-04-19 20:35   ` Andrew Morton
  1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Corbet @ 2019-04-19 18:55 UTC (permalink / raw
  To: Mauro Carvalho Chehab
  Cc: Linux Doc Mailing List, Andrew Morton, Stephen Rothwell,
	Mauro Carvalho Chehab, linux-kernel, Andy Shevchenko,
	Thierry Reding, Lee Jones, Daniel Thompson, Ray Jui,
	Mike Rapoport, Randy Dunlap, Marcos Paulo de Souza

On Thu, 18 Apr 2019 06:50:18 -0300
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> wrote:

> Those files were moved to lib/math.
> 
> Fixes: 9635bad21596 ("lib: Move mathematic helpers to separate folder")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
>  Documentation/core-api/kernel-api.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index 71f5d2fe39b7..a29c99d13331 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -147,10 +147,10 @@ Division Functions
>  .. kernel-doc:: include/linux/math64.h
>     :internal:
>  
> -.. kernel-doc:: lib/div64.c
> +.. kernel-doc:: lib/math/div64.c
>     :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
>  
> -.. kernel-doc:: lib/gcd.c
> +.. kernel-doc:: lib/math/gcd.c
>     :export:

This, of course, creates a build error in docs-next...hopefully that
situation won't last more than a couple of weeks or so.  Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: core-api: fix broken references for div64.c and gcd.c
  2019-04-19 18:55 ` Jonathan Corbet
@ 2019-04-19 20:35   ` Andrew Morton
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2019-04-19 20:35 UTC (permalink / raw
  To: Jonathan Corbet
  Cc: Mauro Carvalho Chehab, Linux Doc Mailing List, Stephen Rothwell,
	Mauro Carvalho Chehab, linux-kernel, Andy Shevchenko,
	Thierry Reding, Lee Jones, Daniel Thompson, Ray Jui,
	Mike Rapoport, Randy Dunlap, Marcos Paulo de Souza

On Fri, 19 Apr 2019 12:55:48 -0600 Jonathan Corbet <corbet@lwn.net> wrote:

> > -.. kernel-doc:: lib/div64.c
> > +.. kernel-doc:: lib/math/div64.c
> >     :functions: div_s64_rem div64_u64_rem div64_u64 div64_s64
> >  
> > -.. kernel-doc:: lib/gcd.c
> > +.. kernel-doc:: lib/math/gcd.c
> >     :export:
> 
> This, of course, creates a build error in docs-next...hopefully that
> situation won't last more than a couple of weeks or so.

I'll fold this into the base patch
lib-move-mathematic-helpers-to-separate-folder.patch so there won't be
such a situation.

> Applied, thanks.

Please unapply ;)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-19 20:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-18  9:50 [PATCH] docs: core-api: fix broken references for div64.c and gcd.c Mauro Carvalho Chehab
2019-04-18 21:59 ` Randy Dunlap
2019-04-18 22:51   ` Mauro Carvalho Chehab
2019-04-19 18:55 ` Jonathan Corbet
2019-04-19 20:35   ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).