* [PATCH] x86/cpu/intel: Lower "ENERGY_PERF_BIAS: Set to normal" message log priority
@ 2018-12-30 17:27 Hans de Goede
2019-04-19 17:28 ` [tip:x86/urgent] x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's " tip-bot for Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2018-12-30 17:27 UTC (permalink / raw
To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H . Peter Anvin
Cc: Hans de Goede, x86, linux-kernel
The "ENERGY_PERF_BIAS: Set to 'normal', was 'performance'" message triggers
on pretty much every Intel machine. The purpose of log messages with
a warning level is to notify the user of something which potentially is
a problem, or at least somewhat unexpected.
This message clearly does not match those criteria, so lower its log
priority from warning to info.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
arch/x86/kernel/cpu/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index fc3c07fe7df5..3142fd7a9b32 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -611,8 +611,8 @@ static void init_intel_energy_perf(struct cpuinfo_x86 *c)
if ((epb & 0xF) != ENERGY_PERF_BIAS_PERFORMANCE)
return;
- pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
- pr_warn_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
+ pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
+ pr_info_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's log priority
2018-12-30 17:27 [PATCH] x86/cpu/intel: Lower "ENERGY_PERF_BIAS: Set to normal" message log priority Hans de Goede
@ 2019-04-19 17:28 ` tip-bot for Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Hans de Goede @ 2019-04-19 17:28 UTC (permalink / raw
To: linux-tip-commits
Cc: linux-kernel, hpa, hdegoede, torvalds, tglx, peterz, mingo, bp
Commit-ID: 2ee27796f298b710992a677a7e4d35c8c588b17e
Gitweb: https://git.kernel.org/tip/2ee27796f298b710992a677a7e4d35c8c588b17e
Author: Hans de Goede <hdegoede@redhat.com>
AuthorDate: Sun, 30 Dec 2018 18:27:15 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 19 Apr 2019 19:23:13 +0200
x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's log priority
The "ENERGY_PERF_BIAS: Set to 'normal', was 'performance'" message triggers
on pretty much every Intel machine. The purpose of log messages with
a warning level is to notify the user of something which potentially is
a problem, or at least somewhat unexpected.
This message clearly does not match those criteria, so lower its log
priority from warning to info.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20181230172715.17469-1-hdegoede@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index fc3c07fe7df5..3142fd7a9b32 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -611,8 +611,8 @@ static void init_intel_energy_perf(struct cpuinfo_x86 *c)
if ((epb & 0xF) != ENERGY_PERF_BIAS_PERFORMANCE)
return;
- pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
- pr_warn_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
+ pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
+ pr_info_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-19 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-30 17:27 [PATCH] x86/cpu/intel: Lower "ENERGY_PERF_BIAS: Set to normal" message log priority Hans de Goede
2019-04-19 17:28 ` [tip:x86/urgent] x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's " tip-bot for Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).