* mmotm 2011-01-25-15-47 uploaded
@ 2011-01-25 23:48 akpm
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: akpm @ 2011-01-25 23:48 UTC (permalink / raw
To: mm-commits, linux-kernel, linux-mm, linux-fsdevel
The mm-of-the-moment snapshot 2011-01-25-15-47 has been uploaded to
http://userweb.kernel.org/~akpm/mmotm/
and will soon be available at
git://zen-kernel.org/kernel/mmotm.git
It contains the following patches against 2.6.38-rc2:
origin.patch
thp-fix-paravirt-x86-32bit-nopae.patch
mm-pgtable-genericc-fix-config_swap=n-build.patch
leds-leds-pwm-return-proper-error-if-pwm_request-failed.patch
langwell_gpio-modify-eoi-handling-following-change-of-kernel-irq-subsystem.patch
parport-make-lockdep-happy-with-waitlist_lock.patch
pps-ktimer-remove-noisy-message.patch
pps-claim-parallel-port-exclusively.patch
mm-fix-deferred-congestion-timeout-if-preferred-zone-is-not-allowed.patch
mm-clear-pages_scanned-only-if-draining-a-pcp-adds-pages-to-the-buddy-allocator.patch
mm-memcontrolc-fix-uninitialized-variable-use-in-mem_cgroup_move_parent.patch
mm-compaction-dont-depend-on-hugetlb_page.patch
mm-migration-clarify-migrate_pages-comment.patch
memcg-fix-account-leak-at-failure-of-memsw-acconting.patch
memcg-bugfix-check-mem_cgroup_disabled-at-split-fixup.patch
memcg-fix-race-at-move_parent-around-compound_order.patch
atmel_tc-tcb_clksrc-fix-init-sequence.patch
radix_tree-radix_tree_gang_lookup_tag_slot-may-not-return-forever.patch
squashfs-fix-use-of-uninitialised-variable-in-zlib-xz-decompressors.patch
change-acquire-release_console_sem-to-console_lock-unlock.patch
mm-numa-aware-alloc_task_struct_node.patch
mm-numa-aware-alloc_thread_info_node.patch
kthread-numa-aware-kthread_create_on_cpu.patch
kthread-use-kthread_create_on_cpu.patch
linux-next.patch
linux-next-git-rejects.patch
next-remove-localversion.patch
i-need-old-gcc.patch
arch-alpha-kernel-systblss-remove-debug-check.patch
backlight-new-driver-for-the-adp8870-backlight-devices.patch
mm-vmap-area-cache.patch
loop-queue_lock-null-pointer-derefence-in-blk_throtl_exit-v3.patch
drivers-media-video-tlg2300-pd-videoc-fix-double-mutex_unlock-in-pd_vidioc_s_fmt.patch
scsi-include-linux-scatterlisth-to-pick-up-arch_has_sg_chain.patch
acerhdf-add-support-for-aspire-1410-bios-v13314.patch
x86-numa-add-error-handling-for-bad-cpu-to-node-mappings.patch
msm-timer-migrate-to-timer-based-__delay.patch
audit-always-follow-va_copy-with-va_end.patch
fs-btrfs-inodec-eliminate-memory-leak.patch
btrfs-dont-dereference-extent_mapping-if-null.patch
cpufreq-fix-ondemand-governor-powersave_bias-execution-time-misuse.patch
drivers-dma-ipu-ipu_irqc-irq_data-conversion.patch
debugfs-remove-module_exit.patch
drivers-gpu-drm-radeon-atomc-fix-warning.patch
cyber2000fb-avoid-palette-corruption-at-higher-clocks.patch
leds-convert-bd2802-driver-to-dev_pm_ops.patch
leds-convert-bd2802-driver-to-dev_pm_ops-fix.patch
leds-add-driver-for-lm3530-als.patch
leds-add-driver-for-lm3530-als-update.patch
leds-route-kbd-leds-through-the-generic-leds-layer.patch
mips-enable-arch_dma_addr_t_64bit-with-highmem-64bit_phys_addr-64bit.patch
backlight-add-backlight-type.patch
backlight-add-backlight-type-fix.patch
backlight-add-backlight-type-fix-fix.patch
i915-add-native-backlight-control.patch
radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch
radeon-expose-backlight-class-device-for-legacy-lvds-encoder-update.patch
nouveau-change-the-backlight-parent-device-to-the-connector-not-the-pci-dev.patch
acpi-tie-acpi-backlight-devices-to-pci-devices-if-possible.patch
mbp_nvidia_bl-remove-dmi-dependency.patch
mbp_nvidia_bl-check-that-the-backlight-control-functions.patch
mbp_nvidia_bl-rename-to-apple_bl.patch
btusb-patch-add_apple_macbookpro62.patch
tty-serial-fix-apbuart-build.patch
drivers-message-fusion-mptsasc-fix-warning.patch
scsi-fix-a-header-to-include-linux-typesh.patch
drivers-block-makefile-replace-the-use-of-module-objs-with-module-y.patch
drivers-block-aoe-makefile-replace-the-use-of-module-objs-with-module-y.patch
cciss-make-cciss_revalidate-not-loop-through-ciss_max_luns-volumes-unnecessarily.patch
loop-queue_lock-null-pointer-derefence-in-blk_throtl_exit.patch
drbd-fix-warning.patch
usb-yurex-recognize-generalkeys-wireless-presenter-as-generic-hid.patch
vfs-remove-a-warning-on-open_fmode.patch
vfs-add-__fmode_exec.patch
fs-make-block-fiemap-mapping-length-at-least-blocksize-long.patch
n_hdlc-fix-read-and-write-locking.patch
mm.patch
oom-suppress-nodes-that-are-not-allowed-from-meminfo-on-oom-kill.patch
oom-suppress-show_mem-for-many-nodes-in-irq-context-on-page-alloc-failure.patch
oom-suppress-nodes-that-are-not-allowed-from-meminfo-on-page-alloc-failure.patch
mm-notifier_from_errno-cleanup.patch
mm-add-replace_page_cache_page-function.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
hpet-factor-timer-allocate-from-open.patch
arch-alpha-include-asm-ioh-s-extern-inline-static-inline.patch
uml-kernels-on-i386x86_64-produce-bad-coredumps.patch
add-the-common-dma_addr_t-typedef-to-include-linux-typesh.patch
bh1780gli-convert-to-dev-pm-ops.patch
drivers-misc-bmp085c-free-initmem-memory.patch
smp-move-smp-setup-functions-to-kernel-smpc.patch
llist-add-kconfig-option-arch_have_nmi_safe_cmpxchg.patch
llist-lib-add-lock-less-null-terminated-single-list.patch
llist-irq_work-use-llist-in-irq_work.patch
llist-net-rds-replace-xlist-in-net-rds-xlisth-with-llist.patch
net-convert-%p-usage-to-%pk.patch
vsprintf-neaten-%pk-kptr_restrict-save-a-bit-of-code-space.patch
console-allow-to-retain-boot-console-via-boot-option-keep_bootcon.patch
console-prevent-registered-consoles-from-dumping-old-kernel-message-over-again.patch
vfs-ignore-error-on-forced-remount.patch
vfs-keep-list-of-mounts-for-each-superblock.patch
vfs-protect-remounting-superblock-read-only.patch
vfs-fs_may_remount_ro-turn-unnecessary-check-into-a-warn_on.patch
fs-ioctlc-remove-unnecessary-variable.patch
get_maintainerpl-add-support-to-match-arbitrary-text.patch
sigma-firmware-loader-for-analog-devices-sigmastudio.patch
sigma-firmware-loader-for-analog-devices-sigmastudio-v2.patch
drivers-mmc-host-omapc-use-resource_size.patch
drivers-mmc-host-omap_hsmmcc-use-resource_size.patch
select-remove-unused-max_select_seconds.patch
epoll-move-ready-event-check-into-proper-inline.patch
epoll-fix-compiler-warning-and-optimize-the-non-blocking-path.patch
binfmt_elf-quiet-gcc-46-set-but-not-used-warning-in-load_elf_binary.patch
lib-hexdumpc-make-hex2bin-return-the-updated-src-address.patch
fs-binfmt_miscc-use-kernels-hex_to_bin-method.patch
fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix.patch
fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix-fix.patch
init-return-proper-error-code-in-do_mounts_rd.patch
rtc-add-support-for-the-rtc-in-via-vt8500-and-compatibles.patch
rtc-add-real-time-clock-driver-for-nvidia-tegra.patch
jbd-remove-dependency-on-__gfp_nofail.patch
exec_domain-establish-a-linux32-domain-on-config_compat-systems.patch
rapidio-add-new-sysfs-attributes.patch
rapidio-add-rapidio-documentation.patch
fs-execc-provide-the-correct-process-pid-to-the-pipe-helper.patch
kernel-gcov-makefile-use-proper-ccflag-flag-in-makefile.patch
remove-dma64_addr_t.patch
adfs-fix-e-f-dir-size-2048-crashing-kernel.patch
adfs-improve-timestamp-precision.patch
adfs-add-hexadecimal-filetype-suffix-option.patch
adfs-remove-the-big-kernel-lock.patch
scatterlist-new-helper-functions.patch
memstick-add-driver-for-ricoh-r5c592-card-reader.patch
memstick-add-support-for-legacy-memorysticks.patch
memstick-add-support-for-legacy-memorysticks-update.patch
memstick-add-alex-dubov-to-maintainers-of-the-memstick-core.patch
kvm-stop-including-asm-generic-bitops-leh-directly.patch
rds-stop-including-asm-generic-bitops-leh-directly.patch
bitops-merge-little-and-big-endian-definisions-in-asm-generic-bitops-leh.patch
asm-generic-rename-generic-little-endian-bitops-functions.patch
asm-generic-change-little-endian-bitops-to-take-any-pointer-types.patch
powerpc-introduce-little-endian-bitops.patch
s390-introduce-little-endian-bitops.patch
arm-introduce-little-endian-bitops.patch
m68k-introduce-little-endian-bitops.patch
bitops-introduce-config_generic_find_bit_le.patch
m68knommu-introduce-little-endian-bitops.patch
bitops-introduce-little-endian-bitops-for-most-architectures.patch
asm-generic-use-little-endian-bitops.patch
kvm-use-little-endian-bitops.patch
rds-use-little-endian-bitops.patch
ext3-use-little-endian-bitops.patch
ext4-use-little-endian-bitops.patch
ocfs2-use-little-endian-bitops.patch
nilfs2-use-little-endian-bitops.patch
reiserfs-use-little-endian-bitops.patch
udf-use-little-endian-bitops.patch
ufs-use-little-endian-bitops.patch
md-use-little-endian-bitops.patch
dm-use-little-endian-bitops.patch
bitops-remove-ext2-non-atomic-bitops-from-asm-bitopsh.patch
m68k-remove-inline-asm-from-minix_find_first_zero_bit.patch
bitops-remove-minix-bitops-from-asm-bitopsh.patch
make-sure-nobodys-leaking-resources.patch
journal_add_journal_head-debug.patch
releasing-resources-with-children.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
mutex-subsystem-synchro-test-module-add-missing-header-file.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
add-debugging-aid-for-memory-initialisation-problems.patch
workaround-for-a-pci-restoring-bug.patch
prio_tree-debugging-patch.patch
single_open-seq_release-leak-diagnostics.patch
add-a-refcount-check-in-dput.patch
memblock-add-input-size-checking-to-memblock_find_region.patch
memblock-add-input-size-checking-to-memblock_find_region-fix.patch
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix
2011-01-25 23:48 mmotm 2011-01-25-15-47 uploaded akpm
@ 2011-01-26 10:20 ` Johannes Weiner
2011-01-26 15:05 ` Davide Libenzi
2011-01-26 19:16 ` [PATCH -mmotm] backlight: apple_bl depends on ACPI Randy Dunlap
2011-02-03 7:39 ` epoll broken [was: mmotm 2011-01-25-15-47 uploaded] Jiri Slaby
2 siblings, 1 reply; 8+ messages in thread
From: Johannes Weiner @ 2011-01-26 10:20 UTC (permalink / raw
To: akpm
Cc: shawn.bohrer, davidel, linux-mm, linux-fsdevel, mm-commits,
linux-kernel
The non-blocking ep_poll path optimization introduced skipping over
the return value setup.
Initialize it properly, my userspace gets upset by epoll_wait()
returning random things.
In addition, remove the reinitialization at the fetch_events label,
the return value is garuanteed to be zero when execution reaches
there.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: Davide Libenzi <davidel@xmailserver.org>
---
fs/eventpoll.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index f7cb6cb..afe4238 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1147,7 +1147,7 @@ static int ep_send_events(struct eventpoll *ep,
static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
int maxevents, long timeout)
{
- int res, eavail, timed_out = 0;
+ int res = 0, eavail, timed_out = 0;
unsigned long flags;
long slack = 0;
wait_queue_t wait;
@@ -1173,7 +1173,6 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
fetch_events:
spin_lock_irqsave(&ep->lock, flags);
- res = 0;
if (!ep_events_available(ep)) {
/*
* We don't have any available event to return to the caller.
--
1.7.3.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
@ 2011-01-26 15:05 ` Davide Libenzi
0 siblings, 0 replies; 8+ messages in thread
From: Davide Libenzi @ 2011-01-26 15:05 UTC (permalink / raw
To: Johannes Weiner
Cc: Andrew Morton, shawn.bohrer, linux-mm, linux-fsdevel, mm-commits,
Linux Kernel Mailing List
On Wed, 26 Jan 2011, Johannes Weiner wrote:
> The non-blocking ep_poll path optimization introduced skipping over
> the return value setup.
>
> Initialize it properly, my userspace gets upset by epoll_wait()
> returning random things.
>
> In addition, remove the reinitialization at the fetch_events label,
> the return value is garuanteed to be zero when execution reaches
> there.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Shawn Bohrer <shawn.bohrer@gmail.com>
> Cc: Davide Libenzi <davidel@xmailserver.org>
Thank you for posting it. Obvious ACK.
> ---
> fs/eventpoll.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index f7cb6cb..afe4238 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -1147,7 +1147,7 @@ static int ep_send_events(struct eventpoll *ep,
> static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
> int maxevents, long timeout)
> {
> - int res, eavail, timed_out = 0;
> + int res = 0, eavail, timed_out = 0;
> unsigned long flags;
> long slack = 0;
> wait_queue_t wait;
> @@ -1173,7 +1173,6 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
> fetch_events:
> spin_lock_irqsave(&ep->lock, flags);
>
> - res = 0;
> if (!ep_events_available(ep)) {
> /*
> * We don't have any available event to return to the caller.
> --
> 1.7.3.5
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH -mmotm] backlight: apple_bl depends on ACPI
2011-01-25 23:48 mmotm 2011-01-25-15-47 uploaded akpm
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
@ 2011-01-26 19:16 ` Randy Dunlap
2011-01-31 22:31 ` Matthew Garrett
2011-02-03 7:39 ` epoll broken [was: mmotm 2011-01-25-15-47 uploaded] Jiri Slaby
2 siblings, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2011-01-26 19:16 UTC (permalink / raw
To: linux-kernel, Matthew Garrett; +Cc: akpm, Richard Purdie
From: Randy Dunlap <randy.dunlap@oracle.com>
apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI.
drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list
drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type
drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer
drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:217: error: unknown field 'ids' specified in initializer
drivers/video/backlight/apple_bl.c:217: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:217: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:218: error: unknown field 'ops' specified in initializer
drivers/video/backlight/apple_bl.c:218: error: extra brace group at end of initializer
drivers/video/backlight/apple_bl.c:218: error: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:221: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:221: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:226: error: implicit declaration of function 'acpi_bus_register_driver'
drivers/video/backlight/apple_bl.c:231: error: implicit declaration of function 'acpi_bus_unregister_driver'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- mmotm-2011-0125-1547.orig/drivers/video/backlight/Kconfig
+++ mmotm-2011-0125-1547/drivers/video/backlight/Kconfig
@@ -238,10 +238,10 @@ config BACKLIGHT_MAX8925
config BACKLIGHT_APPLE
tristate "Apple Backlight Driver"
- depends on X86
+ depends on X86 && ACPI
help
If you have an Intel-based Apple say Y to enable a driver for its
- backlight
+ backlight.
config BACKLIGHT_TOSA
tristate "Sharp SL-6000 Backlight Driver"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -mmotm] backlight: apple_bl depends on ACPI
2011-01-26 19:16 ` [PATCH -mmotm] backlight: apple_bl depends on ACPI Randy Dunlap
@ 2011-01-31 22:31 ` Matthew Garrett
0 siblings, 0 replies; 8+ messages in thread
From: Matthew Garrett @ 2011-01-31 22:31 UTC (permalink / raw
To: Randy Dunlap; +Cc: linux-kernel, akpm, Richard Purdie
On Wed, Jan 26, 2011 at 11:16:02AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI.
>
> drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
> drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list
> drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type
> drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer
> drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:217: error: unknown field 'ids' specified in initializer
> drivers/video/backlight/apple_bl.c:217: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:217: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:218: error: unknown field 'ops' specified in initializer
> drivers/video/backlight/apple_bl.c:218: error: extra brace group at end of initializer
> drivers/video/backlight/apple_bl.c:218: error: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:221: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:221: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:226: error: implicit declaration of function 'acpi_bus_register_driver'
> drivers/video/backlight/apple_bl.c:231: error: implicit declaration of function 'acpi_bus_unregister_driver'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* epoll broken [was: mmotm 2011-01-25-15-47 uploaded]
2011-01-25 23:48 mmotm 2011-01-25-15-47 uploaded akpm
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
2011-01-26 19:16 ` [PATCH -mmotm] backlight: apple_bl depends on ACPI Randy Dunlap
@ 2011-02-03 7:39 ` Jiri Slaby
2011-02-03 7:53 ` Eric Dumazet
2 siblings, 1 reply; 8+ messages in thread
From: Jiri Slaby @ 2011-02-03 7:39 UTC (permalink / raw
To: linux-kernel; +Cc: akpm, mm-commits, ML netdev, davidel
On 01/26/2011 12:48 AM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2011-01-25-15-47 has been uploaded to
Hi, the network daemons are broken here. cupsd and httpd children
segfault too often without servicing requests. It's a regression against
mmotm 2011-01-06-15-41.
It's epoll after it dies:
17836 epoll_create(8192) = 3
...
17836 accept(7, {sa_family=AF_FILE, NULL}, [2]) = 11
17836 getsockname(11, {sa_family=AF_FILE,
path="/var/run/cups/cups.sock"}, [26]) = 0
17836 setsockopt(11, SOL_TCP, TCP_NODELAY, [1], 4) = -1 EOPNOTSUPP
(Operation not supported)
17836 fcntl(11, F_GETFD) = 0
17836 fcntl(11, F_SETFD, FD_CLOEXEC) = 0
17836 epoll_ctl(3, EPOLL_CTL_ADD, 11, {EPOLLIN, {u32=379708832,
u64=140428630418848}}) = 0
17836 epoll_wait(3, {{EPOLLIN, {u32=379708832, u64=140428630418848}}},
8192, 1000) = 1
17836 recvfrom(11, "P", 1, MSG_PEEK, NULL, NULL) = 1
17836 poll([{fd=11, events=POLLIN}], 1, 10000) = 1 ([{fd=11,
revents=POLLIN}])
17836 recvfrom(11, "POST / HTTP/1.1\r\nContent-Length:"..., 2048, 0,
NULL, NULL) = 771
17836 sendto(11, "HTTP/1.1 100 Continue\r\n\r\n", 25, 0, NULL, 0) = 25
17836 epoll_wait(3, {{EPOLLIN, {u32=379708832, u64=140428630418848}},
{0, {u32=0, u64=0}} .............. {0, {u32=0, u64=0}}, ?}
0x7fb816996660, 8192, 0) = 379151968
17836 --- SIGSEGV (Segmentation fault) @ 0 (0) ---
17836 +++ killed by SIGSEGV +++
The parameter, the same as the retval, seems to be bogus.
Is it known (fixed in newer kernels)?
thanks,
--
js
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: epoll broken [was: mmotm 2011-01-25-15-47 uploaded]
2011-02-03 7:39 ` epoll broken [was: mmotm 2011-01-25-15-47 uploaded] Jiri Slaby
@ 2011-02-03 7:53 ` Eric Dumazet
2011-02-03 9:03 ` Jiri Slaby
0 siblings, 1 reply; 8+ messages in thread
From: Eric Dumazet @ 2011-02-03 7:53 UTC (permalink / raw
To: Jiri Slaby; +Cc: linux-kernel, akpm, mm-commits, ML netdev, davidel
Le jeudi 03 février 2011 à 08:39 +0100, Jiri Slaby a écrit :
> On 01/26/2011 12:48 AM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2011-01-25-15-47 has been uploaded to
>
> Hi, the network daemons are broken here. cupsd and httpd children
> segfault too often without servicing requests. It's a regression against
> mmotm 2011-01-06-15-41.
>
> It's epoll after it dies:
> 17836 epoll_create(8192) = 3
> ...
> 17836 accept(7, {sa_family=AF_FILE, NULL}, [2]) = 11
> 17836 getsockname(11, {sa_family=AF_FILE,
> path="/var/run/cups/cups.sock"}, [26]) = 0
> 17836 setsockopt(11, SOL_TCP, TCP_NODELAY, [1], 4) = -1 EOPNOTSUPP
> (Operation not supported)
> 17836 fcntl(11, F_GETFD) = 0
> 17836 fcntl(11, F_SETFD, FD_CLOEXEC) = 0
> 17836 epoll_ctl(3, EPOLL_CTL_ADD, 11, {EPOLLIN, {u32=379708832,
> u64=140428630418848}}) = 0
> 17836 epoll_wait(3, {{EPOLLIN, {u32=379708832, u64=140428630418848}}},
> 8192, 1000) = 1
> 17836 recvfrom(11, "P", 1, MSG_PEEK, NULL, NULL) = 1
> 17836 poll([{fd=11, events=POLLIN}], 1, 10000) = 1 ([{fd=11,
> revents=POLLIN}])
> 17836 recvfrom(11, "POST / HTTP/1.1\r\nContent-Length:"..., 2048, 0,
> NULL, NULL) = 771
> 17836 sendto(11, "HTTP/1.1 100 Continue\r\n\r\n", 25, 0, NULL, 0) = 25
> 17836 epoll_wait(3, {{EPOLLIN, {u32=379708832, u64=140428630418848}},
> {0, {u32=0, u64=0}} .............. {0, {u32=0, u64=0}}, ?}
> 0x7fb816996660, 8192, 0) = 379151968
> 17836 --- SIGSEGV (Segmentation fault) @ 0 (0) ---
> 17836 +++ killed by SIGSEGV +++
>
> The parameter, the same as the retval, seems to be bogus.
>
> Is it known (fixed in newer kernels)?
>
> thanks,
Yes, its known, and a fix is there : https://lkml.org/lkml/2011/1/26/121
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: epoll broken [was: mmotm 2011-01-25-15-47 uploaded]
2011-02-03 7:53 ` Eric Dumazet
@ 2011-02-03 9:03 ` Jiri Slaby
0 siblings, 0 replies; 8+ messages in thread
From: Jiri Slaby @ 2011-02-03 9:03 UTC (permalink / raw
To: Eric Dumazet; +Cc: linux-kernel, akpm, mm-commits, ML netdev, davidel
On 02/03/2011 08:53 AM, Eric Dumazet wrote:
>> {0, {u32=0, u64=0}} .............. {0, {u32=0, u64=0}}, ?}
>> 0x7fb816996660, 8192, 0) = 379151968
>> 17836 --- SIGSEGV (Segmentation fault) @ 0 (0) ---
>> 17836 +++ killed by SIGSEGV +++
>>
>> The parameter, the same as the retval, seems to be bogus.
>>
>> Is it known (fixed in newer kernels)?
>>
>> thanks,
>
> Yes, its known, and a fix is there : https://lkml.org/lkml/2011/1/26/121
Thanks, it works indeed.
--
js
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-02-03 9:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-25 23:48 mmotm 2011-01-25-15-47 uploaded akpm
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
2011-01-26 15:05 ` Davide Libenzi
2011-01-26 19:16 ` [PATCH -mmotm] backlight: apple_bl depends on ACPI Randy Dunlap
2011-01-31 22:31 ` Matthew Garrett
2011-02-03 7:39 ` epoll broken [was: mmotm 2011-01-25-15-47 uploaded] Jiri Slaby
2011-02-03 7:53 ` Eric Dumazet
2011-02-03 9:03 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).