* [PATCH V3] 2.6.34: simple IOMMU API extension to check safe interrupt remapping
@ 2010-07-02 20:56 Tom Lyon
2010-07-10 15:31 ` Joerg Roedel
2010-07-19 13:44 ` Roedel, Joerg
0 siblings, 2 replies; 3+ messages in thread
From: Tom Lyon @ 2010-07-02 20:56 UTC (permalink / raw
To: linux-kernel, kvm, iommu, chrisw, mst, dwmw2, joerg.roedel
Cc: aafabbri, scofeldm
This patch allows IOMMU users to determine whether the hardware and software
support safe, isolated interrupt remapping. Not all Intel IOMMUs have the
hardware, and the software for AMD is not there yet.
Signed-off-by: Tom Lyon <pugs@cisco.com>
---
Version 3: shorter name requested by Joerg.
Version 2: previous ifdefs not needed.
MST has convinced me that any user level driver for PCI master devices can't
be safe unless there is an IOMMU protecting the APIC MSI/MSI-X interrupt
addresses from device writes. This interrupt remapping is not present in all
Intel IOMMUs and the code for the interrupt mapping in the AMD IOMMUs is not
implemented yet.
Needed by not-yet-accepted VFIO driver.
diff -uprN linux-2.6.34/drivers/pci/intel-iommu.c iommuapi-linux-2.6.34/drivers/pci/intel-iommu.c
--- linux-2.6.34/drivers/pci/intel-iommu.c 2010-05-16 14:17:36.000000000 -0700
+++ iommuapi-linux-2.6.34/drivers/pci/intel-iommu.c 2010-07-02 12:39:19.000000000 -0700
@@ -3705,6 +3705,8 @@ static int intel_iommu_domain_has_cap(st
if (cap == IOMMU_CAP_CACHE_COHERENCY)
return dmar_domain->iommu_snooping;
+ if (cap == IOMMU_CAP_INTR_REMAP)
+ return intr_remapping_enabled;
return 0;
}
diff -uprN linux-2.6.34/include/linux/iommu.h iommuapi-linux-2.6.34/include/linux/iommu.h
--- linux-2.6.34/include/linux/iommu.h 2010-05-16 14:17:36.000000000 -0700
+++ iommuapi-linux-2.6.34/include/linux/iommu.h 2010-07-02 12:38:45.000000000 -0700
@@ -30,6 +30,7 @@ struct iommu_domain {
};
#define IOMMU_CAP_CACHE_COHERENCY 0x1
+#define IOMMU_CAP_INTR_REMAP 0x2 /* isolates device intrs */
struct iommu_ops {
int (*domain_init)(struct iommu_domain *domain);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] 2.6.34: simple IOMMU API extension to check safe interrupt remapping
2010-07-02 20:56 [PATCH V3] 2.6.34: simple IOMMU API extension to check safe interrupt remapping Tom Lyon
@ 2010-07-10 15:31 ` Joerg Roedel
2010-07-19 13:44 ` Roedel, Joerg
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2010-07-10 15:31 UTC (permalink / raw
To: Tom Lyon
Cc: linux-kernel, kvm, iommu, chrisw, mst, dwmw2, joerg.roedel,
aafabbri, scofeldm
On Fri, Jul 02, 2010 at 01:56:14PM -0700, Tom Lyon wrote:
> This patch allows IOMMU users to determine whether the hardware and software
> support safe, isolated interrupt remapping. Not all Intel IOMMUs have the
> hardware, and the software for AMD is not there yet.
> Signed-off-by: Tom Lyon <pugs@cisco.com>
> ---
> Version 3: shorter name requested by Joerg.
> Version 2: previous ifdefs not needed.
Thanks. I apply it when I am back in office (aroun July 19th).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] 2.6.34: simple IOMMU API extension to check safe interrupt remapping
2010-07-02 20:56 [PATCH V3] 2.6.34: simple IOMMU API extension to check safe interrupt remapping Tom Lyon
2010-07-10 15:31 ` Joerg Roedel
@ 2010-07-19 13:44 ` Roedel, Joerg
1 sibling, 0 replies; 3+ messages in thread
From: Roedel, Joerg @ 2010-07-19 13:44 UTC (permalink / raw
To: Tom Lyon
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
iommu@lists.linux-foundation.org, chrisw@sous-sol.org,
mst@redhat.com, dwmw2@infradead.org, aafabbri@cisco.com,
scofeldm@cisco.com
On Fri, Jul 02, 2010 at 04:56:14PM -0400, Tom Lyon wrote:
> This patch allows IOMMU users to determine whether the hardware and software
> support safe, isolated interrupt remapping. Not all Intel IOMMUs have the
> hardware, and the software for AMD is not there yet.
> Signed-off-by: Tom Lyon <pugs@cisco.com>
Applied, thanks.
--
Joerg Roedel - AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-19 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-02 20:56 [PATCH V3] 2.6.34: simple IOMMU API extension to check safe interrupt remapping Tom Lyon
2010-07-10 15:31 ` Joerg Roedel
2010-07-19 13:44 ` Roedel, Joerg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).