From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
dhowells@redhat.com, akpm@linux-foundation.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used
Date: Wed, 30 Sep 2009 12:28:23 +0100 [thread overview]
Message-ID: <20090930122823.685d4e7e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <29895.1254306000@redhat.com>
O> Also, does it matter if someone issues TIOCGPTN on a legacy pty master? There
> is a number in tty->index that can be returned. If it can, then
Not a lot - providing someone isn't using it as a way to tell pty types
apart (which I have seen done in example code)
> pty_bsd_ioctl() can be merged with pty_unix98_ioctl(), and possibly both
> ioctls can be given to the generic tty ioctl handling
I would keep
if (type == FOO)
as far away from the generic tty ioctl code as possible. It's already
convoluted and complex with zillions of ioctl calls. Separating out lots
of the console and other ioctls properly cleaned it up no end and going
backwards would be a bad mistake.
next prev parent reply other threads:[~2009-09-30 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 13:53 [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used David Howells
2009-09-28 14:16 ` Alan Cox
2009-09-28 14:55 ` Linus Torvalds
2009-09-29 15:55 ` David Howells
2009-09-29 16:23 ` Linus Torvalds
2009-09-29 16:38 ` Linus Torvalds
2009-09-29 18:40 ` David Howells
2009-09-29 22:39 ` Alan Cox
2009-09-30 10:20 ` David Howells
2009-09-30 11:28 ` Alan Cox [this message]
2009-09-28 14:55 ` David Howells
2009-09-28 15:25 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930122823.685d4e7e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).