* x86: Define ARCH_WANT_FRAME_POINTERS
@ 2009-01-16 18:23 Jeff Mahoney
2009-01-16 22:41 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Mahoney @ 2009-01-16 18:23 UTC (permalink / raw
To: Ingo Molnar; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List
Commit da4276b8299a6544dc41ac2485d3ffca5811b3fb changed a dependency
for FRAME_POINTER from X86 to ARCH_WANT_FRAME_POINTERS, but didn't
actually define it.
This patch adds the definition for ARCH_WANT_FRAME_POINTERS. Without it,
FRAME_POINTER can't be enabled on x86.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
lib/Kconfig.debug | 6 ++++++
1 file changed, 6 insertions(+)
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -570,6 +570,12 @@ config DEBUG_NOTIFIERS
This is a relatively cheap check but if you care about maximum
performance, say N.
+config ARCH_WANT_FRAME_POINTERS
+ bool
+ help
+ Select this config option from the architecture Kconfig, if it
+ it is preferred to always enable frame pointers on the architecture.
+
config FRAME_POINTER
bool "Compile the kernel with frame pointers"
depends on DEBUG_KERNEL && \
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: x86: Define ARCH_WANT_FRAME_POINTERS
2009-01-16 18:23 x86: Define ARCH_WANT_FRAME_POINTERS Jeff Mahoney
@ 2009-01-16 22:41 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-01-16 22:41 UTC (permalink / raw
To: Jeff Mahoney; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List
* Jeff Mahoney <jeffm@suse.com> wrote:
> Commit da4276b8299a6544dc41ac2485d3ffca5811b3fb changed a dependency
> for FRAME_POINTER from X86 to ARCH_WANT_FRAME_POINTERS, but didn't
> actually define it.
>
> This patch adds the definition for ARCH_WANT_FRAME_POINTERS. Without it,
> FRAME_POINTER can't be enabled on x86.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
>
> lib/Kconfig.debug | 6 ++++++
> 1 file changed, 6 insertions(+)
Yes - doh! :-)
Applied to tip/x86/urgent, thanks Jeff!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-16 22:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-16 18:23 x86: Define ARCH_WANT_FRAME_POINTERS Jeff Mahoney
2009-01-16 22:41 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).