* [PATCH] drm/radeon: radeon_enable_vblank should return negative error
@ 2008-05-11 19:49 Marcin Slusarz
2008-05-13 16:19 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2008-05-11 19:49 UTC (permalink / raw
To: LKML; +Cc: Dave Airlie, Jesse Barnes
radeon_enable_vblank <- drm_vblank_get <- drm_wait_vblank
and drm_wait_vblank returns negative values on error
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
---
compile tested only
---
drivers/char/drm/radeon_irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/drm/radeon_irq.c b/drivers/char/drm/radeon_irq.c
--- a/drivers/char/drm/radeon_irq.c
+++ b/drivers/char/drm/radeon_irq.c
@@ -59,7 +59,7 @@ int radeon_enable_vblank(struct drm_device *dev, int crtc)
default:
DRM_ERROR("tried to enable vblank on non-existent crtc %d\n",
crtc);
- return EINVAL;
+ return -EINVAL;
}
return 0;
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/radeon: radeon_enable_vblank should return negative error
2008-05-11 19:49 [PATCH] drm/radeon: radeon_enable_vblank should return negative error Marcin Slusarz
@ 2008-05-13 16:19 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2008-05-13 16:19 UTC (permalink / raw
To: Marcin Slusarz; +Cc: LKML, Dave Airlie, Andrew Morton
On Sunday, May 11, 2008 12:49 pm Marcin Slusarz wrote:
> radeon_enable_vblank <- drm_vblank_get <- drm_wait_vblank
> and drm_wait_vblank returns negative values on error
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> compile tested only
Looks good, Marcin. Andrew should probably just push it upstream.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Thanks,
Jesse
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-13 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 19:49 [PATCH] drm/radeon: radeon_enable_vblank should return negative error Marcin Slusarz
2008-05-13 16:19 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).