LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status
@ 2016-11-23 12:38 Vitaly Kuznetsov
  2016-11-23 16:17 ` Boris Ostrovsky
  2016-11-30  6:46 ` Juergen Gross
  0 siblings, 2 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2016-11-23 12:38 UTC (permalink / raw
  To: xen-devel; +Cc: linux-kernel, Boris Ostrovsky, Juergen Gross, David Vrabel

EVTCHNOP_status hypercall returns Xen's idea of vcpu id so we need to
compare it against xen_vcpu_id mapping, not the Linux cpu id.

Suggested-by: Radim Krcmar <rkrcmar@redhat.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/xen/events/events_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 9ecfcdc..137bd0e 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -948,7 +948,7 @@ static int find_virq(unsigned int virq, unsigned int cpu)
 			continue;
 		if (status.status != EVTCHNSTAT_virq)
 			continue;
-		if (status.u.virq == virq && status.vcpu == cpu) {
+		if (status.u.virq == virq && status.vcpu == xen_vcpu_nr(cpu)) {
 			rc = port;
 			break;
 		}
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status
  2016-11-23 12:38 [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status Vitaly Kuznetsov
@ 2016-11-23 16:17 ` Boris Ostrovsky
  2016-11-30  6:46 ` Juergen Gross
  1 sibling, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2016-11-23 16:17 UTC (permalink / raw
  To: Vitaly Kuznetsov, xen-devel; +Cc: linux-kernel, Juergen Gross, David Vrabel

On 11/23/2016 07:38 AM, Vitaly Kuznetsov wrote:
> EVTCHNOP_status hypercall returns Xen's idea of vcpu id so we need to
> compare it against xen_vcpu_id mapping, not the Linux cpu id.
>
> Suggested-by: Radim Krcmar <rkrcmar@redhat.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>


> ---
>  drivers/xen/events/events_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
> index 9ecfcdc..137bd0e 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -948,7 +948,7 @@ static int find_virq(unsigned int virq, unsigned int cpu)
>  			continue;
>  		if (status.status != EVTCHNSTAT_virq)
>  			continue;
> -		if (status.u.virq == virq && status.vcpu == cpu) {
> +		if (status.u.virq == virq && status.vcpu == xen_vcpu_nr(cpu)) {
>  			rc = port;
>  			break;
>  		}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status
  2016-11-23 12:38 [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status Vitaly Kuznetsov
  2016-11-23 16:17 ` Boris Ostrovsky
@ 2016-11-30  6:46 ` Juergen Gross
  1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2016-11-30  6:46 UTC (permalink / raw
  To: Vitaly Kuznetsov, xen-devel; +Cc: linux-kernel, Boris Ostrovsky, David Vrabel

On 23/11/16 13:38, Vitaly Kuznetsov wrote:
> EVTCHNOP_status hypercall returns Xen's idea of vcpu id so we need to
> compare it against xen_vcpu_id mapping, not the Linux cpu id.
> 
> Suggested-by: Radim Krcmar <rkrcmar@redhat.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Applied to xen/tip.git for-linus-4.10


Juergen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-30  6:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 12:38 [PATCH KERNEL] xen/events: use xen_vcpu_id mapping for EVTCHNOP_status Vitaly Kuznetsov
2016-11-23 16:17 ` Boris Ostrovsky
2016-11-30  6:46 ` Juergen Gross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).