LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH][v2] PM / sleep: Increase default DPM watchdog timeout to 120
@ 2016-08-19  4:37 Chen Yu
  2016-08-19  7:19 ` Pavel Machek
  0 siblings, 1 reply; 3+ messages in thread
From: Chen Yu @ 2016-08-19  4:37 UTC (permalink / raw
  To: linux-pm; +Cc: Rafael J. Wysocki, Pavel Machek, linux-kernel, Chen Yu

Recently we have a new report that, the harddisk can not
resume on time due to firmware issues, and got a kernel
panic because of DPM watchdog timeout. So adjust the
default timeout from 60 to 120 to survive on this platform,
and make DPM_WATCHDOG depending on EXPERT.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=117971
Suggested-by: Pavel Machek <pavel@ucw.cz>
Suggested-by: Rafael J. Wysocki <rafael@kernel.org>
Reported-by: Higuita <higuita@gmx.net>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
 kernel/power/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index 68d3ebc..e8517b6 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -186,7 +186,7 @@ config PM_SLEEP_DEBUG
 
 config DPM_WATCHDOG
 	bool "Device suspend/resume watchdog"
-	depends on PM_DEBUG && PSTORE
+	depends on PM_DEBUG && PSTORE && EXPERT
 	---help---
 	  Sets up a watchdog timer to capture drivers that are
 	  locked up attempting to suspend/resume a device.
@@ -197,7 +197,7 @@ config DPM_WATCHDOG
 config DPM_WATCHDOG_TIMEOUT
 	int "Watchdog timeout in seconds"
 	range 1 120
-	default 60
+	default 120
 	depends on DPM_WATCHDOG
 
 config PM_TRACE
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH][v2] PM / sleep: Increase default DPM watchdog timeout to 120
  2016-08-19  4:37 [PATCH][v2] PM / sleep: Increase default DPM watchdog timeout to 120 Chen Yu
@ 2016-08-19  7:19 ` Pavel Machek
  2016-09-14  1:05   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2016-08-19  7:19 UTC (permalink / raw
  To: Chen Yu; +Cc: linux-pm, Rafael J. Wysocki, linux-kernel

On Fri 2016-08-19 12:37:23, Chen Yu wrote:
> Recently we have a new report that, the harddisk can not
> resume on time due to firmware issues, and got a kernel
> panic because of DPM watchdog timeout. So adjust the
> default timeout from 60 to 120 to survive on this platform,
> and make DPM_WATCHDOG depending on EXPERT.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=117971

Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks!
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][v2] PM / sleep: Increase default DPM watchdog timeout to 120
  2016-08-19  7:19 ` Pavel Machek
@ 2016-09-14  1:05   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-09-14  1:05 UTC (permalink / raw
  To: Pavel Machek, Chen Yu; +Cc: linux-pm, linux-kernel

On Friday, August 19, 2016 09:19:55 AM Pavel Machek wrote:
> On Fri 2016-08-19 12:37:23, Chen Yu wrote:
> > Recently we have a new report that, the harddisk can not
> > resume on time due to firmware issues, and got a kernel
> > panic because of DPM watchdog timeout. So adjust the
> > default timeout from 60 to 120 to survive on this platform,
> > and make DPM_WATCHDOG depending on EXPERT.
> > 
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=117971
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Patch applied.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-14  0:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-19  4:37 [PATCH][v2] PM / sleep: Increase default DPM watchdog timeout to 120 Chen Yu
2016-08-19  7:19 ` Pavel Machek
2016-09-14  1:05   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).