* [PATCH v2] ll_temac: Reset dma descriptors indexes on ndo_open
@ 2013-10-01 6:17 Ricardo Ribalda Delgado
2013-10-01 16:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda Delgado @ 2013-10-01 6:17 UTC (permalink / raw
To: David S. Miller, Joe Perches, Jingoo Han, Greg Kroah-Hartman,
Bill Pemberton, netdev, linux-kernel
Cc: Ricardo Ribalda Delgado
The dma descriptors indexes are only initialized on the probe function.
If a packet is on the buffer when temac_stop is called, the dma
descriptors indexes can be left on a incorrect state where no other
package can be sent.
So an interface could be left in an usable state after ifdow/ifup.
This patch makes sure that the descriptors indexes are in a proper
status when the device is open.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
v2: As suggested by David Miller:
- Remove unneded app0=0 on dma descriptors
- Move all code to temac_dma_bd_init
- Fix changelog
drivers/net/ethernet/xilinx/ll_temac_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index b88121f..0029148 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -297,6 +297,12 @@ static int temac_dma_bd_init(struct net_device *ndev)
lp->rx_bd_p + (sizeof(*lp->rx_bd_v) * (RX_BD_NUM - 1)));
lp->dma_out(lp, TX_CURDESC_PTR, lp->tx_bd_p);
+ /* Init descriptor indexes */
+ lp->tx_bd_ci = 0;
+ lp->tx_bd_next = 0;
+ lp->tx_bd_tail = 0;
+ lp->rx_bd_ci = 0;
+
return 0;
out:
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ll_temac: Reset dma descriptors indexes on ndo_open
2013-10-01 6:17 [PATCH v2] ll_temac: Reset dma descriptors indexes on ndo_open Ricardo Ribalda Delgado
@ 2013-10-01 16:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-01 16:32 UTC (permalink / raw
To: ricardo.ribalda; +Cc: joe, jg1.han, gregkh, wfp5p, netdev, linux-kernel
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Date: Tue, 1 Oct 2013 08:17:10 +0200
> The dma descriptors indexes are only initialized on the probe function.
>
> If a packet is on the buffer when temac_stop is called, the dma
> descriptors indexes can be left on a incorrect state where no other
> package can be sent.
>
> So an interface could be left in an usable state after ifdow/ifup.
>
> This patch makes sure that the descriptors indexes are in a proper
> status when the device is open.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-01 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01 6:17 [PATCH v2] ll_temac: Reset dma descriptors indexes on ndo_open Ricardo Ribalda Delgado
2013-10-01 16:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).