* [PATCH net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void
@ 2024-04-09 9:12 Uwe Kleine-König
2024-04-09 9:20 ` Herve Codina
2024-04-11 2:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2024-04-09 9:12 UTC (permalink / raw
To: Herve Codina
Cc: Andy Shevchenko, netdev, Eric Dumazet, kernel, Jakub Kicinski,
Paolo Abeni, linuxppc-dev, David S. Miller
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
the drivers below of drivers/net were already converted to struct
platform_driver::remove_new during the v6.9-rc1 development cycle. This
driver was added for v6.9-rc1 and so missed during my conversion.
There are still more drivers to be converted, so there is from my side
no need to get this into v6.9, but the next merge window would be nice.
Best regards
Uwe
drivers/net/wan/fsl_qmc_hdlc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c
index f69b1f579a0c..c5e7ca793c43 100644
--- a/drivers/net/wan/fsl_qmc_hdlc.c
+++ b/drivers/net/wan/fsl_qmc_hdlc.c
@@ -765,15 +765,13 @@ static int qmc_hdlc_probe(struct platform_device *pdev)
return ret;
}
-static int qmc_hdlc_remove(struct platform_device *pdev)
+static void qmc_hdlc_remove(struct platform_device *pdev)
{
struct qmc_hdlc *qmc_hdlc = platform_get_drvdata(pdev);
unregister_hdlc_device(qmc_hdlc->netdev);
free_netdev(qmc_hdlc->netdev);
qmc_hdlc_framer_exit(qmc_hdlc);
-
- return 0;
}
static const struct of_device_id qmc_hdlc_id_table[] = {
@@ -788,7 +786,7 @@ static struct platform_driver qmc_hdlc_driver = {
.of_match_table = qmc_hdlc_id_table,
},
.probe = qmc_hdlc_probe,
- .remove = qmc_hdlc_remove,
+ .remove_new = qmc_hdlc_remove,
};
module_platform_driver(qmc_hdlc_driver);
base-commit: 11cb68ad52ac78c81e33b806b531f097e68edfa2
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void
2024-04-09 9:12 [PATCH net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void Uwe Kleine-König
@ 2024-04-09 9:20 ` Herve Codina
2024-04-11 2:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Herve Codina @ 2024-04-09 9:20 UTC (permalink / raw
To: Uwe Kleine-König
Cc: Andy Shevchenko, netdev, Eric Dumazet, kernel, Jakub Kicinski,
Paolo Abeni, linuxppc-dev, David S. Miller
On Tue, 9 Apr 2024 11:12:04 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> the drivers below of drivers/net were already converted to struct
> platform_driver::remove_new during the v6.9-rc1 development cycle. This
> driver was added for v6.9-rc1 and so missed during my conversion.
>
> There are still more drivers to be converted, so there is from my side
> no need to get this into v6.9, but the next merge window would be nice.
>
> Best regards
> Uwe
>
> drivers/net/wan/fsl_qmc_hdlc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void
2024-04-09 9:12 [PATCH net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void Uwe Kleine-König
2024-04-09 9:20 ` Herve Codina
@ 2024-04-11 2:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-11 2:40 UTC (permalink / raw
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: andriy.shevchenko, herve.codina, netdev, edumazet, kernel, kuba,
pabeni, linuxppc-dev, davem
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 9 Apr 2024 11:12:04 +0200 you wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> [...]
Here is the summary with links:
- [net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/07409cf72844
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-11 2:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-09 9:12 [PATCH net-next] net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void Uwe Kleine-König
2024-04-09 9:20 ` Herve Codina
2024-04-11 2:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).