From: John Garry <john.g.garry@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
chandan.babu@oracle.com, djwong@kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: Clear W=1 warning in xfs_iwalk_run_callbacks():
Date: Wed, 1 May 2024 09:10:22 +0100 [thread overview]
Message-ID: <c0fe3156-d2b6-4a23-8d0a-de069b079eda@oracle.com> (raw)
In-Reply-To: <ZirnfaFFqqyaUdQv@dread.disaster.area>
On 26/04/2024 00:30, Dave Chinner wrote:
> Can this be written differently that has no need to access the
> on-disk AGF at all?
>
> Yes, it can:
>
> ASSERT(xfs_verify_agbno(args->pag, acur->rec_bno + acur->rec_len));
>
> or:
>
> ASSERT(xfs_verify_agbext(args->pag, acur->rec_bno, acur->rec_len));
>
> The latter is better, as it verifies both the start and the end of
> the extent are within the bounds of the AG and catches overflows...
Fine.
I'll send a single patch to convert both instances in xfs_alloc.c and
tag you as "Originally-by" in the patch. Let me know if not ok.
Thanks,
John
next prev parent reply other threads:[~2024-05-01 8:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 12:08 [PATCH 0/2] xfs: Clear a couple of W=1 warnings John Garry
2024-04-25 12:08 ` [PATCH 1/2] xfs: Clear W=1 warning in xfs_iwalk_run_callbacks(): John Garry
2024-04-25 12:17 ` Christoph Hellwig
2024-04-25 13:24 ` John Garry
2024-04-25 13:30 ` Christoph Hellwig
2024-04-25 13:33 ` John Garry
2024-04-25 15:37 ` John Garry
2024-04-25 16:17 ` Darrick J. Wong
2024-04-25 23:30 ` Dave Chinner
2024-04-26 6:09 ` Christoph Hellwig
2024-05-01 8:10 ` John Garry [this message]
2024-04-25 12:08 ` [PATCH 2/2] xfs: Clear W=1 warning in xfs_trans_unreserve_and_mod_sb(): John Garry
2024-04-25 12:18 ` Christoph Hellwig
2024-04-25 13:35 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0fe3156-d2b6-4a23-8d0a-de069b079eda@oracle.com \
--to=john.g.garry@oracle.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).