From: "Darrick J. Wong" <djwong@kernel.org>
To: Allison Henderson <allison.henderson@oracle.com>,
catherine.hoang@oracle.com, hch@lst.de,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 27/32] xfs: Add parent pointer ioctls
Date: Fri, 12 Apr 2024 10:39:57 -0700 [thread overview]
Message-ID: <20240412173957.GB11948@frogsfrogsfrogs> (raw)
In-Reply-To: <171270970008.3631889.8274576756376203769.stgit@frogsfrogsfrogs>
On Tue, Apr 09, 2024 at 06:00:33PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This patch adds a pair of new file ioctls to retrieve the parent pointer
> of a given inode. They both return the same results, but one operates
> on the file descriptor passed to ioctl() whereas the other allows the
> caller to specify a file handle for which the caller wants results.
>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> [djwong: adjust to new ondisk format, split ioctls]
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_fs.h | 73 ++++++++++++
> fs/xfs/libxfs/xfs_ondisk.h | 5 +
> fs/xfs/libxfs/xfs_parent.c | 35 ++++++
> fs/xfs/libxfs/xfs_parent.h | 5 +
> fs/xfs/xfs_handle.c | 259 ++++++++++++++++++++++++++++++++++++++++++++
> fs/xfs/xfs_handle.h | 5 +
> fs/xfs/xfs_ioctl.c | 6 +
> fs/xfs/xfs_trace.c | 1
> fs/xfs/xfs_trace.h | 92 ++++++++++++++++
> 9 files changed, 480 insertions(+), 1 deletion(-)
>
>
> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> index 51aa4774f57a2..fa28c18e521bf 100644
> --- a/fs/xfs/libxfs/xfs_fs.h
> +++ b/fs/xfs/libxfs/xfs_fs.h
> @@ -840,6 +840,77 @@ struct xfs_commit_range {
> XFS_EXCHANGE_RANGE_DRY_RUN | \
> XFS_EXCHANGE_RANGE_FILE1_WRITTEN)
>
> +/* Iterating parent pointers of files. */
> +
> +/* target was the root directory */
> +#define XFS_GETPARENTS_OFLAG_ROOT (1U << 0)
> +
> +/* Cursor is done iterating pptrs */
> +#define XFS_GETPARENTS_OFLAG_DONE (1U << 1)
> +
> +#define XFS_GETPARENTS_OFLAGS_ALL (XFS_GETPARENTS_OFLAG_ROOT | \
> + XFS_GETPARENTS_OFLAG_DONE)
> +
> +#define XFS_GETPARENTS_IFLAGS_ALL (0)
> +
> +struct xfs_getparents_rec {
> + struct xfs_handle gpr_parent; /* Handle to parent */
> + __u16 gpr_reclen; /* Length of entire record */
> + char gpr_name[]; /* Null-terminated filename */
> +} __packed;
> +
> +/* Iterate through this file's directory parent pointers */
> +struct xfs_getparents {
> + /*
> + * Structure to track progress in iterating the parent pointers.
> + * Must be initialized to zeroes before the first ioctl call, and
> + * not touched by callers after that.
> + */
> + struct xfs_attrlist_cursor gp_cursor;
> +
> + /* Input flags: XFS_GETPARENTS_IFLAG* */
> + __u16 gp_iflags;
> +
> + /* Output flags: XFS_GETPARENTS_OFLAG* */
> + __u16 gp_oflags;
> +
> + /* Size of the gp_buffer in bytes */
> + __u32 gp_bufsize;
> +
> + /* Must be set to zero */
> + __u64 __pad;
> +
> + /* Pointer to a buffer in which to place xfs_getparents_rec */
> + __u64 gp_buffer;
> +};
> +
> +static inline struct xfs_getparents_rec *
> +xfs_getparents_first_rec(struct xfs_getparents *gp)
> +{
> + return (struct xfs_getparents_rec *)(uintptr_t)gp->gp_buffer;
> +}
> +
> +static inline struct xfs_getparents_rec *
> +xfs_getparents_next_rec(struct xfs_getparents *gp,
> + struct xfs_getparents_rec *gpr)
> +{
> + char *next = ((char *)gpr + gpr->gpr_reclen);
> + char *end = (char *)(uintptr_t)(gp->gp_buffer + gp->gp_bufsize);
> +
> + if (next >= end)
> + return NULL;
> +
> + return (struct xfs_getparents_rec *)next;
> +}
> +
> +/* Iterate through this file handle's directory parent pointers. */
> +struct xfs_getparents_by_handle {
> + /* Handle to file whose parents we want. */
> + struct xfs_handle gph_handle;
> +
> + struct xfs_getparents gph_request;
> +};
> +
> /*
> * ioctl commands that are used by Linux filesystems
> */
> @@ -875,6 +946,8 @@ struct xfs_commit_range {
> /* XFS_IOC_GETFSMAP ------ hoisted 59 */
> #define XFS_IOC_SCRUB_METADATA _IOWR('X', 60, struct xfs_scrub_metadata)
> #define XFS_IOC_AG_GEOMETRY _IOWR('X', 61, struct xfs_ag_geometry)
> +#define XFS_IOC_GETPARENTS _IOWR('X', 62, struct xfs_getparents)
> +#define XFS_IOC_GETPARENTS_BY_HANDLE _IOWR('X', 63, struct xfs_getparents_by_handle)
>
> /*
> * ioctl commands that replace IRIX syssgi()'s
> diff --git a/fs/xfs/libxfs/xfs_ondisk.h b/fs/xfs/libxfs/xfs_ondisk.h
> index 25952ef584eee..34c972113d997 100644
> --- a/fs/xfs/libxfs/xfs_ondisk.h
> +++ b/fs/xfs/libxfs/xfs_ondisk.h
> @@ -156,6 +156,11 @@ xfs_check_ondisk_structs(void)
> XFS_CHECK_OFFSET(struct xfs_efi_log_format_32, efi_extents, 16);
> XFS_CHECK_OFFSET(struct xfs_efi_log_format_64, efi_extents, 16);
>
> + /* parent pointer ioctls */
> + XFS_CHECK_STRUCT_SIZE(struct xfs_getparents_rec, 26);
> + XFS_CHECK_STRUCT_SIZE(struct xfs_getparents, 40);
> + XFS_CHECK_STRUCT_SIZE(struct xfs_getparents_by_handle, 64);
> +
> /*
> * The v5 superblock format extended several v4 header structures with
> * additional data. While new fields are only accessible on v5
> diff --git a/fs/xfs/libxfs/xfs_parent.c b/fs/xfs/libxfs/xfs_parent.c
> index 86c808157294e..db8cfad0b968e 100644
> --- a/fs/xfs/libxfs/xfs_parent.c
> +++ b/fs/xfs/libxfs/xfs_parent.c
> @@ -259,3 +259,38 @@ xfs_parent_replacename(
> xfs_attr_defer_parent(&ppargs->args, XFS_ATTR_DEFER_REPLACE);
> return 0;
> }
> +
> +/*
> + * Extract parent pointer information from any xattr into @parent_ino/gen.
> + * The last two parameters can be NULL pointers.
> + *
> + * Returns 1 if this is a valid parent pointer; 0 if this is not a parent
> + * pointer xattr at all; or -EFSCORRUPTED for garbage.
> + */
> +int
> +xfs_parent_from_xattr(
> + struct xfs_mount *mp,
> + unsigned int attr_flags,
> + const unsigned char *name,
> + unsigned int namelen,
> + const void *value,
> + unsigned int valuelen,
> + xfs_ino_t *parent_ino,
> + uint32_t *parent_gen)
> +{
> + const struct xfs_parent_rec *rec = value;
> +
> + if (!(attr_flags & XFS_ATTR_PARENT))
> + return 0;
> +
> + if (!xfs_parent_namecheck(attr_flags, name, namelen))
> + return -EFSCORRUPTED;
> + if (!xfs_parent_valuecheck(mp, value, valuelen))
> + return -EFSCORRUPTED;
> +
> + if (parent_ino)
> + *parent_ino = be64_to_cpu(rec->p_ino);
> + if (parent_gen)
> + *parent_gen = be32_to_cpu(rec->p_gen);
> + return 1;
> +}
> diff --git a/fs/xfs/libxfs/xfs_parent.h b/fs/xfs/libxfs/xfs_parent.h
> index 768633b313671..3003ab496f854 100644
> --- a/fs/xfs/libxfs/xfs_parent.h
> +++ b/fs/xfs/libxfs/xfs_parent.h
> @@ -91,4 +91,9 @@ int xfs_parent_replacename(struct xfs_trans *tp,
> struct xfs_inode *new_dp, const struct xfs_name *new_name,
> struct xfs_inode *child);
>
> +int xfs_parent_from_xattr(struct xfs_mount *mp, unsigned int attr_flags,
> + const unsigned char *name, unsigned int namelen,
> + const void *value, unsigned int valuelen,
> + xfs_ino_t *parent_ino, uint32_t *parent_gen);
> +
> #endif /* __XFS_PARENT_H__ */
> diff --git a/fs/xfs/xfs_handle.c b/fs/xfs/xfs_handle.c
> index abeca486a2c91..833b0d7d8bea1 100644
> --- a/fs/xfs/xfs_handle.c
> +++ b/fs/xfs/xfs_handle.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (c) 2000-2005 Silicon Graphics, Inc.
> + * Copyright (c) 2022-2024 Oracle.
> * All rights reserved.
> */
> #include "xfs.h"
> @@ -645,3 +646,261 @@ xfs_attrmulti_by_handle(
> dput(dentry);
> return error;
> }
> +
> +struct xfs_getparents_ctx {
> + struct xfs_attr_list_context context;
> + struct xfs_getparents_by_handle gph;
> +
> + /* File to target */
> + struct xfs_inode *ip;
> +
> + /* Internal buffer where we format records */
> + void *krecords;
> +
> + /* Last record filled out */
> + struct xfs_getparents_rec *lastrec;
> +
> + unsigned int count;
> +};
> +
> +static inline unsigned int
> +xfs_getparents_rec_sizeof(
> + unsigned int namelen)
> +{
> + return round_up(sizeof(struct xfs_getparents_rec) + namelen + 1,
> + sizeof(uint32_t));
> +}
> +
> +static void
> +xfs_getparents_put_listent(
> + struct xfs_attr_list_context *context,
> + int flags,
> + unsigned char *name,
> + int namelen,
> + void *value,
> + int valuelen)
> +{
> + struct xfs_getparents_ctx *gpx =
> + container_of(context, struct xfs_getparents_ctx, context);
> + struct xfs_inode *ip = context->dp;
> + struct xfs_mount *mp = ip->i_mount;
> + struct xfs_getparents *gp = &gpx->gph.gph_request;
> + struct xfs_getparents_rec *gpr = gpx->krecords + context->firstu;
> + unsigned short reclen = xfs_getparents_rec_sizeof(namelen);
> + xfs_ino_t ino;
> + uint32_t gen;
> + int ret;
> +
> + ret = xfs_parent_from_xattr(mp, flags, name, namelen, value, valuelen,
> + &ino, &gen);
> + if (ret < 0) {
> + xfs_inode_mark_sick(ip, XFS_SICK_INO_PARENT);
> + context->seen_enough = -EFSCORRUPTED;
> + return;
> + }
> + if (ret != 1)
> + return;
> +
> + /*
> + * We found a parent pointer, but we've filled up the buffer. Signal
> + * to the caller that we did /not/ reach the end of the parent pointer
> + * recordset.
> + */
> + if (context->firstu > context->bufsize - reclen) {
> + context->seen_enough = 1;
> + return;
> + }
> +
> + /* Format the parent pointer directly into the caller buffer. */
> + gpr->gpr_reclen = reclen;
> + xfs_filehandle_init(mp, ino, gen, &gpr->gpr_parent);
> + memcpy(gpr->gpr_name, name, namelen);
> + gpr->gpr_name[namelen] = 0;
> +
> + trace_xfs_getparents_put_listent(ip, gp, context, gpr);
> +
> + context->firstu += reclen;
> + gpx->count++;
> + gpx->lastrec = gpr;
> +}
> +
> +/* Expand the last record to fill the rest of the caller's buffer. */
> +static inline void
> +xfs_getparents_expand_lastrec(
> + struct xfs_getparents_ctx *gpx)
> +{
> + struct xfs_getparents *gp = &gpx->gph.gph_request;
> + struct xfs_getparents_rec *gpr = gpx->lastrec;
> +
> + if (!gpx->lastrec)
> + gpr = gpx->krecords;
> +
> + gpr->gpr_reclen = gp->gp_bufsize - ((void *)gpr - gpx->krecords);
> +
> + trace_xfs_getparents_expand_lastrec(gpx->ip, gp, &gpx->context, gpr);
> +}
> +
> +static inline void __user *u64_to_uptr(u64 val)
> +{
> + return (void __user *)(uintptr_t)val;
> +}
> +
> +/* Retrieve the parent pointers for a given inode. */
> +STATIC int
> +xfs_getparents(
> + struct xfs_getparents_ctx *gpx)
> +{
> + struct xfs_getparents *gp = &gpx->gph.gph_request;
> + struct xfs_inode *ip = gpx->ip;
> + struct xfs_mount *mp = ip->i_mount;
> + size_t bufsize;
> + int error;
> +
> + /* Check size of buffer requested by user */
> + if (gp->gp_bufsize > XFS_XATTR_LIST_MAX)
> + return -ENOMEM;
> + if (gp->gp_bufsize < xfs_getparents_rec_sizeof(1))
> + return -EINVAL;
> +
> + if (gp->gp_iflags & ~XFS_GETPARENTS_IFLAGS_ALL)
> + return -EINVAL;
> + if (gp->__pad)
> + return -EINVAL;
> +
> + bufsize = round_down(gp->gp_bufsize, sizeof(uint32_t));
> + gpx->krecords = kvzalloc(bufsize, GFP_KERNEL);
> + if (!gpx->krecords) {
> + bufsize = min(bufsize, PAGE_SIZE);
> + gpx->krecords = kvzalloc(bufsize, GFP_KERNEL);
> + if (!gpx->krecords)
> + return -ENOMEM;
> + }
> +
> + gpx->context.dp = ip;
> + gpx->context.resynch = 1;
> + gpx->context.put_listent = xfs_getparents_put_listent;
> + gpx->context.bufsize = bufsize;
> + /* firstu is used to track the bytes filled in the buffer */
> + gpx->context.firstu = 0;
> +
> + /* Copy the cursor provided by caller */
> + memcpy(&gpx->context.cursor, &gp->gp_cursor,
> + sizeof(struct xfs_attrlist_cursor));
> + gpx->count = 0;
> + gp->gp_oflags = 0;
> +
> + trace_xfs_getparents_begin(ip, gp, &gpx->context.cursor);
> +
> + error = xfs_attr_list(&gpx->context);
> + if (error)
> + goto out_free_buf;
> + if (gpx->context.seen_enough < 0) {
> + error = gpx->context.seen_enough;
> + goto out_free_buf;
> + }
> + xfs_getparents_expand_lastrec(gpx);
> +
> + /* Update the caller with the current cursor position */
> + memcpy(&gp->gp_cursor, &gpx->context.cursor,
> + sizeof(struct xfs_attrlist_cursor));
> +
> + /* Is this the root directory? */
> + if (ip->i_ino == mp->m_sb.sb_rootino)
> + gp->gp_oflags |= XFS_GETPARENTS_OFLAG_ROOT;
> +
> + if (gpx->context.seen_enough == 0) {
> + /*
> + * If we did not run out of buffer space, then we reached the
> + * end of the pptr recordset, so set the DONE flag.
> + */
> + gp->gp_oflags |= XFS_GETPARENTS_OFLAG_DONE;
> + } else if (gpx->count == 0) {
> + /*
> + * If we ran out of buffer space before copying any parent
> + * pointers at all, the caller's buffer was too short. Tell
> + * userspace that, erm, the message is too long.
> + */
> + error = -EMSGSIZE;
> + goto out_free_buf;
> + }
> +
> + trace_xfs_getparents_end(ip, gp, &gpx->context.cursor);
> +
> + ASSERT(gpx->context.firstu <= gpx->gph.gph_request.gp_bufsize);
> +
> + /* Copy the records to userspace. */
> + if (copy_to_user(u64_to_uptr(gpx->gph.gph_request.gp_buffer),
> + gpx->krecords, gpx->context.firstu))
> + error = -EFAULT;
> +
> +out_free_buf:
> + kvfree(gpx->krecords);
> + gpx->krecords = NULL;
> + return error;
> +}
> +
> +/* Retrieve the parents of this file and pass them back to userspace. */
> +int
> +xfs_ioc_getparents(
> + struct file *file,
> + struct xfs_getparents __user *ureq)
> +{
> + struct xfs_getparents_ctx gpx = {
> + .ip = XFS_I(file_inode(file)),
> + };
> + struct xfs_getparents *kreq = &gpx.gph.gph_request;
> + struct xfs_mount *mp = gpx.ip->i_mount;
> + int error;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
> + if (!xfs_has_parent(mp))
> + return -EOPNOTSUPP;
> + if (copy_from_user(kreq, ureq, sizeof(*kreq)))
> + return -EFAULT;
> +
> + error = xfs_getparents(&gpx);
> + if (error)
> + return error;
> +
> + if (copy_to_user(ureq, kreq, sizeof(*kreq)))
> + return -EFAULT;
> +
> + return 0;
> +}
> +
> +/* Retrieve the parents of this file handle and pass them back to userspace. */
> +int
> +xfs_ioc_getparents_by_handle(
> + struct file *file,
> + struct xfs_getparents_by_handle __user *ureq)
> +{
> + struct xfs_getparents_ctx gpx = { };
> + struct xfs_inode *ip = XFS_I(file_inode(file));
> + struct xfs_mount *mp = ip->i_mount;
> + struct xfs_getparents_by_handle *kreq = &gpx.gph;
> + struct dentry *dentry;
> + int error;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
> + if (!xfs_has_parent(mp))
> + return -EOPNOTSUPP;
> + if (copy_from_user(kreq, ureq, sizeof(*kreq)))
> + return -EFAULT;
> +
> + dentry = xfs_khandle_to_dentry(file, &kreq->gph_handle);
I noticed a couple of things while doing more testing here -- first,
xfs_khandle_to_dentry doesn't check that the handle fsid actually
matches this filesystem, and AFAICT *nothing* actually checks that.
So I guess that's a longstanding weakness of handle validation, and we
probably haven't gotten any reports because what's the chance that
you'll get lucky with an ino/gen from a different filesystem?
(Pretty good what with golden images proliferating, I'd say...)
The second thing is that exportfs_decode_fh does too much work here --
if the handle references a directory, it'll walk up the directory tree
to the root to try to reconnect the dentry paths. For GETPARENTS we
don't care about that since we're not doing anything with dentries.
Walking upwards in the directory tree is extra work that doesn't change
the results.
Worse yet, if there's a loop in in the directory tree due to dotdot
damage or whatnot, this can livelock the system. This is unfortunate
for xfs_scrub because it'll use GETPARENTS to try to report the path of
a file that it wants to repair ... but it might not have checked those
parents. So I really don't want GETPARENTS to be creating a bunch of
dentries and reconnecting paths and whatnot.
What we really want, I think, is some basic handle validation and then a
call to something like xfs_nfs_get_inode.
if (!S_ISDIR(VFS_I(ip)->i_mode))
return -ENOTDIR;
if (memcmp(&handle->ha_fsid, mp->m_fixedfsid, sizeof(struct xfs_fsid)))
return -ESTALE;
if (handle->ha_fid.fid_len != xfs_filehandle_fid_len())
return -EINVAL;
inode = xfs_nfs_get_inode(mp->m_super, handle->ha_fid.fid_ino,
handle->ha_fid.fid_gen);
if (IS_ERR(inode))
return PTR_ERR(inode);
gpx.ip = XFS_I(inode);
error = xfs_getparents(&gpx);
And yes, I'll add a big comment explaining why we don't use the regular
handle functions here.
--D
> + if (IS_ERR(dentry))
> + return PTR_ERR(dentry);
> +
> + gpx.ip = XFS_I(dentry->d_inode);
> + error = xfs_getparents(&gpx);
> + dput(dentry);
> + if (error)
> + return error;
> +
> + if (copy_to_user(ureq, kreq, sizeof(*kreq)))
> + return -EFAULT;
> +
> + return 0;
> +}
> diff --git a/fs/xfs/xfs_handle.h b/fs/xfs/xfs_handle.h
> index e39eaf4689da9..6799a86d8565c 100644
> --- a/fs/xfs/xfs_handle.h
> +++ b/fs/xfs/xfs_handle.h
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (c) 2000-2005 Silicon Graphics, Inc.
> + * Copyright (c) 2022-2024 Oracle.
> * All rights reserved.
> */
> #ifndef __XFS_HANDLE_H__
> @@ -25,4 +26,8 @@ int xfs_ioc_attr_list(struct xfs_inode *dp, void __user *ubuf,
> struct dentry *xfs_handle_to_dentry(struct file *parfilp, void __user *uhandle,
> u32 hlen);
>
> +int xfs_ioc_getparents(struct file *file, struct xfs_getparents __user *arg);
> +int xfs_ioc_getparents_by_handle(struct file *file,
> + struct xfs_getparents_by_handle __user *arg);
> +
> #endif /* __XFS_HANDLE_H__ */
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 7b347cdd28785..c7a15b5f33aa4 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -35,6 +35,7 @@
> #include "xfs_health.h"
> #include "xfs_reflink.h"
> #include "xfs_ioctl.h"
> +#include "xfs_xattr.h"
> #include "xfs_rtbitmap.h"
> #include "xfs_file.h"
> #include "xfs_exchrange.h"
> @@ -1542,7 +1543,10 @@ xfs_file_ioctl(
>
> case XFS_IOC_FSGETXATTRA:
> return xfs_ioc_fsgetxattra(ip, arg);
> -
> + case XFS_IOC_GETPARENTS:
> + return xfs_ioc_getparents(filp, arg);
> + case XFS_IOC_GETPARENTS_BY_HANDLE:
> + return xfs_ioc_getparents_by_handle(filp, arg);
> case XFS_IOC_GETBMAP:
> case XFS_IOC_GETBMAPA:
> case XFS_IOC_GETBMAPX:
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index cf92a3bd56c79..9c7fbaae2717d 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -41,6 +41,7 @@
> #include "xfs_bmap.h"
> #include "xfs_exchmaps.h"
> #include "xfs_exchrange.h"
> +#include "xfs_parent.h"
>
> /*
> * We include this last to have the helpers above available for the trace
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index e6cbdffb14f64..4438b62a8c562 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -87,6 +87,9 @@ struct xfs_bmap_intent;
> struct xfs_exchmaps_intent;
> struct xfs_exchmaps_req;
> struct xfs_exchrange;
> +struct xfs_getparents;
> +struct xfs_parent_irec;
> +struct xfs_attrlist_cursor_kern;
>
> #define XFS_ATTR_FILTER_FLAGS \
> { XFS_ATTR_ROOT, "ROOT" }, \
> @@ -5158,6 +5161,95 @@ TRACE_EVENT(xfs_exchmaps_delta_nextents,
> __entry->d_nexts1, __entry->d_nexts2)
> );
>
> +DECLARE_EVENT_CLASS(xfs_getparents_rec_class,
> + TP_PROTO(struct xfs_inode *ip, const struct xfs_getparents *ppi,
> + const struct xfs_attr_list_context *context,
> + const struct xfs_getparents_rec *pptr),
> + TP_ARGS(ip, ppi, context, pptr),
> + TP_STRUCT__entry(
> + __field(dev_t, dev)
> + __field(xfs_ino_t, ino)
> + __field(unsigned int, firstu)
> + __field(unsigned short, reclen)
> + __field(unsigned int, bufsize)
> + __field(xfs_ino_t, parent_ino)
> + __field(unsigned int, parent_gen)
> + __string(name, pptr->gpr_name)
> + ),
> + TP_fast_assign(
> + __entry->dev = ip->i_mount->m_super->s_dev;
> + __entry->ino = ip->i_ino;
> + __entry->firstu = context->firstu;
> + __entry->reclen = pptr->gpr_reclen;
> + __entry->bufsize = ppi->gp_bufsize;
> + __entry->parent_ino = pptr->gpr_parent.ha_fid.fid_ino;
> + __entry->parent_gen = pptr->gpr_parent.ha_fid.fid_gen;
> + __assign_str(name, pptr->gpr_name);
> + ),
> + TP_printk("dev %d:%d ino 0x%llx firstu %u reclen %u bufsize %u parent_ino 0x%llx parent_gen 0x%x name '%s'",
> + MAJOR(__entry->dev), MINOR(__entry->dev),
> + __entry->ino,
> + __entry->firstu,
> + __entry->reclen,
> + __entry->bufsize,
> + __entry->parent_ino,
> + __entry->parent_gen,
> + __get_str(name))
> +)
> +#define DEFINE_XFS_GETPARENTS_REC_EVENT(name) \
> +DEFINE_EVENT(xfs_getparents_rec_class, name, \
> + TP_PROTO(struct xfs_inode *ip, const struct xfs_getparents *ppi, \
> + const struct xfs_attr_list_context *context, \
> + const struct xfs_getparents_rec *pptr), \
> + TP_ARGS(ip, ppi, context, pptr))
> +DEFINE_XFS_GETPARENTS_REC_EVENT(xfs_getparents_put_listent);
> +DEFINE_XFS_GETPARENTS_REC_EVENT(xfs_getparents_expand_lastrec);
> +
> +DECLARE_EVENT_CLASS(xfs_getparents_class,
> + TP_PROTO(struct xfs_inode *ip, const struct xfs_getparents *ppi,
> + const struct xfs_attrlist_cursor_kern *cur),
> + TP_ARGS(ip, ppi, cur),
> + TP_STRUCT__entry(
> + __field(dev_t, dev)
> + __field(xfs_ino_t, ino)
> + __field(unsigned short, iflags)
> + __field(unsigned short, oflags)
> + __field(unsigned int, bufsize)
> + __field(unsigned int, hashval)
> + __field(unsigned int, blkno)
> + __field(unsigned int, offset)
> + __field(int, initted)
> + ),
> + TP_fast_assign(
> + __entry->dev = ip->i_mount->m_super->s_dev;
> + __entry->ino = ip->i_ino;
> + __entry->iflags = ppi->gp_iflags;
> + __entry->oflags = ppi->gp_oflags;
> + __entry->bufsize = ppi->gp_bufsize;
> + __entry->hashval = cur->hashval;
> + __entry->blkno = cur->blkno;
> + __entry->offset = cur->offset;
> + __entry->initted = cur->initted;
> + ),
> + TP_printk("dev %d:%d ino 0x%llx iflags 0x%x oflags 0x%x bufsize %u cur_init? %d hashval 0x%x blkno %u offset %u",
> + MAJOR(__entry->dev), MINOR(__entry->dev),
> + __entry->ino,
> + __entry->iflags,
> + __entry->oflags,
> + __entry->bufsize,
> + __entry->initted,
> + __entry->hashval,
> + __entry->blkno,
> + __entry->offset)
> +)
> +#define DEFINE_XFS_GETPARENTS_EVENT(name) \
> +DEFINE_EVENT(xfs_getparents_class, name, \
> + TP_PROTO(struct xfs_inode *ip, const struct xfs_getparents *ppi, \
> + const struct xfs_attrlist_cursor_kern *cur), \
> + TP_ARGS(ip, ppi, cur))
> +DEFINE_XFS_GETPARENTS_EVENT(xfs_getparents_begin);
> +DEFINE_XFS_GETPARENTS_EVENT(xfs_getparents_end);
> +
> #endif /* _TRACE_XFS_H */
>
> #undef TRACE_INCLUDE_PATH
>
>
next prev parent reply other threads:[~2024-04-12 17:39 UTC|newest]
Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 0:36 [PATCHBOMB v13.1] xfs: directory parent pointers Darrick J. Wong
2024-04-10 0:44 ` [PATCHSET v13.1 1/9] xfs: design documentation for online fsck, part 2 Darrick J. Wong
2024-04-10 0:46 ` [PATCH 1/4] docs: update the parent pointers documentation to the final version Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:46 ` [PATCH 2/4] docs: update online directory and parent pointer repair sections Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:47 ` [PATCH 3/4] docs: update offline parent pointer repair strategy Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:47 ` [PATCH 4/4] docs: describe xfs directory tree online fsck Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:44 ` [PATCHSET v13.1 2/9] xfs: retain ILOCK during directory updates Darrick J. Wong
2024-04-10 0:47 ` [PATCH 1/7] xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 2/7] xfs: Increase XFS_QM_TRANS_MAXDQS " Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 3/7] xfs: Hold inode locks in xfs_ialloc Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 4/7] xfs: Hold inode locks in xfs_trans_alloc_dir Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 5/7] xfs: Hold inode locks in xfs_rename Darrick J. Wong
2024-04-10 4:42 ` Christoph Hellwig
2024-04-10 0:49 ` [PATCH 6/7] xfs: don't pick up IOLOCK during rmapbt repair scan Darrick J. Wong
2024-04-10 4:42 ` Christoph Hellwig
2024-04-10 0:49 ` [PATCH 7/7] xfs: unlock new repair tempfiles after creation Darrick J. Wong
2024-04-10 4:42 ` Christoph Hellwig
2024-04-10 0:44 ` [PATCHSET v13.1 3/9] xfs: shrink struct xfs_da_args Darrick J. Wong
2024-04-10 0:49 ` [PATCH 1/4] xfs: remove XFS_DA_OP_REMOVE Darrick J. Wong
2024-04-10 4:43 ` Christoph Hellwig
2024-04-10 0:49 ` [PATCH 2/4] xfs: remove XFS_DA_OP_NOTIME Darrick J. Wong
2024-04-10 4:44 ` Christoph Hellwig
2024-04-10 0:50 ` [PATCH 3/4] xfs: rename xfs_da_args.attr_flags Darrick J. Wong
2024-04-10 5:01 ` Christoph Hellwig
2024-04-10 20:55 ` Darrick J. Wong
2024-04-11 0:00 ` Darrick J. Wong
2024-04-11 3:26 ` Christoph Hellwig
2024-04-11 4:15 ` Darrick J. Wong
2024-04-10 0:50 ` [PATCH 4/4] xfs: rearrange xfs_da_args a bit to use less space Darrick J. Wong
2024-04-10 5:02 ` Christoph Hellwig
2024-04-10 20:56 ` Darrick J. Wong
2024-04-10 0:45 ` [PATCHSET v13.1 4/9] xfs: improve extended attribute validation Darrick J. Wong
2024-04-10 0:50 ` [PATCH 01/12] xfs: attr fork iext must be loaded before calling xfs_attr_is_leaf Darrick J. Wong
2024-04-10 5:04 ` Christoph Hellwig
2024-04-10 20:58 ` Darrick J. Wong
2024-04-10 0:50 ` [PATCH 02/12] xfs: require XFS_SB_FEAT_INCOMPAT_LOG_XATTRS for attr log intent item recovery Darrick J. Wong
2024-04-10 5:04 ` Christoph Hellwig
2024-04-10 0:51 ` [PATCH 03/12] xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available Darrick J. Wong
2024-04-10 5:05 ` Christoph Hellwig
2024-04-10 0:51 ` [PATCH 04/12] xfs: check opcode and iovec count match in xlog_recover_attri_commit_pass2 Darrick J. Wong
2024-04-10 5:05 ` Christoph Hellwig
2024-04-10 0:51 ` [PATCH 05/12] xfs: fix missing check for invalid attr flags Darrick J. Wong
2024-04-10 5:07 ` Christoph Hellwig
2024-04-10 21:04 ` Darrick J. Wong
2024-04-10 0:51 ` [PATCH 06/12] xfs: restructure xfs_attr_complete_op a bit Darrick J. Wong
2024-04-10 5:07 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 07/12] xfs: use helpers to extract xattr op from opflags Darrick J. Wong
2024-04-10 5:07 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 08/12] xfs: validate recovered name buffers when recovering xattr items Darrick J. Wong
2024-04-10 5:08 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 09/12] xfs: always set args->value in xfs_attri_item_recover Darrick J. Wong
2024-04-10 5:08 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 10/12] xfs: use local variables for name and value length in _attri_commit_pass2 Darrick J. Wong
2024-04-10 5:08 ` Christoph Hellwig
2024-04-10 0:53 ` [PATCH 11/12] xfs: refactor name/length checks in xfs_attri_validate Darrick J. Wong
2024-04-10 5:09 ` Christoph Hellwig
2024-04-10 0:53 ` [PATCH 12/12] xfs: enforce one namespace per attribute Darrick J. Wong
2024-04-10 5:09 ` Christoph Hellwig
2024-04-10 0:45 ` [PATCHSET v13.1 5/9] xfs: Parent Pointers Darrick J. Wong
2024-04-10 0:53 ` [PATCH 01/32] xfs: rearrange xfs_attr_match parameters Darrick J. Wong
2024-04-10 5:10 ` Christoph Hellwig
2024-04-10 0:54 ` [PATCH 02/32] xfs: check the flags earlier in xfs_attr_match Darrick J. Wong
2024-04-10 0:54 ` [PATCH 03/32] xfs: move xfs_attr_defer_add to xfs_attr_item.c Darrick J. Wong
2024-04-10 5:11 ` Christoph Hellwig
2024-04-10 0:54 ` [PATCH 04/32] xfs: create a separate hashname function for extended attributes Darrick J. Wong
2024-04-10 5:11 ` Christoph Hellwig
2024-04-10 0:54 ` [PATCH 05/32] xfs: add parent pointer support to attribute code Darrick J. Wong
2024-04-10 5:11 ` Christoph Hellwig
2024-04-10 0:55 ` [PATCH 06/32] xfs: define parent pointer ondisk extended attribute format Darrick J. Wong
2024-04-10 5:12 ` Christoph Hellwig
2024-04-10 0:55 ` [PATCH 07/32] xfs: allow xattr matching on name and value for local/sf attrs Darrick J. Wong
2024-04-10 5:16 ` Christoph Hellwig
2024-04-10 21:13 ` Darrick J. Wong
2024-04-11 3:28 ` Christoph Hellwig
2024-04-10 0:55 ` [PATCH 08/32] xfs: allow logged xattr operations if parent pointers are enabled Darrick J. Wong
2024-04-10 5:18 ` Christoph Hellwig
2024-04-10 21:18 ` Darrick J. Wong
2024-04-10 0:55 ` [PATCH 09/32] xfs: log parent pointer xattr removal operations Darrick J. Wong
2024-04-10 5:18 ` Christoph Hellwig
2024-04-10 0:56 ` [PATCH 10/32] xfs: log parent pointer xattr setting operations Darrick J. Wong
2024-04-10 0:56 ` [PATCH 11/32] xfs: log parent pointer xattr replace operations Darrick J. Wong
2024-04-10 5:26 ` Christoph Hellwig
2024-04-10 23:07 ` Darrick J. Wong
2024-04-11 3:35 ` Christoph Hellwig
2024-04-10 0:56 ` [PATCH 12/32] xfs: record inode generation in xattr update log intent items Darrick J. Wong
2024-04-10 5:27 ` Christoph Hellwig
2024-04-10 0:56 ` [PATCH 13/32] xfs: Expose init_xattrs in xfs_create_tmpfile Darrick J. Wong
2024-04-10 5:28 ` Christoph Hellwig
2024-04-10 0:57 ` [PATCH 14/32] xfs: add parent pointer validator functions Darrick J. Wong
2024-04-10 5:31 ` Christoph Hellwig
2024-04-10 18:53 ` Darrick J. Wong
2024-04-11 3:25 ` Christoph Hellwig
2024-04-10 0:57 ` [PATCH 15/32] xfs: extend transaction reservations for parent attributes Darrick J. Wong
2024-04-10 5:31 ` Christoph Hellwig
2024-04-10 0:57 ` [PATCH 16/32] xfs: create a hashname function for parent pointers Darrick J. Wong
2024-04-10 5:33 ` Christoph Hellwig
2024-04-10 21:39 ` Darrick J. Wong
2024-04-10 0:57 ` [PATCH 17/32] xfs: parent pointer attribute creation Darrick J. Wong
2024-04-10 5:44 ` Christoph Hellwig
2024-04-10 21:50 ` Darrick J. Wong
2024-04-10 0:58 ` [PATCH 18/32] xfs: add parent attributes to link Darrick J. Wong
2024-04-10 5:45 ` Christoph Hellwig
2024-04-10 0:58 ` [PATCH 19/32] xfs: add parent attributes to symlink Darrick J. Wong
2024-04-10 5:45 ` Christoph Hellwig
2024-04-10 0:58 ` [PATCH 20/32] xfs: remove parent pointers in unlink Darrick J. Wong
2024-04-10 5:45 ` Christoph Hellwig
2024-04-10 0:58 ` [PATCH 21/32] xfs: Add parent pointers to rename Darrick J. Wong
2024-04-10 5:46 ` Christoph Hellwig
2024-04-10 0:59 ` [PATCH 22/32] xfs: Add parent pointers to xfs_cross_rename Darrick J. Wong
2024-04-10 5:46 ` Christoph Hellwig
2024-04-10 0:59 ` [PATCH 23/32] xfs: Filter XFS_ATTR_PARENT for getfattr Darrick J. Wong
2024-04-10 5:51 ` Christoph Hellwig
2024-04-10 21:58 ` Darrick J. Wong
2024-04-11 3:29 ` Christoph Hellwig
2024-04-10 0:59 ` [PATCH 24/32] xfs: pass the attr value to put_listent when possible Darrick J. Wong
2024-04-10 5:51 ` Christoph Hellwig
2024-04-10 1:00 ` [PATCH 25/32] xfs: move handle ioctl code to xfs_handle.c Darrick J. Wong
2024-04-10 5:52 ` Christoph Hellwig
2024-04-10 1:00 ` [PATCH 26/32] xfs: split out handle management helpers a bit Darrick J. Wong
2024-04-10 5:56 ` Christoph Hellwig
2024-04-10 22:01 ` Darrick J. Wong
2024-04-10 1:00 ` [PATCH 27/32] xfs: Add parent pointer ioctls Darrick J. Wong
2024-04-10 6:04 ` Christoph Hellwig
2024-04-10 23:34 ` Darrick J. Wong
2024-04-12 17:39 ` Darrick J. Wong [this message]
2024-04-14 5:18 ` Christoph Hellwig
2024-04-15 19:40 ` Darrick J. Wong
2024-04-16 4:47 ` Christoph Hellwig
2024-04-16 16:50 ` Darrick J. Wong
2024-04-16 16:54 ` Christoph Hellwig
2024-04-16 18:52 ` Darrick J. Wong
2024-04-16 19:01 ` Christoph Hellwig
2024-04-16 19:07 ` Darrick J. Wong
2024-04-16 19:14 ` Christoph Hellwig
2024-04-17 5:22 ` Darrick J. Wong
2024-04-17 5:29 ` Christoph Hellwig
2024-04-17 5:55 ` Darrick J. Wong
2024-04-10 1:00 ` [PATCH 28/32] xfs: don't remove the attr fork when parent pointers are enabled Darrick J. Wong
2024-04-10 6:04 ` Christoph Hellwig
2024-04-10 1:01 ` [PATCH 29/32] xfs: Add the parent pointer support to the superblock version 5 Darrick J. Wong
2024-04-10 6:05 ` Christoph Hellwig
2024-04-10 22:06 ` Darrick J. Wong
2024-04-10 1:01 ` [PATCH 30/32] xfs: fix unit conversion error in xfs_log_calc_max_attrsetm_res Darrick J. Wong
2024-04-10 6:05 ` Christoph Hellwig
2024-04-10 1:01 ` [PATCH 31/32] xfs: drop compatibility minimum log size computations for reflink Darrick J. Wong
2024-04-10 6:06 ` Christoph Hellwig
2024-04-10 1:01 ` [PATCH 32/32] xfs: enable parent pointers Darrick J. Wong
2024-04-10 6:06 ` Christoph Hellwig
2024-04-10 22:11 ` Darrick J. Wong
2024-04-10 0:45 ` [PATCHSET v13.1 6/9] xfs: scrubbing for " Darrick J. Wong
2024-04-10 1:02 ` [PATCH 1/7] xfs: check dirents have " Darrick J. Wong
2024-04-10 6:12 ` Christoph Hellwig
2024-04-10 1:02 ` [PATCH 2/7] xfs: deferred scrub of dirents Darrick J. Wong
2024-04-10 6:13 ` Christoph Hellwig
2024-04-10 1:02 ` [PATCH 3/7] xfs: scrub parent pointers Darrick J. Wong
2024-04-10 6:13 ` Christoph Hellwig
2024-04-10 1:02 ` [PATCH 4/7] xfs: deferred scrub of " Darrick J. Wong
2024-04-10 6:14 ` Christoph Hellwig
2024-04-10 1:03 ` [PATCH 5/7] xfs: walk directory parent pointers to determine backref count Darrick J. Wong
2024-04-10 6:14 ` Christoph Hellwig
2024-04-10 1:03 ` [PATCH 6/7] xfs: check parent pointer xattrs when scrubbing Darrick J. Wong
2024-04-10 6:14 ` Christoph Hellwig
2024-04-10 1:03 ` [PATCH 7/7] xfs: salvage parent pointers when rebuilding xattr structures Darrick J. Wong
2024-04-10 6:15 ` Christoph Hellwig
2024-04-10 0:45 ` [PATCHSET v13.1 7/9] xfs: online repair for parent pointers Darrick J. Wong
2024-04-10 1:03 ` [PATCH 01/14] xfs: add xattr setname and removename functions for internal users Darrick J. Wong
2024-04-10 6:18 ` Christoph Hellwig
2024-04-10 22:18 ` Darrick J. Wong
2024-04-11 3:32 ` Christoph Hellwig
2024-04-11 4:30 ` Darrick J. Wong
2024-04-11 4:50 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 02/14] xfs: add raw parent pointer apis to support repair Darrick J. Wong
2024-04-10 6:18 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 03/14] xfs: repair directories by scanning directory parent pointers Darrick J. Wong
2024-04-10 6:19 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 04/14] xfs: implement live updates for directory repairs Darrick J. Wong
2024-04-10 6:19 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 05/14] xfs: replay unlocked parent pointer updates that accrue during xattr repair Darrick J. Wong
2024-04-10 6:19 ` Christoph Hellwig
2024-04-10 1:05 ` [PATCH 06/14] xfs: repair directory parent pointers by scanning for dirents Darrick J. Wong
2024-04-10 6:20 ` Christoph Hellwig
2024-04-10 1:05 ` [PATCH 07/14] xfs: implement live updates for parent pointer repairs Darrick J. Wong
2024-04-10 6:20 ` Christoph Hellwig
2024-04-10 1:05 ` [PATCH 08/14] xfs: remove pointless unlocked assertion Darrick J. Wong
2024-04-10 6:20 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 09/14] xfs: split xfs_bmap_add_attrfork into two pieces Darrick J. Wong
2024-04-10 6:21 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 10/14] xfs: add a per-leaf block callback to xchk_xattr_walk Darrick J. Wong
2024-04-10 6:22 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 11/14] xfs: actually rebuild the parent pointer xattrs Darrick J. Wong
2024-04-10 6:22 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 12/14] xfs: adapt the orphanage code to handle parent pointers Darrick J. Wong
2024-04-10 6:23 ` Christoph Hellwig
2024-04-10 1:07 ` [PATCH 13/14] xfs: repair link count of nondirectories after rebuilding " Darrick J. Wong
2024-04-10 6:22 ` Christoph Hellwig
2024-04-10 1:07 ` [PATCH 14/14] xfs: inode repair should ensure there's an attr fork to store " Darrick J. Wong
2024-04-10 6:24 ` Christoph Hellwig
2024-04-10 0:46 ` [PATCHSET v13.1 8/9] xfs: detect and correct directory tree problems Darrick J. Wong
2024-04-10 1:07 ` [PATCH 1/4] xfs: teach online scrub to find directory tree structure problems Darrick J. Wong
2024-04-10 7:21 ` Christoph Hellwig
2024-04-10 1:07 ` [PATCH 2/4] xfs: invalidate dirloop scrub path data when concurrent updates happen Darrick J. Wong
2024-04-10 7:21 ` Christoph Hellwig
2024-04-10 1:08 ` [PATCH 3/4] xfs: report directory tree corruption in the health information Darrick J. Wong
2024-04-10 7:23 ` Christoph Hellwig
2024-04-10 1:08 ` [PATCH 4/4] xfs: fix corruptions in the directory tree Darrick J. Wong
2024-04-10 7:23 ` Christoph Hellwig
2024-04-10 0:46 ` [PATCHSET v13.1 9/9] xfs: vectorize scrub kernel calls Darrick J. Wong
2024-04-10 1:08 ` [PATCH 1/3] xfs: reduce the rate of cond_resched calls inside scrub Darrick J. Wong
2024-04-10 14:55 ` Christoph Hellwig
2024-04-10 22:19 ` Darrick J. Wong
2024-04-10 1:08 ` [PATCH 2/3] xfs: introduce vectored scrub mode Darrick J. Wong
2024-04-10 15:00 ` Christoph Hellwig
2024-04-11 0:59 ` Darrick J. Wong
2024-04-11 3:38 ` Christoph Hellwig
2024-04-11 4:31 ` Darrick J. Wong
2024-04-10 1:09 ` [PATCH 3/3] xfs: only iget the file once when doing vectored scrub-by-handle Darrick J. Wong
2024-04-10 15:12 ` Christoph Hellwig
2024-04-11 1:15 ` Darrick J. Wong
2024-04-11 3:49 ` Christoph Hellwig
2024-04-11 4:41 ` Darrick J. Wong
2024-04-11 4:52 ` Christoph Hellwig
2024-04-11 4:56 ` Darrick J. Wong
2024-04-11 5:02 ` Christoph Hellwig
2024-04-11 5:21 ` Darrick J. Wong
2024-04-11 14:02 ` Christoph Hellwig
2024-04-12 0:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412173957.GB11948@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).