From: Christoph Hellwig <hch@lst.de>
To: Chandan Babu R <chandan.babu@oracle.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org
Subject: bring back RT delalloc support v5
Date: Wed, 27 Mar 2024 12:03:05 +0100 [thread overview]
Message-ID: <20240327110318.2776850-1-hch@lst.de> (raw)
Hi all,
this series adds back delalloc support for RT inodes, at least if the RT
extent size is a single file system block. This shows really nice
performance improvements for workloads that frequently rewrite or append
to files, and improves fragmentation for larger writes. On other
workloads it sometimes shows small performance improvements or flat
performance.
Changes since v4:
- fix a bug in the fix for splitting RT delalloc reservations
- rework where rtbitmap locking happens in the bunmapi patch to
avoid churn with a series in development, stealing a patch from
Darrick's giant patch queue in the process
Changes since v3:
- fix a bug in splitting RT delalloc reservations
- fix online repair of RT delalloc fscounters
- adjust the freespace counter refactoing to play nicer with an
upcoming series of mine
Changes since v3:
- drop gratuitous changes to xfs_mod_freecounter/xfs_add_freecounter
that caused a warning to be logged when it shouldn't.
- track delalloc rtextents instead of rtblocks in xfs_mount
- fix commit message spelling an typos
Changes since v2:
- keep casting to int64_t for xfs_mod_delalloc
- add a patch to clarify and assert that the block delta in
xfs_trans_unreserve_and_mod_sb can only be positive
Diffstat:
libxfs/xfs_ag.c | 4 -
libxfs/xfs_ag_resv.c | 24 +------
libxfs/xfs_ag_resv.h | 2
libxfs/xfs_alloc.c | 4 -
libxfs/xfs_bmap.c | 152 ++++++++++++++++++++++------------------------
libxfs/xfs_rtbitmap.c | 57 +++++++++++++++++
libxfs/xfs_rtbitmap.h | 17 +++++
libxfs/xfs_shared.h | 6 +
scrub/common.c | 1
scrub/fscounters.c | 12 ++-
scrub/fscounters.h | 1
scrub/fscounters_repair.c | 3
scrub/repair.c | 5 -
xfs_fsmap.c | 4 -
xfs_fsops.c | 29 ++------
xfs_fsops.h | 2
xfs_inode.c | 3
xfs_iomap.c | 44 +++++++++----
xfs_iops.c | 2
xfs_mount.c | 85 +++++++++++++++----------
xfs_mount.h | 36 ++++++++--
xfs_rtalloc.c | 22 ++----
xfs_super.c | 17 +++--
xfs_trace.h | 1
xfs_trans.c | 63 +++++++++----------
25 files changed, 348 insertions(+), 248 deletions(-)
next reply other threads:[~2024-03-27 11:03 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 11:03 Christoph Hellwig [this message]
2024-03-27 11:03 ` [PATCH 01/13] xfs: make XFS_TRANS_LOWMODE match the other XFS_TRANS_ definitions Christoph Hellwig
2024-03-28 3:08 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 02/13] xfs: refactor realtime inode locking Christoph Hellwig
2024-03-28 3:15 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 03/13] xfs: free RT extents after updating the bmap btree Christoph Hellwig
2024-03-27 14:55 ` Darrick J. Wong
2024-03-27 17:03 ` Christoph Hellwig
2024-03-28 4:13 ` Dave Chinner
2024-03-29 4:14 ` Christoph Hellwig
2024-03-30 21:55 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 04/13] xfs: move RT inode locking out of __xfs_bunmapi Christoph Hellwig
2024-03-27 15:07 ` Darrick J. Wong
2024-03-27 17:06 ` Christoph Hellwig
2024-03-27 18:06 ` Darrick J. Wong
2024-03-27 18:12 ` Christoph Hellwig
2024-03-28 4:15 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 05/13] xfs: block deltas in xfs_trans_unreserve_and_mod_sb must be positive Christoph Hellwig
2024-03-28 4:16 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 06/13] xfs: split xfs_mod_freecounter Christoph Hellwig
2024-03-27 15:12 ` Darrick J. Wong
2024-03-28 4:18 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 07/13] xfs: reinstate RT support in xfs_bmapi_reserve_delalloc Christoph Hellwig
2024-03-28 4:20 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 08/13] xfs: cleanup fdblock/frextent accounting in xfs_bmap_del_extent_delay Christoph Hellwig
2024-03-28 4:22 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 09/13] xfs: support RT inodes in xfs_mod_delalloc Christoph Hellwig
2024-03-27 15:20 ` Darrick J. Wong
2024-03-27 17:05 ` Christoph Hellwig
2024-03-28 4:27 ` Dave Chinner
2024-03-28 4:34 ` Christoph Hellwig
2024-03-28 4:42 ` Dave Chinner
2024-03-28 8:25 ` Christoph Hellwig
2024-03-28 21:25 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 10/13] xfs: look at m_frextents in xfs_iomap_prealloc_size for RT allocations Christoph Hellwig
2024-03-28 4:32 ` Dave Chinner
2024-03-28 4:34 ` Christoph Hellwig
2024-03-27 11:03 ` [PATCH 11/13] xfs: rework splitting of indirect block reservations Christoph Hellwig
2024-03-27 15:14 ` Darrick J. Wong
2024-03-28 4:35 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 12/13] xfs: stop the steal (of data blocks for RT indirect blocks) Christoph Hellwig
2024-03-27 15:18 ` Darrick J. Wong
2024-03-28 4:36 ` Dave Chinner
2024-03-27 11:03 ` [PATCH 13/13] xfs: reinstate delalloc for RT inodes (if sb_rextsize == 1) Christoph Hellwig
2024-03-28 4:39 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327110318.2776850-1-hch@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).