From: Xie He <xie.he.0141@gmail.com>
To: Brian Norris <briannorris@chromium.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux X25 <linux-x25@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len
Date: Thu, 30 Jul 2020 17:55:04 -0700 [thread overview]
Message-ID: <CAJht_EMQvNknLFXVBJdb190jg8duD5DZ1c3HcOsUbYFOa6-5TA@mail.gmail.com> (raw)
In-Reply-To: <CA+ASDXPRLqq=vxnkF4z8=xvuqOKuuoqifvsNsERWg9uYJrFXgg@mail.gmail.com>
On Thu, Jul 30, 2020 at 5:24 PM Brian Norris <briannorris@chromium.org> wrote:
>
> Sure, I can do that:
>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Thank you so much for your review, Brian!
> I guess x25 is basically an abandoned project, if you're coming to me for this?
Yes, it does seem to me that X.25 is unmaintained. I'm submitting
patches for it because I'm personally interested in X.25 and I want to
fix things that I find to be having issues. But it's very hard for me
to do so because it's hard to find reviewers for X.25 code. So I
really appreciate that you review this patch. Thanks!
I don't know if it is the right thing to continue submitting patches
for X.25, or we should just keep the code as is. Maybe the kernel
community can have a discussion some time to decide what to do with
it.
prev parent reply other threads:[~2020-07-31 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 11:05 [PATCH] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len Xie He
2020-07-27 19:41 ` Xie He
2020-07-28 5:24 ` Cong Wang
2020-07-28 6:59 ` Xie He
2020-07-28 19:52 ` Brian Norris
2020-07-29 1:41 ` Xie He
2020-07-31 0:24 ` Brian Norris
2020-07-31 0:55 ` Xie He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJht_EMQvNknLFXVBJdb190jg8duD5DZ1c3HcOsUbYFOa6-5TA@mail.gmail.com \
--to=xie.he.0141@gmail.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).