From: David Miller <davem@davemloft.net>
To: xie.he.0141@gmail.com
Cc: kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-x25@vger.kernel.org,
ms@dev.tdt.de
Subject: Re: [PATCH net] drivers/net/wan/lapbether: Set network_header before transmitting
Date: Wed, 26 Aug 2020 15:51:16 -0700 (PDT) [thread overview]
Message-ID: <20200826.155116.1238002224655277772.davem@davemloft.net> (raw)
In-Reply-To: <20200826030353.75645-1-xie.he.0141@gmail.com>
From: Xie He <xie.he.0141@gmail.com>
Date: Tue, 25 Aug 2020 20:03:53 -0700
> Set the skb's network_header before it is passed to the underlying
> Ethernet device for transmission.
>
> This patch fixes the following issue:
>
> When we use this driver with AF_PACKET sockets, there would be error
> messages of:
> protocol 0805 is buggy, dev (Ethernet interface name)
> printed in the system "dmesg" log.
>
> This is because skbs passed down to the Ethernet device for transmission
> don't have their network_header properly set, and the dev_queue_xmit_nit
> function in net/core/dev.c complains about this.
>
> Reason of setting the network_header to this place (at the end of the
> Ethernet header, and at the beginning of the Ethernet payload):
>
> Because when this driver receives an skb from the Ethernet device, the
> network_header is also set at this place.
>
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
Applied, thank you.
prev parent reply other threads:[~2020-08-26 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 3:03 [PATCH net] drivers/net/wan/lapbether: Set network_header before transmitting Xie He
2020-08-26 22:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826.155116.1238002224655277772.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).