From: David Miller <davem@davemloft.net>
To: xie.he.0141@gmail.com
Cc: kuba@kernel.org, madhuparnabhowmik04@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-x25@vger.kernel.org
Subject: Re: [PATCH v2] drivers/net/wan/lapbether: Fixed the value of hard_header_len
Date: Mon, 06 Jul 2020 12:16:36 -0700 (PDT) [thread overview]
Message-ID: <20200706.121636.148338846008093922.davem@davemloft.net> (raw)
In-Reply-To: <20200706004521.78091-1-xie.he.0141@gmail.com>
From: Xie He <xie.he.0141@gmail.com>
Date: Sun, 5 Jul 2020 17:45:21 -0700
> When this driver transmits data,
> first this driver will remove a pseudo header of 1 byte,
> then the lapb module will prepend the LAPB header of 2 or 3 bytes,
> then this driver will prepend a length field of 2 bytes,
> then the underlying Ethernet device will prepend its own header.
>
> So, the header length required should be:
> -1 + 3 + 2 + "the header length needed by the underlying device".
>
> This patch fixes kernel panic when this driver is used with AF_PACKET
> SOCK_DGRAM sockets.
>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
Applied, thank you.
prev parent reply other threads:[~2020-07-06 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 0:45 [PATCH v2] drivers/net/wan/lapbether: Fixed the value of hard_header_len Xie He
2020-07-06 19:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706.121636.148338846008093922.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).