From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzkaller@googlegroups.com, andrew.hendry@gmail.com,
linux-x25@vger.kernel.org
Subject: Re: [PATCH net] net/x25: do not hold the cpu too long in x25_new_lci()
Date: Mon, 11 Feb 2019 13:20:42 -0800 (PST) [thread overview]
Message-ID: <20190211.132042.529132709200315406.davem@davemloft.net> (raw)
In-Reply-To: <20190208204105.16314-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 8 Feb 2019 12:41:05 -0800
> Due to quadratic behavior of x25_new_lci(), syzbot was able
> to trigger an rcu stall.
>
> Fix this by not blocking BH for the whole duration of
> the function, and inserting a reschedule point when possible.
>
> If we care enough, using a bitmap could get rid of the quadratic
> behavior.
>
> syzbot report :
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied, thanks.
prev parent reply other threads:[~2019-02-11 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 20:41 [PATCH net] net/x25: do not hold the cpu too long in x25_new_lci() Eric Dumazet
2019-02-11 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211.132042.529132709200315406.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.hendry@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).