Linux-WPAN Archive mirror
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Bo Liu <liubo03@inspur.com>,
	alex.aring@gmail.com, miquel.raynal@bootlin.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache
Date: Mon, 26 Feb 2024 21:50:55 +0100	[thread overview]
Message-ID: <ff45cc5c-e952-4464-a479-4b9dfafe960d@datenfreihafen.org> (raw)
In-Reply-To: <20240202064659.39434-1-liubo03@inspur.com>

Hello,

On 02.02.24 07:46, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
>   drivers/net/ieee802154/mrf24j40.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee4cfbf2c5cc..d3f42efc5d1a 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -388,7 +388,7 @@ static const struct regmap_config mrf24j40_short_regmap = {
>   	.pad_bits = 1,
>   	.write_flag_mask = MRF24J40_SHORT_WRITE,
>   	.read_flag_mask = MRF24J40_SHORT_READ,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.max_register = MRF24J40_SHORT_NUMREGS,
>   	.writeable_reg = mrf24j40_short_reg_writeable,
>   	.readable_reg = mrf24j40_short_reg_readable,
> @@ -495,7 +495,7 @@ static const struct regmap_config mrf24j40_long_regmap = {
>   	.pad_bits = 5,
>   	.write_flag_mask = MRF24J40_LONG_ACCESS,
>   	.read_flag_mask = MRF24J40_LONG_ACCESS,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.max_register = MRF24J40_LONG_NUMREGS,
>   	.writeable_reg = mrf24j40_long_reg_writeable,
>   	.readable_reg = mrf24j40_long_reg_readable,

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt

      reply	other threads:[~2024-02-26 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02  6:46 [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache Bo Liu
2024-02-26 20:50 ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff45cc5c-e952-4464-a479-4b9dfafe960d@datenfreihafen.org \
    --to=stefan@datenfreihafen.org \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=liubo03@inspur.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).