From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Tejun Heo <tj@kernel.org>, Alexander Aring <alex.aring@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ieee802154: ca8210: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call
Date: Mon, 26 Feb 2024 22:00:07 +0100 [thread overview]
Message-ID: <f0280912-6423-494f-8d61-28216551ebb9@datenfreihafen.org> (raw)
In-Reply-To: <ZcF1El7fn5xkeoB1@slm.duckdns.org>
Hello,
On 06.02.24 00:53, Tejun Heo wrote:
> Workqueue is in the process of cleaning up the distinction between unbound
> workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND
> isn't needed for alloc_ordered_workqueue() and will trigger a warning in the
> future. Let's remove it. This doesn't cause any functional changes.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/net/ieee802154/ca8210.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2857,19 +2857,13 @@ static int ca8210_interrupt_init(struct
> */
> static int ca8210_dev_com_init(struct ca8210_priv *priv)
> {
> - priv->mlme_workqueue = alloc_ordered_workqueue(
> - "MLME work queue",
> - WQ_UNBOUND
> - );
> + priv->mlme_workqueue = alloc_ordered_workqueue("MLME work queue", 0);
> if (!priv->mlme_workqueue) {
> dev_crit(&priv->spi->dev, "alloc of mlme_workqueue failed!\n");
> return -ENOMEM;
> }
>
> - priv->irq_workqueue = alloc_ordered_workqueue(
> - "ca8210 irq worker",
> - WQ_UNBOUND
> - );
> + priv->irq_workqueue = alloc_ordered_workqueue("ca8210 irq worker", 0);
> if (!priv->irq_workqueue) {
> dev_crit(&priv->spi->dev, "alloc of irq_workqueue failed!\n");
> destroy_workqueue(priv->mlme_workqueue);
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
prev parent reply other threads:[~2024-02-26 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 23:53 [PATCH] ieee802154: ca8210: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call Tejun Heo
2024-02-06 8:59 ` Miquel Raynal
2024-02-26 21:00 ` Stefan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0280912-6423-494f-8d61-28216551ebb9@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).