From: Joel Fernandes <joel@joelfernandes.org>
To: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: linux-kernel@vger.kernel.org,
Alexander Aring <alex.aring@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-wpan@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
boqun.feng@gmail.com, paulmck@kernel.org, urezki@gmail.com
Subject: Re: [PATCH] mac802154: Rename kfree_rcu() to kvfree_rcu_mightsleep()
Date: Thu, 16 Mar 2023 13:58:28 -0400 [thread overview]
Message-ID: <6EAB6B07-60C0-4489-9281-E01264E86DA5@joelfernandes.org> (raw)
In-Reply-To: <99dccb18-d16e-0b5b-586d-59a7649f68c4@datenfreihafen.org>
> On Mar 16, 2023, at 12:36 PM, Stefan Schmidt <stefan@datenfreihafen.org> wrote:
>
> Hello Joel.
>
>> On 10.03.23 02:31, Joel Fernandes (Google) wrote:
>> The k[v]free_rcu() macro's single-argument form is deprecated.
>> Therefore switch to the new k[v]free_rcu_mightsleep() variant. The goal
>> is to avoid accidental use of the single-argument forms, which can
>> introduce functionality bugs in atomic contexts and latency bugs in
>> non-atomic contexts.
>> The callers are holding a mutex so the context allows blocking. Hence
>> using the API with a single argument will be fine, but use its new name.
>> There is no functionality change with this patch.
>> Fixes: 57588c71177f ("mac802154: Handle passive scanning")
>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>> ---
>> Please Ack the patch but we can carry it through the RCU tree as well if
>> needed, as it is not a bug per-se and we are not dropping the old API before
>> the next release.
>
> The "but we can carry it" part throws me off here. Not sure if you want this through the RCU tree (I suppose). In that case see my ack below.
>
> If you want me to take it through my wpan tree instead let me know.
We will take this with your Ack below, thank you!
- Joel
>> net/mac802154/scan.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
>> index 9b0933a185eb..5c191bedd72c 100644
>> --- a/net/mac802154/scan.c
>> +++ b/net/mac802154/scan.c
>> @@ -52,7 +52,7 @@ static int mac802154_scan_cleanup_locked(struct ieee802154_local *local,
>> request = rcu_replace_pointer(local->scan_req, NULL, 1);
>> if (!request)
>> return 0;
>> - kfree_rcu(request);
>> + kvfree_rcu_mightsleep(request);
>> /* Advertize first, while we know the devices cannot be removed */
>> if (aborted)
>> @@ -403,7 +403,7 @@ int mac802154_stop_beacons_locked(struct ieee802154_local *local,
>> request = rcu_replace_pointer(local->beacon_req, NULL, 1);
>> if (!request)
>> return 0;
>> - kfree_rcu(request);
>> + kvfree_rcu_mightsleep(request);
>> nl802154_beaconing_done(wpan_dev);
>>
>
>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
>
> regards
> Stefan Schmidt
prev parent reply other threads:[~2023-03-16 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 1:31 [PATCH] mac802154: Rename kfree_rcu() to kvfree_rcu_mightsleep() Joel Fernandes (Google)
2023-03-16 16:36 ` Stefan Schmidt
2023-03-16 17:58 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6EAB6B07-60C0-4489-9281-E01264E86DA5@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=alex.aring@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulmck@kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).