From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Guilhem Imberton <guilhem.imberton@qorvo.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH wpan v2 5/6] mac802154: Fix an always true condition
Date: Tue, 14 Feb 2023 14:50:34 +0100 [thread overview]
Message-ID: <20230214135035.1202471-6-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20230214135035.1202471-1-miquel.raynal@bootlin.com>
At this stage we simply do not care about the delayed work value,
because active scan is not yet supported, so we can blindly queue
another work once a beacon has been sent.
It fixes a smatch warning:
mac802154_beacon_worker() warn: always true condition
'(local->beacon_interval >= 0) => (0-u32max >= 0)'
Fixes: 3accf4762734 ("mac802154: Handle basic beaconing")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
net/mac802154/scan.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
index fff41e59099e..9b0933a185eb 100644
--- a/net/mac802154/scan.c
+++ b/net/mac802154/scan.c
@@ -383,9 +383,8 @@ void mac802154_beacon_worker(struct work_struct *work)
dev_err(&sdata->dev->dev,
"Beacon could not be transmitted (%d)\n", ret);
- if (local->beacon_interval >= 0)
- queue_delayed_work(local->mac_wq, &local->beacon_work,
- local->beacon_interval);
+ queue_delayed_work(local->mac_wq, &local->beacon_work,
+ local->beacon_interval);
}
int mac802154_stop_beacons_locked(struct ieee802154_local *local,
--
2.34.1
next prev parent reply other threads:[~2023-02-14 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 13:50 [PATCH wpan v2 0/6] ieee802154: Scan/Beacon fixes Miquel Raynal
2023-02-14 13:50 ` [PATCH wpan v2 1/6] ieee802154: Use netlink policies when relevant on scan parameters Miquel Raynal
2023-02-14 13:50 ` [PATCH wpan v2 2/6] ieee802154: Convert scan error messages to extack Miquel Raynal
2023-02-27 20:41 ` Eric Dumazet
2023-02-28 10:08 ` Miquel Raynal
2023-02-14 13:50 ` [PATCH wpan v2 3/6] ieee802154: Change error code on monitor scan netlink request Miquel Raynal
2023-02-14 13:50 ` [PATCH wpan v2 4/6] mac802154: Send beacons using the MLME Tx path Miquel Raynal
2023-02-14 13:50 ` Miquel Raynal [this message]
2023-02-14 13:50 ` [PATCH wpan v2 6/6] ieee802154: Drop device trackers Miquel Raynal
2023-02-17 9:10 ` [PATCH wpan v2 0/6] ieee802154: Scan/Beacon fixes Miquel Raynal
2023-02-18 17:20 ` Stefan Schmidt
2023-02-18 20:04 ` Miquel Raynal
2023-02-20 17:59 ` Jakub Kicinski
2023-02-20 19:15 ` Stefan Schmidt
2023-02-20 19:14 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214135035.1202471-6-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=edumazet@google.com \
--cc=frederic.blain@qorvo.com \
--cc=guilhem.imberton@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=pabeni@redhat.com \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).