Linux-Wireless Archive mirror
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>,
	<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv3 2/3] wifi: ath12k: Remove unsupported tx monitor handling
Date: Mon, 29 Apr 2024 14:57:33 -0700	[thread overview]
Message-ID: <ac9dc67a-8bfe-48d4-a169-99f2caca3643@quicinc.com> (raw)
In-Reply-To: <20240429072039.711706-3-quic_tamizhr@quicinc.com>

On 4/29/2024 12:20 AM, Tamizh Chelvam Raja wrote:
> Currently tx monitor is not supported in driver.So remove
> the tx monitor ring configuration, allocation and handling.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/dp_mon.c | 40 +----------------
>  drivers/net/wireless/ath/ath12k/dp_rx.c  | 56 ------------------------
>  drivers/net/wireless/ath/ath12k/dp_tx.c  | 42 ------------------
>  drivers/net/wireless/ath/ath12k/dp_tx.h  |  1 -
>  4 files changed, 1 insertion(+), 138 deletions(-)
[...]
> @@ -498,7 +487,6 @@ static void ath12k_dp_rx_pdev_srng_free(struct ath12k *ar)
>  
>  	for (i = 0; i < ab->hw_params->num_rxmda_per_pdev; i++) {
>  		ath12k_dp_srng_cleanup(ab, &dp->rxdma_mon_dst_ring[i]);
> -		ath12k_dp_srng_cleanup(ab, &dp->tx_mon_dst_ring[i]);
>  	}

ath12k-check warns:

drivers/net/wireless/ath/ath12k/dp_rx.c:488: braces {} are not necessary for
single statement blocks



  reply	other threads:[~2024-04-29 21:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  7:20 [PATCHv3 0/3] wifi: ath12k: Remove unsupported and unused ring configurations Tamizh Chelvam Raja
2024-04-29  7:20 ` [PATCHv3 1/3] wifi: ath12k: fix calling correct function for rx monitor mode Tamizh Chelvam Raja
2024-04-29  7:20 ` [PATCHv3 2/3] wifi: ath12k: Remove unsupported tx monitor handling Tamizh Chelvam Raja
2024-04-29 21:57   ` Jeff Johnson [this message]
2024-04-29  7:20 ` [PATCHv3 3/3] wifi: ath12k: Remove unused tcl_*_ring configuration Tamizh Chelvam Raja
2024-04-29 21:44 ` [PATCHv3 0/3] wifi: ath12k: Remove unsupported and unused ring configurations Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac9dc67a-8bfe-48d4-a169-99f2caca3643@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_tamizhr@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).