From: David Lin <yu-hao.lin@nxp.com>
To: David Lin <yu-hao.lin@nxp.com>, Brian Norris <briannorris@chromium.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kalle Valo <kvalo@kernel.org>,
"francesco@dolcini.it" <francesco@dolcini.it>,
Pete Hsieh <tsung-hsien.hsieh@nxp.com>,
rafael.beims <rafael.beims@toradex.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: RE: [EXT] [PATCH v10 0/2] wifi: mwifiex: add code to support host mlme
Date: Mon, 13 May 2024 01:27:13 +0000 [thread overview]
Message-ID: <PA4PR04MB96381B9675BCA5861AEDEF25D1E22@PA4PR04MB9638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <PA4PR04MB9638F35B2FF70A1E514C25D0D1182@PA4PR04MB9638.eurprd04.prod.outlook.com>
Hi Brian,
> From: David Lin <yu-hao.lin@nxp.com>
> Sent: Thursday, May 2, 2024 4:35 PM
> To: Brian Norris <briannorris@chromium.org>
> Cc: Marcel Holtmann <marcel@holtmann.org>;
> linux-wireless@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; Kalle
> Valo <kvalo@kernel.org>; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; rafael.beims <rafael.beims@toradex.com>;
> Francesco Dolcini <francesco.dolcini@toradex.com>
> Subject: RE: [EXT] [PATCH v10 0/2] wifi: mwifiex: add code to support host
> mlme
>
> > From: Brian Norris <briannorris@chromium.org>
> > Sent: Friday, April 26, 2024 9:09 AM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Marcel Holtmann <marcel@holtmann.org>;
> > linux-wireless@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>;
> > Kalle Valo <kvalo@kernel.org>; francesco@dolcini.it; Pete Hsieh
> > <tsung-hsien.hsieh@nxp.com>; rafael.beims <rafael.beims@toradex.com>;
> > Francesco Dolcini <francesco.dolcini@toradex.com>
> > Subject: Re: [EXT] [PATCH v10 0/2] wifi: mwifiex: add code to support
> > host mlme
> >
> > Hi David,
> >
> > On Wed, Apr 24, 2024 at 7:40 PM David Lin <yu-hao.lin@nxp.com> wrote:
> > > > From: Marcel Holtmann <marcel@holtmann.org>
> > > >
> > > > Hi David,
> > > >
> > Perhaps I'm missing something (very likely), but I don't immediately
> > see much difference (with respect to your FW API, and future
> > extensibility) between external_auth() and your current solution (of
> > intercepting auth()/assoc() and constructing your own AUTH frames). It
> > mostly just means the AUTH mgmt frames will be coming in via
> > NL80211_CMD_FRAME instead of being manually constructed within your
> > .auth() hook. The external_auth() approach actually looks *more*
> > natural than your current solution.
> >
> > How exactly does your solution make "future changes [easier] to
> > support [than with external_auth]"? Do you not trust that
> > wpa_supplicant will provide exactly the right NL80211_CMD_FRAME
> > content you're looking for, and you need to tweak it to make your
> > firmware happy? You're talking in extreme generality, which doesn't
> > make it easy for me (and presumably
> > Marcel) to understand why you're choosing one solution and rejecting
> > another preexisting one.
>
> 1. The process of external_auth should be as follows:
> a. cfg80211_ops.connect() is called to establish connection with remote
> AP.
> b. If authentication is not WLAN_AUTH_SAE, FW will process
> authentication/association
> and reply connection result to cfg80211.
> c. If authentication is WLAN_AUTH_SAE, FW should notify driver to call
> cfg80211_external_auth_request() to offload authentication to
> wpa_supplicant.
> d. FW will wait for authentication result passed by
> cfg80211_ops.external_auth() to
> decide if association should be processed with remote AP for the original
> connection
> request and reply connection result to cfg80211.
> NXP FW only supports association with or without authentication, it can't
> support external_auth.
>
> 2. Hook separating auth/assoc will offload SME to wpa_supplicant
> completely. Driver/FW don't need
> to involve the process of authentication just like external_auth did. There
> is no effort for driver/FW
> to support any future modifications of authentication process.
>
> David
>
Can we confirm that hooking separating auth/assoc is more suitable than "external_auth" for mwifiex?
David
next prev parent reply other threads:[~2024-05-13 1:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 6:06 [PATCH v10 0/2] wifi: mwifiex: add code to support host mlme David Lin
2024-04-18 6:06 ` [PATCH v10 1/2] wifi: mwifiex: add host mlme for client mode David Lin
2024-04-18 6:37 ` Francesco Dolcini
2024-04-18 8:24 ` [EXT] " David Lin
2024-05-23 0:53 ` Brian Norris
2024-05-24 9:46 ` [EXT] " David Lin
2024-05-24 17:02 ` Brian Norris
2024-05-24 22:00 ` David Lin
2024-05-24 22:54 ` Brian Norris
2024-05-25 0:50 ` David Lin
2024-05-25 11:24 ` David Lin
2024-04-18 6:06 ` [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode David Lin
2024-05-23 0:59 ` Brian Norris
2024-05-23 2:20 ` [EXT] " David Lin
2024-04-18 6:47 ` [PATCH v10 0/2] wifi: mwifiex: add code to support host mlme Marcel Holtmann
2024-04-18 9:08 ` [EXT] " David Lin
2024-04-18 9:15 ` [EXT] " Marcel Holtmann
2024-04-19 4:00 ` David Lin
2024-04-19 21:42 ` Brian Norris
2024-04-22 8:34 ` David Lin
2024-04-23 2:29 ` David Lin
2024-04-24 8:11 ` Marcel Holtmann
2024-04-25 2:40 ` David Lin
2024-04-26 1:08 ` Brian Norris
2024-05-02 8:34 ` David Lin
2024-05-13 1:27 ` David Lin [this message]
2024-05-23 0:50 ` Brian Norris
2024-04-26 1:00 ` Brian Norris
2024-04-26 3:04 ` David Lin
2024-04-25 2:09 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4PR04MB96381B9675BCA5861AEDEF25D1E22@PA4PR04MB9638.eurprd04.prod.outlook.com \
--to=yu-hao.lin@nxp.com \
--cc=briannorris@chromium.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rafael.beims@toradex.com \
--cc=tsung-hsien.hsieh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).