From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: pull-request: rtw-next-2024-05-04
Date: Sun, 05 May 2024 07:28:59 +0300 [thread overview]
Message-ID: <87o79knapg.fsf@kernel.org> (raw)
In-Reply-To: <6df3012b6edb9aa8bffa170c1d9144750494bee8.camel@realtek.com> (Ping-Ke Shih's message of "Sun, 5 May 2024 02:22:36 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
> On Sat, 2024-05-04 at 16:38 +0300, Kalle Valo wrote:
>>
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>>
>> > On Sat, 2024-05-04 at 07:10 +0000, Kalle Valo wrote:
>> > > drivers/net/wireless/realtek/rtlwifi/rtl8192d/hw_common.c:986:2:
>> > > ./include/linux/bitfield.h:189:15: warning: 'rate_mask' is used
>> > > uninitialized [-Wuninitialized]
>> > >
>> >
>> > I have updated gcc to 13.2.1 (local build), but still can't see this warning.
>>
>> I'm not sure if you aware that crosstool provides an easy way to test
>> different compilers. More info here:
>>
>> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#tools
>
>
> I didn't know that before, and I use that convenient cross build now. :-)
There are also similar packages for clang:
https://mirrors.edge.kernel.org/pub/tools/llvm/
> A question about GNUmakefile, it seems miss
>
> include Makefile
>
> Otherwise, 'make' told me no rules to make.
Indeed, thanks for reporting that. I fixed now the wiki.
>> > Then, I force to add -Wuninitialized and delete -Wno-maybe-uninitialized
>> > locally, and I can see this warning (but -Wmaybe-uninitialized instead).
>> >
>> > I did suspect wireless-next tree does more compiler options, so I also
>> > tried to merge the tree, but still the same.
>>
>> Weird, maybe it's due to different kconfig options? I have attached my
>> .config which I use to compile test wireless trees.
>
> Using your .config can reproduce the symptom, and then I try to bisect CONFIG_xxx.
> The cause is "CONFIG_DEBUG_SECTION_MISMATCH=y". My .config didn't have that.
>
> I also tried my original compiler that can also see the warning with
> new .config.
Ah, I would not have never guessed that option could cause something
like this. Very good to know.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-05-05 4:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 0:38 pull-request: rtw-next-2024-05-04 Ping-Ke Shih
2024-05-04 7:10 ` Kalle Valo
2024-05-04 11:16 ` Ping-Ke Shih
2024-05-04 13:38 ` Kalle Valo
2024-05-05 2:22 ` Ping-Ke Shih
2024-05-05 4:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o79knapg.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).