From: Marek Vasut <marex@denx.de>
To: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Abhishek Naik <abhishek.naik@intel.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH] iwlwifi: mvm: Ignore NVM write status 0x1000
Date: Mon, 13 May 2024 16:44:40 +0200 [thread overview]
Message-ID: <3fb87569-61af-4779-a468-5e91d50482b3@denx.de> (raw)
In-Reply-To: <MW5PR11MB5810BC2C41C580237BAD3958A3E22@MW5PR11MB5810.namprd11.prod.outlook.com>
On 5/13/24 9:26 AM, Korenblit, Miriam Rachel wrote:
>
>> -----Original Message-----
>> From: Marek Vasut <marex@denx.de>
>> Sent: Sunday, 12 May 2024 21:49
>> To: linux-wireless@vger.kernel.org
>> Cc: Marek Vasut <marex@denx.de>; Abhishek Naik <abhishek.naik@intel.com>;
>> Grumbach, Emmanuel <emmanuel.grumbach@intel.com>; Gregory Greenman
>> <gregory.greenman@intel.com>; Berg, Johannes <johannes.berg@intel.com>;
>> Kalle Valo <kvalo@kernel.org>; Korenblit, Miriam Rachel
>> <miriam.rachel.korenblit@intel.com>
>> Subject: [PATCH] iwlwifi: mvm: Ignore NVM write status 0x1000
>>
>> When loading custom NVM file on Wireless-AC 9260 160MHz, REV=0x324
>> 8086:2526 (rev 29) Subsystem: 8086:001c firmware version 46.6b541b68.0 9260-
>> th-b0-jf-b0-46.ucode , the NVM_WRITE_OPCODE return status is 0x1000 for all
>> sections. What does this mean is unknown, however clearing the top 4 bits
>> permits the NVM to be written and the card operates as it should.
>>
>> Hexdump of the iNVM file is below, the iNVM file overrides antenna settings to
>> only use AUX antenna and disables MIMO .
>
> The custom NVM is meant for internal use only.
But why does NVM loading not work without this patch ?
> To override antenna settings please use the nl80211 command: NL80211_CMD_SET_WIPHY
> You can use the 'iw set antenna' command.
I need to use only the AUX antenna and disable MIMO entirely, the 'iw
set antenna' didn't work, the custom NVM fragment does work.
But I do need this extra patch to load the NVM fragment.
Is the patch correct ? Why is the 0x1000 returned and why does it have
to be masked out ?
prev parent reply other threads:[~2024-05-13 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 18:48 [PATCH] iwlwifi: mvm: Ignore NVM write status 0x1000 Marek Vasut
2024-05-13 7:26 ` Korenblit, Miriam Rachel
2024-05-13 14:44 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb87569-61af-4779-a468-5e91d50482b3@denx.de \
--to=marex@denx.de \
--cc=abhishek.naik@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).