From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: arnd@arndb.de, linux@roeck-us.net, wim@linux-watchdog.org,
alim.akhtar@samsung.com, jaewon02.kim@samsung.com,
semen.protsenko@linaro.org, kernel-team@android.com,
tudor.ambarus@linaro.org, andre.draszik@linaro.org,
saravanak@google.com, willmcvicker@google.com,
linux-fsd@tesla.com, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs
Date: Wed, 7 Feb 2024 15:48:18 +0100 [thread overview]
Message-ID: <d367bd65-605e-44b7-9400-acd463dec0b6@linaro.org> (raw)
In-Reply-To: <CADrjBPrWH8uFrFmn_CZpr+fAnPrzbDT4i9XuMXJqKfzeouPpKg@mail.gmail.com>
On 07/02/2024 12:42, Peter Griffin wrote:
>>>>> #include <linux/soc/samsung/exynos-regs-pmu.h>
>>>>> #include <linux/soc/samsung/exynos-pmu.h>
>>>>>
>>>>> #include "exynos-pmu.h"
>>>>>
>>>>> +static struct platform_driver exynos_pmu_driver;
>>>>
>>>> I don't understand why do you need it. You can have only one
>>>> pmu_context. The moment you probe second one, previous becomes invalid.
>>>>
>>>> I guess you want to parse phandle and check if just in case if it points
>>>> to the right device, but still the original code is not ready for two
>>>> PMU devices. I say either this problem should be solved entirely,
>>>> allowing two devices, or just compare device node from phandle with
>>>> device node of exynos_pmu_context->dev and return -EINVAL on mismatches.
>>>
>>> Apologies I didn't answer your original question. This wasn't about
>>> having partial support for multiple pmu devices. It is being used by
>>> driver_find_device_by_of_node() in exynos_get_pmu_regmap_by_phandle()
>>> to determine that the exynos-pmu device has probed and therefore a
>>> pmu_context exists and a regmap has been created and can be returned
>>> to the caller (as opposed to doing a -EPROBE_DEFER).
>>>
>>> Is there some better/other API you recommend for this purpose? Just
>>> checking pmu_context directly seems racy, so I don't think we should
>>> do that.
>>
>> Hm, I don't quite get why you cannot use of_find_device_by_node()?
>
> of_find_device_by_node() returns a platform_device, even if the driver
> hasn't probed. Whereas driver_find_device_by_of_node() iterates
> devices bound to a driver.
>
> If using of_find_device_by_node() API I could check the result of
> platform_get_drvdata(), and -EPROBE_DEFER if NULL (that pattern seems
> to be used by a few drivers). But that AFAIK only guarantees you
> reached the platform_set_drvdata() call in your driver probe()
> function, not that it has completed.
All drivers, except two, use of_find_device_by_node(), so basically you
claim they are all broken. If that's true, the core API and these
drivers should be fixed, instead of implementing here entirely different
pattern.
of_find_device_by_node() goes via platform_bus_type->sp->klist_devices
and devices are added to the list in device_add() after
bus_probe_device(dev), regardless of its success. Therefore after
successful first probe, you will have the same result.
>
> IMHO the drivers using driver_find_device_by_of_node() for probe
> deferral are doing it more robustly than those using
> of_find_device_by_node() and checking if platform_get_drvdata() is
> NULL.
Some are checking dev->driver, but this also looks buggy, because it is
called before actual drv->probe().
OK, let's go with this method. I dislike the difference from everyone
else, but it seems everyone else is doing it wrong. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-07 14:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 21:19 [PATCH v2 0/2] Add regmap support to exynos-pmu for protected PMU regs Peter Griffin
2024-01-29 21:19 ` [PATCH v2 1/2] soc: samsung: exynos-pmu: Add regmap support for SoCs that protect " Peter Griffin
2024-01-29 23:01 ` Sam Protsenko
2024-01-30 14:51 ` Peter Griffin
2024-01-30 6:26 ` Guenter Roeck
2024-01-30 15:01 ` Peter Griffin
2024-01-30 16:01 ` Krzysztof Kozlowski
2024-02-01 11:29 ` Peter Griffin
2024-02-05 11:03 ` Krzysztof Kozlowski
2024-02-01 12:51 ` Peter Griffin
2024-02-05 13:13 ` Krzysztof Kozlowski
2024-02-07 11:42 ` Peter Griffin
2024-02-07 14:48 ` Krzysztof Kozlowski [this message]
2024-01-29 21:19 ` [PATCH v2 2/2] watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for " Peter Griffin
2024-01-29 22:25 ` Saravana Kannan
2024-01-30 3:38 ` Sam Protsenko
2024-01-30 15:31 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d367bd65-605e-44b7-9400-acd463dec0b6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.griffin@linaro.org \
--cc=saravanak@google.com \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).