From: Andy Shevchenko <andy@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Guenter Roeck" <linux@roeck-us.net>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-watchdog@vger.kernel.org,
"Wim Van Sebroeck" <wim@linux-watchdog.org>
Subject: Re: [PATCH v9 5/9] platform: cznic: turris-omnia-mcu: Add support for MCU watchdog
Date: Wed, 8 May 2024 14:23:22 +0300 [thread overview]
Message-ID: <ZjtgqnOc6xzTLAt0@smile.fi.intel.com> (raw)
In-Reply-To: <20240508103118.23345-6-kabel@kernel.org>
On Wed, May 08, 2024 at 12:31:14PM +0200, Marek Behún wrote:
> Add support for the watchdog mechanism provided by the MCU.
...
> + return omnia_cmd_write_u16(mcu->client, OMNIA_CMD_SET_WDT_TIMEOUT,
> + timeout * 10);
DECI (from units.h)
...
> + return timeleft / 10;
Ditto.
...
> + mcu->wdt.max_timeout = 6553; /* 65535 deciseconds */
Ditto.
mcu->wdt.max_timeout = 65536 / DECI;
(and no need in a comment)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-08 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 10:31 [PATCH v9 0/9] Turris Omnia MCU driver Marek Behún
2024-05-08 10:31 ` [PATCH v9 2/9] platform: cznic: Add preliminary support for Turris Omnia MCU Marek Behún
2024-05-08 10:58 ` Andy Shevchenko
2024-05-08 11:07 ` Marek Behún
2024-05-08 10:31 ` [PATCH v9 5/9] platform: cznic: turris-omnia-mcu: Add support for MCU watchdog Marek Behún
2024-05-08 11:23 ` Andy Shevchenko [this message]
2024-05-08 11:17 ` [PATCH v9 0/9] Turris Omnia MCU driver Andy Shevchenko
2024-05-08 17:50 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjtgqnOc6xzTLAt0@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kabel@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=soc@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).