From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
p.zabel@pengutronix.de, geert+renesas@glider.be,
magnus.damm@gmail.com, biju.das.jz@bp.renesas.com,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v5 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM
Date: Wed, 7 Feb 2024 15:23:07 +0100 [thread overview]
Message-ID: <CAMuHMdV-Lw3Ay94_gYHU4A8iYSRbXy8b7XOiMQ93Mbs+-ApsGQ@mail.gmail.com> (raw)
In-Reply-To: <20240207130745.1783198-3-claudiu.beznea.uj@bp.renesas.com>
Hi Claudiu,
On Wed, Feb 7, 2024 at 2:08 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> clocks are enabled though pm_runtime_* specific APIs). To avoid building
> a driver that doesn't work make explicit the dependency on CONFIG_PM. Along
> with it the dependency on CONFIG_PM and CONFIG_COMPILE_TEST was moved to a
> new line to have the code simpler.
>
> Suggested-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v5:
> - updated patch description
> - added on a new line the dependency on PM and COMPILE_TEST
Thanks for the update!
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -910,7 +910,8 @@ config RENESAS_RZN1WDT
>
> config RENESAS_RZG2LWDT
> tristate "Renesas RZ/G2L WDT Watchdog"
> - depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> + depends on ARCH_RZG2L || ARCH_R9A09G011
Please drop this change (i.e. retain the "|| COMPILE_TEST"), as it prevents
compile-testing on any platforms but RZ/G2L(alike) and RZ/V2M.
> + depends on PM || COMPILE_TEST
> select WATCHDOG_CORE
> help
> This driver adds watchdog support for the integrated watchdogs in the
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-02-07 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 13:07 [PATCH v5 0/9] watchdog: rzg2l_wdt: Add support for RZ/G3S Claudiu
2024-02-07 13:07 ` [PATCH v5 1/9] watchdog: rzg2l_wdt: Restrict the driver to ARCH_RZG2L and ARCH_R9A09G011 Claudiu
2024-02-07 13:07 ` [PATCH v5 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM Claudiu
2024-02-07 14:23 ` Geert Uytterhoeven [this message]
2024-02-07 13:07 ` [PATCH v5 3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Claudiu
2024-02-07 13:07 ` [PATCH v5 4/9] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Claudiu
2024-02-07 13:07 ` [PATCH v5 5/9] watchdog: rzg2l_wdt: Remove reset de-assert from probe Claudiu
2024-02-07 13:07 ` [PATCH v5 6/9] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-02-07 13:07 ` [PATCH v5 7/9] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-02-07 13:07 ` [PATCH v5 8/9] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-02-07 13:07 ` [PATCH v5 9/9] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Claudiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV-Lw3Ay94_gYHU4A8iYSRbXy8b7XOiMQ93Mbs+-ApsGQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).